Re: [PATCH v3 09/14] serial: liteuart: fix rx loop variable types

Ilpo Järvinen
2022-11-15T15:47:06Z

[-- Attachment #1: Type: text/plain, Size: 956 bytes --]

On Sat, 12 Nov 2022, Gabriel Somlo wrote:

> Update variable types to match the signature of uart_insert_char()
> which consumes them.
>
> Signed-off-by: Gabriel Somlo <gsomlo@gmail.com>
> ---
> drivers/tty/serial/liteuart.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/liteuart.c b/drivers/tty/serial/liteuart.c
> index e9e99d6b5fef..974da0f73257 100644
> --- a/drivers/tty/serial/liteuart.c
> +++ b/drivers/tty/serial/liteuart.c
> @@ -72,8 +72,7 @@ static void liteuart_timer(struct timer_list *t)
> struct liteuart_port *uart = from_timer(uart, t, timer);
> struct uart_port *port = &uart->port;
> unsigned char __iomem *membase = port->membase;
> - int ch;
> - unsigned long status;
> + unsigned int status, ch;
>
> while ((status = !litex_read8(membase + OFF_RXEMPTY)) == 1) {
> ch = litex_read8(membase + OFF_RXTX);

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

--
i.