Re: [PATCH v3 08/14] serial: liteuart: simplify passing of uart_insert_char() flag

Ilpo Järvinen
2022-11-15T15:43:18Z

[-- Attachment #1: Type: text/plain, Size: 1224 bytes --]

On Sat, 12 Nov 2022, Gabriel Somlo wrote:

> Simply provide the hard-coded TTY_NORMAL flag to uart_insert_char()
> directly -- no need to dedicate a variable for that exclusive purpose.
>
> Signed-off-by: Gabriel Somlo <gsomlo@gmail.com>
> ---
> drivers/tty/serial/liteuart.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/liteuart.c b/drivers/tty/serial/liteuart.c
> index b5ab48aa35cf..e9e99d6b5fef 100644
> --- a/drivers/tty/serial/liteuart.c
> +++ b/drivers/tty/serial/liteuart.c
> @@ -72,7 +72,6 @@ static void liteuart_timer(struct timer_list *t)
> struct liteuart_port *uart = from_timer(uart, t, timer);
> struct uart_port *port = &uart->port;
> unsigned char __iomem *membase = port->membase;
> - unsigned int flg = TTY_NORMAL;
> int ch;
> unsigned long status;
>
> @@ -85,7 +84,7 @@ static void liteuart_timer(struct timer_list *t)
>
> /* no overflow bits in status */
> if (!(uart_handle_sysrq_char(port, ch)))
> - uart_insert_char(port, status, 0, ch, flg);
> + uart_insert_char(port, status, 0, ch, TTY_NORMAL);
> }
>
> tty_flip_buffer_push(&port->state->port);

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

--
i.