From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932931AbcIBTyA (ORCPT ); Fri, 2 Sep 2016 15:54:00 -0400 Received: from mail-it0-f54.google.com ([209.85.214.54]:35208 "EHLO mail-it0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932340AbcIBTx6 (ORCPT ); Fri, 2 Sep 2016 15:53:58 -0400 Subject: Re: [PATCHv2 2/4] staging: android: ion: Pull out ion ioctls to a separate file To: Greg Kroah-Hartman References: <1472769644-11039-1-git-send-email-labbott@redhat.com> <1472769644-11039-3-git-send-email-labbott@redhat.com> <20160902124421.GA11428@kroah.com> Cc: Sumit Semwal , John Stultz , =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= , Riley Andrews , Daniel Vetter , linaro-mm-sig@lists.linaro.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Eun Taik Lee , Liviu Dudau , Jon Medhurst , Mitchel Humpherys , Jeremy Gebben , Bryan Huntsman , Android Kernel Team , Chen Feng , Brian Starkey From: Laura Abbott Message-ID: Date: Fri, 2 Sep 2016 12:53:54 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160902124421.GA11428@kroah.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/02/2016 05:44 AM, Greg Kroah-Hartman wrote: > On Thu, Sep 01, 2016 at 03:40:42PM -0700, Laura Abbott wrote: >> >> The number of Ion ioctls may continue to grow along with necessary >> validation. Pull it out into a separate file for easier management >> and review. >> >> Signed-off-by: Laura Abbott >> --- >> drivers/staging/android/ion/Makefile | 3 +- >> drivers/staging/android/ion/ion-ioctl.c | 144 ++++++++++++++++++++++ >> drivers/staging/android/ion/ion.c | 210 ++------------------------------ >> drivers/staging/android/ion/ion_priv.h | 91 ++++++++++++++ >> 4 files changed, 244 insertions(+), 204 deletions(-) >> create mode 100644 drivers/staging/android/ion/ion-ioctl.c > > This patch doesn't apply cleanly to my tree, are we out of sync somehow? > > Can you rebase your outstanding patches against my staging-testing > branch and resend? > > thanks, > > greg k-h > Looks like I missed a rebase with one of the cleanup patches. I'll resend. Thanks, Laura