From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BC31305E32 for ; Wed, 6 May 2026 07:09:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778051374; cv=none; b=k7/wa/tRr9ZsN1MT4nR0/roG268/ze2e2Q05/t0e1NIHN0U7LIpSAjnOfgzlu7tFv6Fp4iGfIosKI520xGBpBhm4YF5OW8Tl/WNn6HMs3PDKZ6sWDYirIe+7u7GqZDR6R1yOc/zgAkv2GbYRHlxHXQd6m2o2dFebi1bA1Cow4Bw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778051374; c=relaxed/simple; bh=vvariKpSLXBVCVyZYR/OEUF/P0GtuR2yTqRCxKpPd0M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MCzTMXs3S6IDs81kXKrdUhFWziaWCABlb6Nh6VzcPt5pf4hBc5lv0Hin/YicijCXgl7i/r/1abe6KtEAf5hl6td2/FVDybP9Feqn6Upoj/YPf09LNomzRML17N+dOuAqZCX9iy6OEqwTP6ZAKglMoYlVUgrWWDuWunF27y5a4Q0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20251104.gappssmtp.com header.i=@kernel-dk.20251104.gappssmtp.com header.b=NRU2rSQs; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20251104.gappssmtp.com header.i=@kernel-dk.20251104.gappssmtp.com header.b="NRU2rSQs" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-44a786a9a35so3294149f8f.3 for ; Wed, 06 May 2026 00:09:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20251104.gappssmtp.com; s=20251104; t=1778051369; x=1778656169; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=i/NNK31KWxsQZ1iecY4atieFZgPU2Vu2GTBkZCQW8vg=; b=NRU2rSQsD6eSP3AK8j6YyfJxjzeWmZEzDH9Q1Lz8vCqEy0feLZa47W7kdwc+ymPoq6 KLnQ7tPK3eunSTtICKk+LoBtWCDoZdGF2FKf5KluduAXWzc8i7FFE/NK0gp+HR2Ijxc7 WHlOYKLU4L8gG6sSMee4hj8pe+GSGf4kHpvQnc9PiEpW4aSGhEGFFwLQ+obYR8xbk/rT 5BKsX4fi1t9500Q3tDbsK4I9CtXYPmUclWc3WzSCZdpH0lMhnF34nLH+zlcyfBvezwid TTXFKjA3nk23KrIhNZ2Anonuf/KhFB1m1d0CLr2N9oL5IPmadyLeTvXEifvXaTz+r5kV fG1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778051369; x=1778656169; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=i/NNK31KWxsQZ1iecY4atieFZgPU2Vu2GTBkZCQW8vg=; b=YW9nFRoE3obM3Qf37rjNe86mM8mErOKiBCvL6p66wS9/Cgk+adcYXpy5Lt+JeDZdkL OWGaLisI86EGgmDCX1XtmdzfmXsTh8/jARFE62qfo9pKEzrVBJQ+qb9c/u0JEYH8y/WW T9xzhbu0KnAzDRVjC13evfaGY03DmReJ4Pn3KsFFCILCY2mL3ucVtoNXdIfmeYpBC7lV hDpgJxrI1JqhzGtFZCyDC8CicudjCCEyQoGYxqZOwE2Qm0jxTgd4IGfC7zyCt/IaDV1x E3xoneTQAJXF+skOwe89zwoXUa5FBlIMt1pBKgjX9MVlGtQEfqN3V2BqsDY3s47as5+n oiLg== X-Forwarded-Encrypted: i=1; AFNElJ8kq6uTqwSZadT+3E/05rbVHcRWE5xoiJolcM4CVFemTRBfT3sHUW4zZ3qN59cGiP2xRKCKyP7jAfNf1PM=@vger.kernel.org X-Gm-Message-State: AOJu0YxPW7g8SIWJxBNfpW0WZr0QGe+VUBWJFEGKqWx3TBVwUgN0nQod xHQ0yK5l2MPeVGAgfuLC47pp6LE61lcdgYlXuvEnDYqQpO3RJrATffWzu6dWXOUG7pFiyBvI0YR FjgNPD1w= X-Gm-Gg: AeBDies0yBlY0DdHGoIxqhMNHMYLyY9JnINeTlDSCP7U5tKXHnMGoNmaxN2BLOYBJkI KYeEbl5YHdHrXhKuT5tZ50JYZXFB1P3xLmxDRIXzMvnwm1HNJD1HiUzJNcSi6p1w/N0aRvJ5+pp hblPt+JwgJ3IuLsVx0Z0trz0pa6x8313+1c4TS4QmqyTNUJj7SPHuIzeOnkn0ltO37/B/c/Vux9 xiKODwZMG/IZv+J8kg1C6mn7o2NmIPsd6D2oCyrDXwtrF4ayGbkOa0NwTlFWXT2c0R5RPtPWEOD v0kJXve8rpNSKkTsoIjxoTp1wzFVfi9EcUxgpg8i8UWXUhLwlw1B1hEd/s/rE/U/rOmjLfMXl4c 4vu88pn/I5f9fZFoppc3NnqhHES9aqr8wuM0Kmn6a28TSabgcYLj3DgPKex08Wz6D2Qppm+fW43 7UqbpkVSVlqUNRTs0+bo554P6blGaruPZ6XnG8FCfZKzHvCyixg7VQSDvGQ98QKiaSAMkXJOR6u RQoNPpKgVq4iIucrUMyFpeyugsVdgc= X-Received: by 2002:a5d:5d03:0:b0:43d:68dc:9ca6 with SMTP id ffacd0b85a97d-4515b5254b6mr3720321f8f.18.1778051369468; Wed, 06 May 2026 00:09:29 -0700 (PDT) Received: from [10.211.9.173] ([213.147.98.98]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45055f249bbsm9065327f8f.36.2026.05.06.00.09.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 May 2026 00:09:28 -0700 (PDT) Message-ID: Date: Wed, 6 May 2026 01:09:27 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] block: bic maybe null pointer dereference To: yanlonglong , yukuai@fnnas.com Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260506055655.32276-1-yanlonglong@kylinos.cn> Content-Language: en-US From: Jens Axboe In-Reply-To: <20260506055655.32276-1-yanlonglong@kylinos.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/5/26 11:56 PM, yanlonglong wrote: > Signed-off-by: yanlonglong Your subject line is incomplete, and your commit message is even more incomplete. > diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c > index 141c602d5e85..27ef736085b1 100644 > --- a/block/bfq-iosched.c > +++ b/block/bfq-iosched.c > @@ -3035,9 +3035,6 @@ bfq_setup_cooperator(struct bfq_data *bfqd, struct bfq_queue *bfqq, > static void bfq_bfqq_save_state(struct bfq_queue *bfqq) > { > struct bfq_io_cq *bic = bfqq->bic; > - unsigned int a_idx = bfqq->actuator_idx; > - struct bfq_iocq_bfqq_data *bfqq_data = &bic->bfqq_data[a_idx]; > - > /* > * If !bfqq->bic, the queue is already shared or its requests > * have already been redirected to a shared queue; both idle window > @@ -3046,6 +3043,9 @@ static void bfq_bfqq_save_state(struct bfq_queue *bfqq) > if (!bic) > return; > > + unsigned int a_idx = bfqq->actuator_idx; > + struct bfq_iocq_bfqq_data *bfqq_data = &bic->bfqq_data[a_idx]; > + > bfqq_data->saved_last_serv_time_ns = bfqq->last_serv_time_ns; > bfqq_data->saved_inject_limit = bfqq->inject_limit; > bfqq_data->saved_decrease_time_jif = bfqq->decrease_time_jif; Ehm no, variable declarations go at the top. Please try again, correcting the title/subject and ACTUALLY write a commit message. See: Documentation/process/submitting-patches.rst -- Jens Axboe