From: Guenter Roeck <linux@roeck-us.net>
To: XU pengfei <xupengfei@nfschina.com>, jdelvare@suse.com
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] hwmon: remove unnecessary (void*) conversions
Date: Tue, 10 Jan 2023 19:29:20 -0800 [thread overview]
Message-ID: <db4276db-bbec-142a-d306-928421eb49fc@roeck-us.net> (raw)
In-Reply-To: <20230111020723.3194-1-xupengfei@nfschina.com>
On 1/10/23 18:07, XU pengfei wrote:
> Pointer variables of void * type do not require type cast.
>
One patch per driver, and include the driver name (ibmpex, powr1220)
in the subject.
Guenter
> Signed-off-by: XU pengfei <xupengfei@nfschina.com>
> ---
> drivers/hwmon/ibmpex.c | 2 +-
> drivers/hwmon/powr1220.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hwmon/ibmpex.c b/drivers/hwmon/ibmpex.c
> index 1837cccd993c..db066b368918 100644
> --- a/drivers/hwmon/ibmpex.c
> +++ b/drivers/hwmon/ibmpex.c
> @@ -546,7 +546,7 @@ static void ibmpex_bmc_gone(int iface)
>
> static void ibmpex_msg_handler(struct ipmi_recv_msg *msg, void *user_msg_data)
> {
> - struct ibmpex_bmc_data *data = (struct ibmpex_bmc_data *)user_msg_data;
> + struct ibmpex_bmc_data *data = user_msg_data;
>
> if (msg->msgid != data->tx_msgid) {
> dev_err(data->bmc_device,
> diff --git a/drivers/hwmon/powr1220.c b/drivers/hwmon/powr1220.c
> index f77dc6db31ac..501337ee5aa3 100644
> --- a/drivers/hwmon/powr1220.c
> +++ b/drivers/hwmon/powr1220.c
> @@ -174,7 +174,7 @@ static umode_t
> powr1220_is_visible(const void *data, enum hwmon_sensor_types type, u32
> attr, int channel)
> {
> - struct powr1220_data *chip_data = (struct powr1220_data *)data;
> + struct powr1220_data *chip_data = data;
>
> if (channel >= chip_data->max_channels)
> return 0;
next prev parent reply other threads:[~2023-01-11 3:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 2:07 [PATCH 1/1] hwmon: remove unnecessary (void*) conversions XU pengfei
2023-01-11 3:29 ` Guenter Roeck [this message]
2023-01-11 6:03 ` Ammar Faizi
2023-01-11 6:09 ` Ammar Faizi
2023-01-11 7:24 ` kernel test robot
2023-01-11 7:54 ` kernel test robot
2023-01-11 8:55 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db4276db-bbec-142a-d306-928421eb49fc@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xupengfei@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox