From: Bryan O'Donoghue <bod@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Clark <robin.clark@oss.qualcomm.com>,
Dmitry Baryshkov <lumag@kernel.org>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Jessica Zhang <jesszhan0024@gmail.com>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Akhil P Oommen <akhilpo@oss.qualcomm.com>,
Vikash Garodia <vikash.garodia@oss.qualcomm.com>,
Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH 01/11] soc: qcom: ubwc: add missing include
Date: Sun, 11 Jan 2026 20:58:46 +0000 [thread overview]
Message-ID: <db61a94f-c24f-453b-ba0f-68a1ca55f787@kernel.org> (raw)
In-Reply-To: <20260110-iris-ubwc-v1-1-dd70494dcd7b@oss.qualcomm.com>
On 10/01/2026 19:37, Dmitry Baryshkov wrote:
> The header has a function which calls pr_err(). Don't require users of
> the header to include <linux/printk.h> and include it here.
>
> Fixes: 87cfc79dcd60 ("drm/msm/a6xx: Resolve the meaning of UBWC_MODE")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---
> include/linux/soc/qcom/ubwc.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/soc/qcom/ubwc.h b/include/linux/soc/qcom/ubwc.h
> index 0a4edfe3d96d..f052e241736c 100644
> --- a/include/linux/soc/qcom/ubwc.h
> +++ b/include/linux/soc/qcom/ubwc.h
> @@ -8,6 +8,7 @@
> #define __QCOM_UBWC_H__
>
> #include <linux/bits.h>
> +#include <linux/printk.h>
> #include <linux/types.h>
>
> struct qcom_ubwc_cfg_data {
>
> --
> 2.47.3
>
>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
next prev parent reply other threads:[~2026-01-11 20:58 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-10 19:37 [PATCH 00/11] media: iris: migrate to using global UBWC config Dmitry Baryshkov
2026-01-10 19:37 ` [PATCH 01/11] soc: qcom: ubwc: add missing include Dmitry Baryshkov
2026-01-11 20:58 ` Bryan O'Donoghue [this message]
2026-01-10 19:37 ` [PATCH 02/11] soc: qcom: ubwc: add helper to get min_acc length Dmitry Baryshkov
2026-01-11 21:03 ` Bryan O'Donoghue
2026-01-11 21:05 ` Bryan O'Donoghue
2026-01-11 22:39 ` Dmitry Baryshkov
2026-01-12 11:08 ` Konrad Dybcio
2026-01-13 0:24 ` Dmitry Baryshkov
2026-01-13 15:26 ` Konrad Dybcio
2026-01-13 16:48 ` Dmitry Baryshkov
2026-01-14 22:22 ` Bjorn Andersson
2026-01-10 19:37 ` [PATCH 03/11] media: iris: retrieve UBWC platform configuration Dmitry Baryshkov
2026-01-11 21:01 ` Bryan O'Donoghue
2026-01-10 19:37 ` [PATCH 04/11] media: iris: don't specify min_acc_length in the source code Dmitry Baryshkov
2026-01-11 21:06 ` Bryan O'Donoghue
2026-01-11 22:43 ` Dmitry Baryshkov
2026-01-10 19:37 ` [PATCH 05/11] media: iris: don't specify highest_bank_bit " Dmitry Baryshkov
2026-01-11 21:07 ` Bryan O'Donoghue
2026-01-12 11:02 ` Konrad Dybcio
2026-01-10 19:37 ` [PATCH 06/11] media: iris: don't specify ubwc_swizzle " Dmitry Baryshkov
2026-01-11 21:08 ` Bryan O'Donoghue
2026-01-12 11:03 ` Konrad Dybcio
2026-01-10 19:37 ` [PATCH 07/11] media: iris: don't specify bank_spreading " Dmitry Baryshkov
2026-01-11 21:09 ` Bryan O'Donoghue
2026-01-12 11:03 ` Konrad Dybcio
2026-01-10 19:38 ` [PATCH 08/11] media: iris: don't specify max_channels " Dmitry Baryshkov
2026-01-11 21:09 ` Bryan O'Donoghue
2026-01-12 11:05 ` Konrad Dybcio
2026-01-10 19:38 ` [PATCH 09/11] media: iris: drop remnants of UBWC configuration Dmitry Baryshkov
2026-01-11 21:10 ` Bryan O'Donoghue
2026-01-12 11:06 ` Konrad Dybcio
2026-01-10 19:38 ` [PATCH 10/11] drm/msm/mdss: use new helper to set min_acc length Dmitry Baryshkov
2026-01-12 11:08 ` Konrad Dybcio
2026-01-10 19:38 ` [PATCH 11/11] drm/msm/a6xx: " Dmitry Baryshkov
2026-01-12 11:07 ` Konrad Dybcio
2026-01-15 3:00 ` (subset) [PATCH 00/11] media: iris: migrate to using global UBWC config Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db61a94f-c24f-453b-ba0f-68a1ca55f787@kernel.org \
--to=bod@kernel.org \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=akhilpo@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=dikshita.agarwal@oss.qualcomm.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=mchehab@kernel.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=vikash.garodia@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox