Re: [PATCH v17 10/10] drm/mediatek: dp: Audio support for MT8195

CK Hu
2022-09-02T08:58:13Z

Hi, Bo-Chen:

On Thu, 2022-09-01 at 12:41 +0800, Bo-Chen Chen wrote:
> From: Guillaume Ranquet <granquet@baylibre.com>
>
> This patch adds audio support to the DP driver for MT8195 with up to
> 8
> channels.
>
> Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
> Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_dp.c | 482
> +++++++++++++++++++++++++-
> drivers/gpu/drm/mediatek/mtk_dp_reg.h | 51 +++
> 2 files changed, 532 insertions(+), 1 deletion(-)
>
>

[snip]

> +#define MTK_DP_ENC0_P0_308C 0x308c
> +#define CH_STATUS_0_DP_ENC0_P0_MASK GENMASK(15, 0)
> +#define MTK_DP_ENC0_P0_3090 0x3090
> +#define CH_STATUS_1_DP_ENC0_P0_MASK GENMASK(15, 0)
> +#define MTK_DP_ENC0_P0_3094 0x3094
> +#define CH_STATUS_2_DP_ENC0_P0_MASK GENMASK(7, 0)
> +#define MTK_DP_ENC0_P0_30A0 0x30a0

Useless, so drop it.

Regards,
CK

> +#define DP_ENC0_30A0_MASK (BIT(7) |
> BIT(8) | BIT(12))
> +#define MTK_DP_ENC0_P0_30A4 0x30a4
> +#define AU_TS_CFG_DP_ENC0_P0_MASK GENMASK(7, 0)
> +#define MTK_DP_ENC0_P0_30A8 0x30a8
>