From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4C22B13D539 for ; Fri, 8 May 2026 03:36:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778211401; cv=none; b=Lo8sZ0rxACzMyNC4Bmn9fJptFXE0NJ6UKU4OMWV3SAPAj+cQWdawZZNBF2o+k+bbgmEL2WQnOOa3EuNI4C4cdCgrbD8jCWKDFHl26+S42BJc9gxKoihd0jiN8KdVj89Qnqe8vUf9i3adJZk+/teLfNRiwMFejYO2UzAha+VT4U8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778211401; c=relaxed/simple; bh=mk4Lt8wh0ylDn1xADLunA5G8XPgmpv6UrFPataLZ3NE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=V2UerfmmFNtHsc2z5Bnw5SeLZW745/4IQhGMhFEC/QMaXNufEfqFubwc0KhQE8SYnG28H/Bpe+yxAl8VQQ3OIzyBErymMXALeZgmBZuIhEcb4J7ruGce6pHPlj8bkDsBfRZYutsffL9BLrzZoAnHNpY/zE6uBliUywCVu0vYxJI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=jwX37HAx; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="jwX37HAx" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5E8AE3583; Thu, 7 May 2026 20:36:31 -0700 (PDT) Received: from [10.164.148.34] (MacBook-Pro.blr.arm.com [10.164.148.34]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 705BB3F7B4; Thu, 7 May 2026 20:36:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1778211396; bh=mk4Lt8wh0ylDn1xADLunA5G8XPgmpv6UrFPataLZ3NE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=jwX37HAxvI7KY4wcwGMXkIN55CFUD0B+yZyN3ei7dQdjOQy6VaibWx9PFMaet/dcL jyXnoanUT4poVTeg+lsPbZc1qFrqaTjePr6pVzyYovnTusPpYQVMxqmhuS9uv77FQk z/MwQqR8VREONf37XuxV//3Q6kDgERBb3J8loFWo= Message-ID: Date: Fri, 8 May 2026 09:06:22 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 09/28] mm: vma_alloc_anon_folio_pmd: pass raw fault address to vma_alloc_folio To: "Michael S. Tsirkin" , linux-kernel@vger.kernel.org Cc: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Barry Song , Lance Yang , linux-mm@kvack.org References: <96a2f5a938bf65315ac95e75b4e7741bae018cdd.1778192416.git.mst@redhat.com> Content-Language: en-US From: Dev Jain In-Reply-To: <96a2f5a938bf65315ac95e75b4e7741bae018cdd.1778192416.git.mst@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 08/05/26 3:52 am, Michael S. Tsirkin wrote: > Now that vma_alloc_folio aligns the address internally, drop the > redundant HPAGE_PMD_MASK alignment at the callsite. > > Signed-off-by: Michael S. Tsirkin > --- Hello Michael, Could you please send the whole patchset or at least the cover letter too, to everyone CCed on at least one patch? I only got two patches from the patchset in my inbox so I have no context :) > mm/huge_memory.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 8e2746ea74ad..f51c0841ce91 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -1260,7 +1260,7 @@ static struct folio *vma_alloc_anon_folio_pmd(struct vm_area_struct *vma, > const int order = HPAGE_PMD_ORDER; > struct folio *folio; > > - folio = vma_alloc_folio(gfp, order, vma, addr & HPAGE_PMD_MASK); > + folio = vma_alloc_folio(gfp, order, vma, addr); > > if (unlikely(!folio)) { > count_vm_event(THP_FAULT_FALLBACK);