From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6ACBF1F9428 for ; Mon, 2 Dec 2024 08:08:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733126912; cv=none; b=rT6bwlQcDRnE5VuXD3V7gwG2uxOqWSKk4BPXg3k9nekOvNYuMYCZ4l8We8Gae/F4mWEA0brmZvzBKqAwQGPr2oy5mcvuSSwa9SKwArqSGaKMaHXrpdaoI/TOMRO7+TlKVXrcde4GSSKN+yTmBABKk92xvmnzkZBBCD6w/eg0hnQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733126912; c=relaxed/simple; bh=iS5P/TmdSvSmouyGv1HDCNHfayN4+P7ZVBi4hwvFtak=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=sEpkU5ET0KZF+OMGzVq6ya9Pqg4l3bmxTH0vo+YWI8EGyXVSRzNTNVwcmCXWRxfAIS+hqplHEqRjhKGrjVO30x1BULRdDnKmRLu17zAO5dBJTsR21bMiObEH9jrAmrFCrdG9EdNK1NOcUcBusPOoE5qaZUq5We05Me9ydtKELCo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=VgBbCzp5; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="VgBbCzp5" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-385e96a285eso676183f8f.3 for ; Mon, 02 Dec 2024 00:08:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1733126909; x=1733731709; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=biIoGOQqyq3N6XA0zNtfB70JTNOwYolG4EVywUtJAns=; b=VgBbCzp5ANLq93+U0LSqcq7eAwKg60YI4/c1qSQNNGLPFS0d+GuC9ht4/9loQuJWlZ V2ELxvKgWMt+C0wMUyDn1PYpMkauWJJNoXG94S+SRofE3XnS3/OXA2dP4IoHJTKlVDTC HODhjGAALzETzo8mbewXvakb/qqgZRJVu57S7MA2bzyQnQ30l43YF9VxQMAyCSqfk3HZ Vpu5nhEh4kRdKUeIlESNV0fjUy6ZlDrZjDnmFE2c/IXnG6d+mhDvqlDuHZwtiTJde4Yr TpRUCZeqXqgQR81hOZkz/17E5wbW0dYphgQ81NN9KgiGodW9/HUYQCw/FqEnq7/dFlG1 XoeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733126909; x=1733731709; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=biIoGOQqyq3N6XA0zNtfB70JTNOwYolG4EVywUtJAns=; b=tFvqrgmHyj422N57YnRjMFU4BrGruEswy8ftqJTWkaSBYzPjeZ+sPfV8sOUZLYVB+Q 5egkAns96hvjK60tyNQflWgyMXc10QGPTntBYeg50vexhEUCTaVgqmGvLVbsRYOVH3ks 6l/Zv9Bq0upxBd80eyHmP2+2KEho3N2he0DMQHYf13XoMpcmOLOQ1ZtMX/uMMUxs22WZ cih1SNL6s1MDKp9i8fEbns04jrDvypLEAK1J9qJpwkI4AtOYTOJ0HDYZN1hUxm12jPJ0 GUTdLs1kh8V03J1Nbg8lFCxR3t23UxdU+mxhyLXrvT92oudKToQHibosvxTy2dhn0Thx OX0g== X-Forwarded-Encrypted: i=1; AJvYcCViG92LbkQ1v4lCRjHlWZGKz90U+tMo1n2ir8aZQK5AAHCH+Xt/z9PWHZQc6pXncyH0Ja0aK9DyeLtc3mc=@vger.kernel.org X-Gm-Message-State: AOJu0YwMrE6TlVEXaMUGUy287Tn2Vx/6PPdxdvl/3Y8h+XjzE9KP7gZv sAqaZinBCz5qDW5ClBi81ajmopGlphjirP22C5wzEmtezeRC0VoP6MrEBszhrgU= X-Gm-Gg: ASbGncsPZp3pZ5dh2gBizJtjAO473gnAHp0AsnW6OhhelBmbWAUfZIolo472Ec4mEqo LTJ8pBoIeC8VoNvTMy/+3+UR+Ad3Bia1K6d5jPFzwgN23Yqa8IoFlgoZO9fbqkcFbtfVbwQb18U EEV3Uyh865lw19QFp/m1ZXYvGWIundSzY72iV+jGhwHX1peUHEE+GzAopO60SVY/sDoCkAFy/mz 596QvaFNPcATOL/q2HVf+tK6G9qsynylI+hg91A6ox3TCjS+KaPN+Nb0A== X-Google-Smtp-Source: AGHT+IE/FN2ZItFsru5z5bnmJFaCMjGBYDDtPToGAA6DQa0WbEd1yHKPiHr3G9UCYQzQErXFFCJrCA== X-Received: by 2002:a5d:6dac:0:b0:382:32ec:f5b4 with SMTP id ffacd0b85a97d-385c6edd38emr19115560f8f.47.1733126908581; Mon, 02 Dec 2024 00:08:28 -0800 (PST) Received: from [192.168.50.4] ([82.78.167.46]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-385e8783843sm5908426f8f.4.2024.12.02.00.08.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Dec 2024 00:08:28 -0800 (PST) Message-ID: Date: Mon, 2 Dec 2024 10:08:25 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] ARM: dts: microchip: sam9x7: Move i2c address/size to dtsi Content-Language: en-US To: Mihai Sain , robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20241122080523.3941-1-mihai.sain@microchip.com> <20241122080523.3941-2-mihai.sain@microchip.com> From: Claudiu Beznea In-Reply-To: <20241122080523.3941-2-mihai.sain@microchip.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, Mihai, On 22.11.2024 10:05, Mihai Sain wrote: > Since these properties are common for all i2c subnodes, > move them to SoC dtsi from board dts. > > Signed-off-by: Mihai Sain Reviewed-by: Claudiu Beznea > --- > .../dts/microchip/at91-sam9x75_curiosity.dts | 2 -- > arch/arm/boot/dts/microchip/sam9x7.dtsi | 26 +++++++++++++++++++ > 2 files changed, 26 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts b/arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts > index 87b6ea97590b..d453800f8e35 100644 > --- a/arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts > +++ b/arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts > @@ -88,8 +88,6 @@ &flx6 { > }; > > &i2c6 { > - #address-cells = <1>; > - #size-cells = <0>; > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_flx6_default>; > i2c-analog-filter; > diff --git a/arch/arm/boot/dts/microchip/sam9x7.dtsi b/arch/arm/boot/dts/microchip/sam9x7.dtsi > index beb1f34b38d3..aedba0a8318f 100644 > --- a/arch/arm/boot/dts/microchip/sam9x7.dtsi > +++ b/arch/arm/boot/dts/microchip/sam9x7.dtsi > @@ -151,6 +151,8 @@ i2c4: i2c@600 { > compatible = "microchip,sam9x7-i2c", "microchip,sam9x60-i2c"; > reg = <0x600 0x200>; > interrupts = <13 IRQ_TYPE_LEVEL_HIGH 7>; > + #address-cells = <1>; > + #size-cells = <0>; > clocks = <&pmc PMC_TYPE_PERIPHERAL 13>; > dmas = <&dma0 > (AT91_XDMAC_DT_MEM_IF(0) | > @@ -220,6 +222,8 @@ i2c5: i2c@600 { > compatible = "microchip,sam9x7-i2c", "microchip,sam9x60-i2c"; > reg = <0x600 0x200>; > interrupts = <14 IRQ_TYPE_LEVEL_HIGH 7>; > + #address-cells = <1>; > + #size-cells = <0>; > clocks = <&pmc PMC_TYPE_PERIPHERAL 14>; > dmas = <&dma0 > (AT91_XDMAC_DT_MEM_IF(0) | > @@ -312,6 +316,8 @@ i2c11: i2c@600 { > compatible = "microchip,sam9x7-i2c", "microchip,sam9x60-i2c"; > reg = <0x600 0x200>; > interrupts = <32 IRQ_TYPE_LEVEL_HIGH 7>; > + #address-cells = <1>; > + #size-cells = <0>; > clocks = <&pmc PMC_TYPE_PERIPHERAL 32>; > dmas = <&dma0 > (AT91_XDMAC_DT_MEM_IF(0) | > @@ -362,6 +368,8 @@ i2c12: i2c@600 { > compatible = "microchip,sam9x7-i2c", "microchip,sam9x60-i2c"; > reg = <0x600 0x200>; > interrupts = <33 IRQ_TYPE_LEVEL_HIGH 7>; > + #address-cells = <1>; > + #size-cells = <0>; > clocks = <&pmc PMC_TYPE_PERIPHERAL 33>; > dmas = <&dma0 > (AT91_XDMAC_DT_MEM_IF(0) | > @@ -533,6 +541,8 @@ i2c6: i2c@600 { > compatible = "microchip,sam9x7-i2c", "microchip,sam9x60-i2c"; > reg = <0x600 0x200>; > interrupts = <9 IRQ_TYPE_LEVEL_HIGH 7>; > + #address-cells = <1>; > + #size-cells = <0>; > clocks = <&pmc PMC_TYPE_PERIPHERAL 9>; > dmas = <&dma0 > (AT91_XDMAC_DT_MEM_IF(0) | > @@ -583,6 +593,8 @@ i2c7: i2c@600 { > compatible = "microchip,sam9x7-i2c", "microchip,sam9x60-i2c"; > reg = <0x600 0x200>; > interrupts = <10 IRQ_TYPE_LEVEL_HIGH 7>; > + #address-cells = <1>; > + #size-cells = <0>; > clocks = <&pmc PMC_TYPE_PERIPHERAL 10>; > dmas = <&dma0 > (AT91_XDMAC_DT_MEM_IF(0) | > @@ -633,6 +645,8 @@ i2c8: i2c@600 { > compatible = "microchip,sam9x7-i2c", "microchip,sam9x60-i2c"; > reg = <0x600 0x200>; > interrupts = <11 IRQ_TYPE_LEVEL_HIGH 7>; > + #address-cells = <1>; > + #size-cells = <0>; > clocks = <&pmc PMC_TYPE_PERIPHERAL 11>; > dmas = <&dma0 > (AT91_XDMAC_DT_MEM_IF(0) | > @@ -702,6 +716,8 @@ i2c0: i2c@600 { > compatible = "microchip,sam9x7-i2c", "microchip,sam9x60-i2c"; > reg = <0x600 0x200>; > interrupts = <5 IRQ_TYPE_LEVEL_HIGH 7>; > + #address-cells = <1>; > + #size-cells = <0>; > clocks = <&pmc PMC_TYPE_PERIPHERAL 5>; > dmas = <&dma0 > (AT91_XDMAC_DT_MEM_IF(0) | > @@ -771,6 +787,8 @@ i2c1: i2c@600 { > compatible = "microchip,sam9x7-i2c", "microchip,sam9x60-i2c"; > reg = <0x600 0x200>; > interrupts = <6 IRQ_TYPE_LEVEL_HIGH 7>; > + #address-cells = <1>; > + #size-cells = <0>; > clocks = <&pmc PMC_TYPE_PERIPHERAL 6>; > dmas = <&dma0 > (AT91_XDMAC_DT_MEM_IF(0) | > @@ -840,6 +858,8 @@ i2c2: i2c@600 { > compatible = "microchip,sam9x7-i2c", "microchip,sam9x60-i2c"; > reg = <0x600 0x200>; > interrupts = <7 IRQ_TYPE_LEVEL_HIGH 7>; > + #address-cells = <1>; > + #size-cells = <0>; > clocks = <&pmc PMC_TYPE_PERIPHERAL 7>; > dmas = <&dma0 > (AT91_XDMAC_DT_MEM_IF(0) | > @@ -909,6 +929,8 @@ i2c3: i2c@600 { > compatible = "microchip,sam9x7-i2c", "microchip,sam9x60-i2c"; > reg = <0x600 0x200>; > interrupts = <8 IRQ_TYPE_LEVEL_HIGH 7>; > + #address-cells = <1>; > + #size-cells = <0>; > clocks = <&pmc PMC_TYPE_PERIPHERAL 8>; > dmas = <&dma0 > (AT91_XDMAC_DT_MEM_IF(0) | > @@ -984,6 +1006,8 @@ i2c9: i2c@600 { > compatible = "microchip,sam9x7-i2c", "microchip,sam9x60-i2c"; > reg = <0x600 0x200>; > interrupts = <15 IRQ_TYPE_LEVEL_HIGH 7>; > + #address-cells = <1>; > + #size-cells = <0>; > clocks = <&pmc PMC_TYPE_PERIPHERAL 15>; > dmas = <&dma0 > (AT91_XDMAC_DT_MEM_IF(0) | > @@ -1034,6 +1058,8 @@ i2c10: i2c@600 { > compatible = "microchip,sam9x7-i2c", "microchip,sam9x60-i2c"; > reg = <0x600 0x200>; > interrupts = <16 IRQ_TYPE_LEVEL_HIGH 7>; > + #address-cells = <1>; > + #size-cells = <0>; > clocks = <&pmc PMC_TYPE_PERIPHERAL 16>; > dmas = <&dma0 > (AT91_XDMAC_DT_MEM_IF(0) |