From: Rong Chen <rong.a.chen@intel.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
kernel test robot <lkp@intel.com>
Cc: Peter Oberparleiter <oberpar@linux.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
kbuild-all@lists.01.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [kbuild-all] Re: [PATCH] gcov: fail build on gcov_info size mismatch
Date: Fri, 12 Mar 2021 11:49:39 +0800 [thread overview]
Message-ID: <db88186a-d6af-33c9-f1fb-10b673b8fdd6@intel.com> (raw)
In-Reply-To: <CAHk-=whmwEJ-4tGamqOCw4BDJ-yjYrLRYxaFq5YurVc-XXO+hg@mail.gmail.com>
On 3/12/21 4:02 AM, Linus Torvalds wrote:
> On Thu, Mar 11, 2021 at 11:34 AM kernel test robot <lkp@intel.com> wrote:
>>>> kernel/gcov/geninfosize.sh: 13: [: =: unexpected operator
> Wth? I'm not seeing how this can fail on nds32 - doesn't look like a
> bashism, everything is properly quoted, etc etc. Plus it's a
> cross-compile anyway, so the shell in question should be the same as
> on all the other architectures.
>
> Presumably the nds32 assembly contains something odd and unexpected,
> but with the quoting, I can't see how even that could matter.
>
> Yeah, the test itself could probably be simplified to testing both
> conditions at the same time:
>
> [ "$a $b" = ".size .LPBX0," ]
>
> but that's a separate issue.
>
> Funky. What am I missing? Presumably something really stupid.
>
> Linus
Hi Linus,
The issue is from a=!, and [ "$a $b" = ".size .LPBX0," ] can avoid the
error.
+ [ ! = .size -a ABI = .LPBX0, ]
./kernel/gcov/geninfosize.sh: 13: [: =: unexpected operator
Best Regards,
Rong Chen
next prev parent reply other threads:[~2021-03-12 3:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 13:03 [PATCH] gcov: fail build on gcov_info size mismatch Peter Oberparleiter
2021-03-11 18:38 ` Linus Torvalds
2021-03-12 17:46 ` Peter Oberparleiter
2021-03-11 19:33 ` kernel test robot
2021-03-11 20:02 ` Linus Torvalds
2021-03-12 3:49 ` Rong Chen [this message]
2021-03-12 17:52 ` [kbuild-all] " Linus Torvalds
2021-03-15 2:31 ` Rong Chen
2021-03-15 19:12 ` Linus Torvalds
2021-03-15 20:32 ` Jamie Heilman
2021-03-15 20:57 ` Linus Torvalds
2021-03-15 23:09 ` Herbert Xu
2021-03-15 23:22 ` Linus Torvalds
2021-03-16 9:51 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db88186a-d6af-33c9-f1fb-10b673b8fdd6@intel.com \
--to=rong.a.chen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oberpar@linux.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox