public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Jin, Yao" <yao.jin@linux.intel.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Andi Kleen <ak@linux.intel.com>
Cc: jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com,
	alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org,
	kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v2] perf stat: Align CSV output for summary mode
Date: Fri, 19 Mar 2021 12:57:16 +0800	[thread overview]
Message-ID: <db9fea9b-b84b-595f-d93b-edf15cf37de0@linux.intel.com> (raw)
In-Reply-To: <YFNSjP4LKnixkQWq@kernel.org>

Hi Arnaldo,

On 3/18/2021 9:15 PM, Arnaldo Carvalho de Melo wrote:
> Em Wed, Mar 17, 2021 at 02:51:42PM -0700, Andi Kleen escreveu:
>>> If you care about not breaking existing scripts, then the output they
>>> get with what they use as command line options must continue to produce
>>> the same output.
>>
>> It's not clear there are any useful ones (except for tools that handle
>> both). It's really hard to parse the previous mess. It's simply not
>> valid CSV.
>>
>> That's why I'm arguing that keeping compatibility is not useful here.
>>
>> We would be stuck with the broken mess as default forever.
> 
> Fair enough, lets fix the default then. Jin, can you please consider
> adding a 'perf test' shell entry to parse the CSV mode with/without that
> summary? This way we'll notice when the new normal gets broken.
> 
> - Arnaldo
> 

Thanks Arnaldo! I will post v3 with the perf test script.

Thanks
Jin Yao


      reply	other threads:[~2021-03-19  4:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-17  7:02 [PATCH v2] perf stat: Align CSV output for summary mode Jin Yao
2021-03-17 13:28 ` Arnaldo Carvalho de Melo
2021-03-17 21:51   ` Andi Kleen
2021-03-18 13:15     ` Arnaldo Carvalho de Melo
2021-03-19  4:57       ` Jin, Yao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db9fea9b-b84b-595f-d93b-edf15cf37de0@linux.intel.com \
    --to=yao.jin@linux.intel.com \
    --cc=Linux-kernel@vger.kernel.org \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@intel.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=yao.jin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox