From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from DM1PR04CU001.outbound.protection.outlook.com (mail-centralusazon11010034.outbound.protection.outlook.com [52.101.61.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 992873002D8 for ; Sun, 15 Mar 2026 16:34:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.61.34 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773592487; cv=fail; b=e3JnqNSbB+Kkc+mxar10eHLnX2Bo/j4yMfdwmGvakBCME0pvalYM/4FPx9bp/ki6pVgECxCpzFBBtuaolsFHhsXfDiSPHb9jjqf6YRglIBX2TmPMkQiMuFVXbuMps+OH4ROMlLKwqf0Tqny3w1k0myeufsHs5nPMUWhjLF73Dko= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773592487; c=relaxed/simple; bh=z4L5M9oszbtl1qR3f/t5m7kXNAzjrI+JscY0RU1qW7M=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=InmjBaMTkAe4Bc+TBBJYqWyT/uF6Gj/P9KWKvsnBv9qco6FURzwvCkurG+s5cu1nxbaD/ENBwMsm/wEgBIV/6VzpAvOY78x6g5S/83mZrR0tHfIsY9eBxALoOYuExCAkptV5SF1VTebhr+xenwj8aAmBkFBx76rcJz2+0DCleTA= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=kNXeJg0o; arc=fail smtp.client-ip=52.101.61.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="kNXeJg0o" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=j4y5/uTzvDHCgQtc/4aJyWk3Q1zLCMJERRR0hdyLO7pWTLgd7rnsyqr+NpllLDss1WYIizbCfdJndULPw/Y8OqX1Mk+X10Ikq2ehOISh0OOu78n8XJ7mU9jx2mN+ZvPpY9ojPORy0SZFJgkO3PwGfo2nFunx+EsQ/XPfMheBtAiubBIiceKUnAXDsyHdqhffbN3VvwLoQQlpKbDNzhmRc6QNYPFhc9Si7A6/4Z6UeQ14MjrLb9jmRNedpUtVqxN9z9A6RRCfUTpwo2sn05QLLSkJ3JzWc9jH00pONpuG2huEEOqg80Tm/lyd5DqE+20jHQtvthPDKYBDDCDsDEyEBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hOtZ/4VnY3ndklOvYHFCyPVspW2gCTeXe+I+qMvj0IM=; b=kbRV6uxt3rSzSw+dq9iHc67r0yy/s1c8tvg5HulU/XVM4DvniIjoGPy9Fvl++0N3GV8FBLdA4J6eKNHqsnipjQLfDdghApHf5ehT3LjCgYOeLfqX1BFAZ0wakbmQX1NfBxPA+KTB+K1RGAo+G0uJ6hIVWOMbzRTXbt9IHxn+tdYn01LEIdN6tnxMUoGT+iSPVFUR2ZTbjkj3hEm4QtRM6R1d/n7zD59zHnQT3mwAX/kEmV5fyKMqb6z2koBOuWMAETnGFTiRmABWhhlEZXKRs8KkQA6uN4f4X+H2A8lymJiPT3gzdx4ymU58G+t7qt1eYyJGD4GJLfbJy63bb1T/rA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=google.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hOtZ/4VnY3ndklOvYHFCyPVspW2gCTeXe+I+qMvj0IM=; b=kNXeJg0onv4xk5H9wlYs7yI1l8CuqcGWvtANkEr2cr/+HLbGoYKXhmqH1aFAUR1LnxWd2LqxPjcAHd8B2NOCVAayp9/lBWJSlmA/nsMWjS37PvNgjQh5TdhYTy1Wyo6WOc/QUkNo3opeXrzo9zC+yMZjbGKsxNdLFitDvN3oZD0= Received: from SJ0PR05CA0048.namprd05.prod.outlook.com (2603:10b6:a03:33f::23) by CY1PR12MB9675.namprd12.prod.outlook.com (2603:10b6:930:105::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9723.12; Sun, 15 Mar 2026 16:34:43 +0000 Received: from SJ5PEPF000001C9.namprd05.prod.outlook.com (2603:10b6:a03:33f:cafe::98) by SJ0PR05CA0048.outlook.office365.com (2603:10b6:a03:33f::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9700.19 via Frontend Transport; Sun, 15 Mar 2026 16:34:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by SJ5PEPF000001C9.mail.protection.outlook.com (10.167.242.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9700.17 via Frontend Transport; Sun, 15 Mar 2026 16:34:43 +0000 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Sun, 15 Mar 2026 11:34:42 -0500 Received: from [172.31.184.125] (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Sun, 15 Mar 2026 11:34:34 -0500 Message-ID: Date: Sun, 15 Mar 2026 22:04:33 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v25 8/9] sched: Move attach_one_task and attach_task helpers to sched.h To: John Stultz , LKML CC: Joel Fernandes , Qais Yousef , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Valentin Schneider , Steven Rostedt , Ben Segall , Zimuzo Ezeozue , Mel Gorman , Will Deacon , Waiman Long , Boqun Feng , "Paul E. McKenney" , Metin Kaya , Xuewen Yan , Thomas Gleixner , Daniel Lezcano , Suleiman Souhlal , kuyo chang , hupu , References: <20260313023022.2902479-1-jstultz@google.com> <20260313023022.2902479-9-jstultz@google.com> Content-Language: en-US From: K Prateek Nayak In-Reply-To: <20260313023022.2902479-9-jstultz@google.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001C9:EE_|CY1PR12MB9675:EE_ X-MS-Office365-Filtering-Correlation-Id: 9fbcca41-6674-4b3c-53e3-08de82b0c359 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|7416014|376014|1800799024|82310400026|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: 7Yu0lgSXvV3fpYvCcFTVciUu8bF0j3PyczfEX63yZAgKA1CjJ0rzaYc75wml4zZAZBwGqAnEOAsQAEyUklMDOwSFvGwuD7yfdmYGzmTGmDR9FwnRuU5dkInaV3mxSymNUukn/jiMR15n7MIJmQxqQcMnbqk2GCEz0RqIsYAIFLQOtbHnEcmN02SwahHLf2aj3L7IHVCopMqmyFEGzeecz5d6KPfjr2gjrBK3vOPIzIpKsu7biG8njscvtOREpYX4EcIn31sfgm+QAJxOjjJdFUIL7HhGAstp5Z0XVmablK8E8BxXhlxqcg2sDl2ppuj5obovEcSICQJ54h4fVpNqTk/t3qONPrN/RrvXVCqMAumNxd/r4HJjZ7qedwuPa2BSAbuEnJXY/dXm3GGiOjFSJs44159L2bT25U54A4h9t92rUkaB8tppY0eSXegpSdKfVulkPmzJjlA9hVaz1ZKgR+i7Znes2mw2SGLoj8ROLBdfC+FT6VJwKIxU0PavXz4klMHixRjNJwC8eDlu3bmigOXzpPcEA0EUQM42e31EPRjiIEGfNphHZFVdm13x5H7IMdKQspcSiMbAt+Si6614z35iMaUkNDYb+4s6dye8ZUIlBoYYidL8ijAE/VJDvBgBBwGHESbX7UPSZJAE0fSibaVeDXW/6MtH5j3pnBtXXHNh3vvCywBxTZZHeD1spEI1Do4j37dvkpjMvEnzqxF6eNlcLO8EeDFjW5fEvaA77dP8rI8xZCjber+366zfcogqeSE232amRm4DSZqyCo37Ng== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(7416014)(376014)(1800799024)(82310400026)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: vQ2LN5qQnsCGdHdXXMffhsXH3VhNHfLOTNc+cejoOSg464yVhnaaVXnCg6rEr54CWdH7rM4/wj5NYPbr/Bmz+THHFA42JZ2tjQNiXLvVQFxDL96ZKq9jrCsklokp0KG2eOxU9W0G4yHHvlrspem4N4XzD5C5RFhQNNKakvJJW9PKab//Dui6B3xCEa4kCyhdCQcYzxEPBW/XbmRF9TLCIypWPvxgrFq4ZpYro/y5LMhik53EfdiAaSl1mehz4QFgkl1NEoNmzhSmD8kyQY5RjY27N+YQK6FQ7lBPZxeTDEs6tRZKxGwaP1mxYKyZFm9nMSONg3lbauHHWWhccTRkO+vyXNuksRMp55jp/F2SkyxOXImkdkECb28I456HVGbTOIWR1T8znpvL+3Mu0Av4xwPLShrk/f4FLJDAv2x5jWaRETh4mQGS679bO+zVyhnS X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2026 16:34:43.5373 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9fbcca41-6674-4b3c-53e3-08de82b0c359 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001C9.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB9675 Hello John, On 3/13/2026 8:00 AM, John Stultz wrote: > +/* > + * attach_one_task() -- attaches the task returned from detach_one_task() to > + * its new rq. > + */ > +static inline void attach_one_task(struct rq *rq, struct task_struct *p) > +{ > + struct rq_flags rf; > + > + rq_lock(rq, &rf); nit. We can now use guard(rq_lock)(rq) and save on needing to declare a "rf". Apart from that, feel free to include: Reviewed-by: K Prateek Nayak > + update_rq_clock(rq); > + attach_task(rq, p); > + rq_unlock(rq, &rf); > +} > + -- Thanks and Regards, Prateek