From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Li Qiong <liqiong@nfschina.com>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: <linux-ide@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<hukun@nfschina.com>, <qixu@nfschina.com>, <yuzhe@nfschina.com>,
<renyu@nfschina.com>
Subject: Re: [PATCH] ata: handle failure of devm_ioremap()
Date: Sun, 12 Jun 2022 12:06:52 +0300 [thread overview]
Message-ID: <dbe12afa-60c7-899b-a19a-db5a3f49a452@omp.ru> (raw)
In-Reply-To: <20220612073222.18974-1-liqiong@nfschina.com>
Hello!
The subject should include the driver's name, like below:
ata: pata_pxa: handle failure of devm_ioremap()
On 6/12/22 10:32 AM, Li Qiong wrote:
> As the possible failure of the devm_ioremap(), the return value
> could be NULL. Therefore it should be better to check it and
> print error message, return '-ENOMEM' error code.
>
> Signed-off-by: Li Qiong <liqiong@nfschina.com>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
[...]
MBR, Sergey
next prev parent reply other threads:[~2022-06-12 9:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-12 7:32 [PATCH] ata: handle failure of devm_ioremap() Li Qiong
2022-06-12 9:06 ` Sergey Shtylyov [this message]
2022-06-12 12:34 ` liqiong
2022-06-12 12:57 ` [PATCH v2] ata: pata_pxa: " Li Qiong
2022-06-12 18:37 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbe12afa-60c7-899b-a19a-db5a3f49a452@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=damien.lemoal@opensource.wdc.com \
--cc=hukun@nfschina.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liqiong@nfschina.com \
--cc=qixu@nfschina.com \
--cc=renyu@nfschina.com \
--cc=yuzhe@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox