From: Maulik Shah <mkshah@codeaurora.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: swboyd@chromium.org, evgreen@chromium.org,
bjorn.andersson@linaro.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, agross@kernel.org,
dianders@chromium.org, rnayak@codeaurora.org,
ilina@codeaurora.org, lsrao@codeaurora.org
Subject: Re: [PATCH v5 1/7] drivers: qcom: rpmh: fix macro to accept NULL argument
Date: Fri, 21 Feb 2020 15:02:50 +0530 [thread overview]
Message-ID: <dbec4ecb-403a-3bfe-0404-9d212cdfeaab@codeaurora.org> (raw)
In-Reply-To: <20200220193105.GB24720@google.com>
On 2/21/2020 1:01 AM, Matthias Kaehlcke wrote:
> Hi Maulik,
>
> this patch and '[v5,2/7] drivers: qcom: rpmh: remove rpmh_flush
> export' already landed in the QCOM tree (in the branch 'drivers-for-5.7'):
>
> d5e205079c34a drivers: qcom: rpmh: remove rpmh_flush export
> aff9cc0847a58 drivers: qcom: rpmh: fix macro to accept NULL argument
>
> Please rebase your working tree and stop sending these.
>
> Thanks
>
> Matthias
Hi Matthias
Rebased and updated in v6.
Thanks,
Maulik
>
> On Wed, Feb 19, 2020 at 04:10:04PM +0530, Maulik Shah wrote:
>> Device argument matches with dev variable declared in RPMH message.
>> Compiler reports error when the argument is NULL since the argument
>> matches the name of the property. Rename dev argument to device to
>> fix this.
>>
>> Signed-off-by: Maulik Shah <mkshah@codeaurora.org>
>> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
>> ---
>> drivers/soc/qcom/rpmh.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/soc/qcom/rpmh.c b/drivers/soc/qcom/rpmh.c
>> index 035091f..3a4579d 100644
>> --- a/drivers/soc/qcom/rpmh.c
>> +++ b/drivers/soc/qcom/rpmh.c
>> @@ -23,7 +23,7 @@
>>
>> #define RPMH_TIMEOUT_MS msecs_to_jiffies(10000)
>>
>> -#define DEFINE_RPMH_MSG_ONSTACK(dev, s, q, name) \
>> +#define DEFINE_RPMH_MSG_ONSTACK(device, s, q, name) \
>> struct rpmh_request name = { \
>> .msg = { \
>> .state = s, \
>> @@ -33,7 +33,7 @@
>> }, \
>> .cmd = { { 0 } }, \
>> .completion = q, \
>> - .dev = dev, \
>> + .dev = device, \
>> .needs_free = false, \
>> }
>>
>> --
>> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
>> of Code Aurora Forum, hosted by The Linux Foundation
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2020-02-21 9:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 10:40 [PATCH v5 0/7] Add RSC power domain support Maulik Shah
2020-02-19 10:40 ` [PATCH v5 1/7] drivers: qcom: rpmh: fix macro to accept NULL argument Maulik Shah
2020-02-20 19:31 ` Matthias Kaehlcke
2020-02-21 9:32 ` Maulik Shah [this message]
2020-02-19 10:40 ` [PATCH v5 2/7] drivers: qcom: rpmh: remove rpmh_flush export Maulik Shah
2020-02-19 10:40 ` [PATCH v5 3/7] dt-bindings: soc: qcom: Add RSC power domain specifier Maulik Shah
2020-02-19 10:40 ` [PATCH v5 4/7] drivers: qcom: rpmh-rsc: Add RSC power domain support Maulik Shah
2020-02-19 10:40 ` [PATCH v5 5/7] arm64: dts: qcom: sc7180: Add cpuidle low power states Maulik Shah
2020-02-19 10:40 ` [PATCH v5 6/7] soc: qcom: rpmh: Update dirty flag only when data changes Maulik Shah
2020-02-19 10:40 ` [PATCH v5 7/7] soc: qcom: rpmh: Invoke rpmh_flush for dirty caches Maulik Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbec4ecb-403a-3bfe-0404-9d212cdfeaab@codeaurora.org \
--to=mkshah@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=ilina@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lsrao@codeaurora.org \
--cc=mka@chromium.org \
--cc=rnayak@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).