public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Uwe Kleine-König" <ukleinek@kernel.org>,
	"Abel Vesa" <abel.vesa@linaro.org>
Cc: Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,
	Anjelique Melendez <anjelique.melendez@oss.qualcomm.com>,
	Kamal Wadhwa <quic_kamalw@quicinc.com>,
	Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Johan Hovold <johan@kernel.org>,
	Sebastian Reichel <sre@kernel.org>, Pavel Machek <pavel@ucw.cz>,
	linux-leds@vger.kernel.org, linux-pwm@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] leds: rgb: leds-qcom-lpg: Compute PWM value based on period instead
Date: Tue, 4 Mar 2025 10:53:53 +0100	[thread overview]
Message-ID: <dbfb17df-90e2-4a7c-9921-9dff5e9382f4@kernel.org> (raw)
In-Reply-To: <ylnkjxnukss7askv7ip5htrb4tyjzhpw7jim2se6rloleq5h6w@ngk7lbk26hxj>

On 04/03/2025 07:24, Uwe Kleine-König wrote:
> instead which gives you a more exact result. The challenge here however
> is that the multiplication might overflow. If you know that the result
> fits into a u64, mul_u64_u64_div_u64() is the function that gets this
> right for you.
> 
>>  	chan->pwm_value = min(val, max);
>>  }
>> [...]
>> ---
>> base-commit: 0067a4b21c9ab441bbe6bf3635b3ddd21f6ca7c3
> 
> My git repo doesn't know that commit. Given that you said your patch
> bases on that other series, this isn't surprising. Please use a publicly
> available commit as base parameter, otherwise you (and I) don't benefit
> from the armada of build bots because they just silently fail to test in

As you can easily see in the signature, this patchset was generated by
b4 and such tag was added automatically. No point in stripping it even
if it is not useful (life, happens).

In the same time the dependency, so the base of this patchset, is
explained in the changelog, exactly in the place where it should be.
Exactly how we all want.

I don't understand what you are poking now. This is exactly the process
how to send an RFC, which you can find in "[PATCH RFC]" subject, based
on some other work in flight/progress.

This is basically an exemplary patch how to do this. You cannot do it
better.

Best regards,
Krzysztof


  parent reply	other threads:[~2025-03-04  9:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-03 16:14 [PATCH RFC] leds: rgb: leds-qcom-lpg: Compute PWM value based on period instead Abel Vesa
2025-03-03 22:48 ` Sebastian Reichel
2025-03-04  6:24 ` Uwe Kleine-König
2025-03-04  9:21   ` Abel Vesa
2025-03-04  9:52     ` Abel Vesa
2025-03-04 15:38     ` Uwe Kleine-König
2025-03-05 14:32       ` Abel Vesa
2025-03-05 14:42         ` neil.armstrong
2025-03-06 22:34           ` Uwe Kleine-König
2025-03-04  9:53   ` Krzysztof Kozlowski [this message]
2025-03-04 16:03     ` Uwe Kleine-König
2025-03-04 16:30       ` Krzysztof Kozlowski
2025-03-06 23:33         ` Uwe Kleine-König
2025-03-07  7:07           ` Krzysztof Kozlowski
2025-03-08 19:15             ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dbfb17df-90e2-4a7c-9921-9dff5e9382f4@kernel.org \
    --to=krzk@kernel.org \
    --cc=abel.vesa@linaro.org \
    --cc=andersson@kernel.org \
    --cc=anjelique.melendez@oss.qualcomm.com \
    --cc=jishnu.prakash@oss.qualcomm.com \
    --cc=johan@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=pavel@kernel.org \
    --cc=pavel@ucw.cz \
    --cc=quic_kamalw@quicinc.com \
    --cc=sre@kernel.org \
    --cc=ukleinek@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox