From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751357AbdKUTa3 (ORCPT ); Tue, 21 Nov 2017 14:30:29 -0500 Received: from mout.web.de ([212.227.17.11]:58596 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751145AbdKUTa1 (ORCPT ); Tue, 21 Nov 2017 14:30:27 -0500 Subject: Re: selftests: Completion of error handling To: shuah@kernel.org, linux-kselftest@vger.kernel.org Cc: LKML , kernel-janitors@vger.kernel.org, Shuah Khan References: <988e4be0-4784-d9b7-879b-06ed405ae293@users.sourceforge.net> <26965dfd-74e8-cf6f-7f55-56310834189d@kernel.org> From: SF Markus Elfring Message-ID: Date: Tue, 21 Nov 2017 20:30:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <26965dfd-74e8-cf6f-7f55-56310834189d@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:wXAUf1BQFIDH3P/dLhEKswS5jwKa/eL5LQtmY5YlwIUwr4TJXiA VfyqExl4Gp82FLvK3IfJQesUIgzr+/cOYEX8weCVCAX2buMs2HRBJM+t2Pe0DVMB9Jk4eIk yaZcvDdHdgIW3mgZ/eDgvlWsWGN6u6Yx/utIk5oiepCf3pKe2WtHAVf7rij0NOlppyhlnSO i2kodOtEyTsgNwpPYEDTg== X-UI-Out-Filterresults: notjunk:1;V01:K0:Muma4K15uro=:c2TPURDauZYc+NXBO3a/Fz 1q3A0cpitQWGYnIa4qXGNRhasXy+mA2794n6Km2j5yismO5tU+Fsf87so7ePs67N1YhmuXEm/ OqlFjLAg/8DcPU8+XQ0UopgMg77HnInsGuWb4J/4c2TVe4oDTPA7n1Z+2DQStztpzYBEV5SET Pk1P5D8g0jMnNqEXvWkoViIiRTNTdKpDJVggAs2ljEdTgQGaXccV4uxz0b1jORf6cgTOWsZRn /GrBp2LrXvsZdd6riHyuG14NdjTWDKoSe3JsTzsg6pHJeMNzvM7QM+gAZPYJr9bL57EeAdLZp Du6u7qJpZ1hBeVXgiz2v8Z+xr5MZcd3Kr+KOzmns/ZSBaTi/WFXMSXS2JTg9pBizjmaB8z3kj 7V8DjN8r3uDr4B3Hx47wvQucdLXB/3nwQMZ1PtDzKSeaBmcUpm3032ntilMm3QC69aD+KvZtF 7q0NuNlcbxHqZ02+MJ5T50LrBOERcEBC9Q8nAViLVtrmJfw1ZFm0XNSNbJGpCHudOoSWbw6y3 sF5EuercD4cP2/TlTblcxlX59MqDT4sLZxfoq/buMc44oUAh6jmxSLwYq1DpN84jyGZwZRDRH IDIJmdxPtfmMGCVBgH/2bhn9tb21VEaSCKGyt61TQlB2+5aHXWja0met2bDm230PJM6Y93Azs OrbHDGin65oovJsM3y4H66Agb6gruFUXJzMOBLI+jFevk6J6D9IX1J3/EIB4gXD4GIz+v/Axf M5i/NbWGcKVFoG9gLvVAgSv11TEScGpVC6r01LcMwRAd5zw7E7cTe0TR+G9RQecCxeSTcksot PSmCKCLE/sZIyoh94AsTbVaIQFmZZty37ksHRj/wJXlYgLtUN4= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> Static source code analysis points out that the checking of return values from >> some function calls is incomplete also in this software area. >> How would you like to fix remaining open issues there? >> > > Without understanding the details on which failures, Are you using any dedicated tools for this purpose already? > it would be hard for me comment on how to handle them. I inspected also another specific source file for example. https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/tools/testing/selftests/timers/posix_timers.c?id=aa1fbe633d3034f9f838ff13387af04771e68e31#n81 https://elixir.free-electrons.com/linux/v4.14-rc8/source/tools/testing/selftests/timers/posix_timers.c#L78 This one contains some places (like in the function “check_itimer”) where the error detection and corresponding exception handling is incomplete so far. Other source files can contain similar update candidates. There are different design options available to improve the software situation here. Which development directions do you prefer? Regards, Markus