From: Oliver Neukum <oneukum@suse.com>
To: "Miao, Jun" <jun.miao@intel.com>,
Subbaraya Sundeep <sbhatta@marvell.com>
Cc: "oneukum@suse.com" <oneukum@suse.com>,
"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: usb: Convert tasklet API to new bottom half workqueue mechanism
Date: Tue, 10 Jun 2025 11:53:15 +0200 [thread overview]
Message-ID: <dc4e3500-b5fb-4aa1-b74c-c37708146c3c@suse.com> (raw)
In-Reply-To: <PH7PR11MB84552A6D3723B68D5B83E4BE9A6BA@PH7PR11MB8455.namprd11.prod.outlook.com>
On 09.06.25 11:53, Miao, Jun wrote:
>> You can change it to GFP_KERNEL since this is not atomic context now.
>>
>
> Thanks, the usbnet_bh() function only be called by usbnet_bh_workqueue which is sleepable.
Yes, but it can be waited on in usbnet_stop(), which in turn can
be called for a device reset. Hence this must be GFP_NOIO, not
GFP_KERNEL.
Regards
Oliver
next prev parent reply other threads:[~2025-06-10 9:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-09 7:26 [PATCH] net: usb: Convert tasklet API to new bottom half workqueue mechanism Jun Miao
2025-06-09 9:05 ` Subbaraya Sundeep
2025-06-09 9:53 ` Miao, Jun
2025-06-10 9:53 ` Oliver Neukum [this message]
2025-06-10 10:14 ` Miao, Jun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc4e3500-b5fb-4aa1-b74c-c37708146c3c@suse.com \
--to=oneukum@suse.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jun.miao@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sbhatta@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox