linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rémi Denis-Courmont" <remi@remlab.net>
To: David Miller <davem@davemloft.net>
Cc: <levinsasha928@gmail.com>, <davej@redhat.com>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] phonet: Check input from user before allocating
Date: Tue, 03 Apr 2012 08:36:20 +0200	[thread overview]
Message-ID: <dc6e3bc8b96d91bd7ce44639b60cfec2@chewa.net> (raw)
In-Reply-To: <20120402.174006.70116829696492189.davem@davemloft.net>

On Mon, 02 Apr 2012 17:40:06 -0400 (EDT), David Miller

<davem@davemloft.net> wrote:

> UDP generates a fragment list of MTU sized SKBs.

> 

> Phonet could avoid the large allocations by building page based

> SKBs.



Oh right. And Phonet devices don't support scatter/gather, so that I guess

that would merely delay the problem.



Also sendmsg() code would need to be reectored to look up the output

device and then the MTU before allocating the socket buffer. This will only

work if the default MTU is reduced first :/



-- 

Rémi Denis-Courmont

Sent from my collocated server

  parent reply	other threads:[~2012-04-03  6:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-02 20:31 [PATCH] phonet: Check input from user before allocating Sasha Levin
2012-04-02 19:00 ` Rémi Denis-Courmont
2012-04-02 21:38   ` David Miller
2012-04-02 19:01 ` Rémi Denis-Courmont
2012-04-02 21:40   ` David Miller
2012-04-03  1:53     ` Eric Dumazet
2012-04-03  1:59       ` David Miller
2012-04-03  2:15         ` Eric Dumazet
2012-04-03  2:23           ` David Miller
2012-04-03  2:29             ` Eric Dumazet
2012-04-03  2:29             ` Rick Jones
2012-04-03  2:34               ` Eric Dumazet
2012-04-03  2:39                 ` Rick Jones
2012-04-03  3:14                   ` Eric Dumazet
2012-04-03 18:18                     ` Rick Jones
2012-04-03  6:36     ` Rémi Denis-Courmont [this message]
2012-04-03  6:38       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc6e3bc8b96d91bd7ce44639b60cfec2@chewa.net \
    --to=remi@remlab.net \
    --cc=davej@redhat.com \
    --cc=davem@davemloft.net \
    --cc=levinsasha928@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).