* [PATCH] ipmi_si: Delete an error message for a failed memory allocation in try_smi_init()
@ 2017-10-15 20:36 SF Markus Elfring
2017-10-17 20:47 ` Corey Minyard
0 siblings, 1 reply; 2+ messages in thread
From: SF Markus Elfring @ 2017-10-15 20:36 UTC (permalink / raw)
To: openipmi-developer, Corey Minyard; +Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 15 Oct 2017 22:30:11 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/char/ipmi/ipmi_si_intf.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index 55e0c42bee4d..2aed46a6c49c 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -2095,7 +2095,6 @@ static int try_smi_init(struct smi_info *new_smi)
/* Allocate the state machine's data and initialize it. */
new_smi->si_sm = kmalloc(new_smi->handlers->size(), GFP_KERNEL);
if (!new_smi->si_sm) {
- pr_err(PFX "Could not allocate state machine memory\n");
rv = -ENOMEM;
goto out_err;
}
--
2.14.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ipmi_si: Delete an error message for a failed memory allocation in try_smi_init()
2017-10-15 20:36 [PATCH] ipmi_si: Delete an error message for a failed memory allocation in try_smi_init() SF Markus Elfring
@ 2017-10-17 20:47 ` Corey Minyard
0 siblings, 0 replies; 2+ messages in thread
From: Corey Minyard @ 2017-10-17 20:47 UTC (permalink / raw)
To: SF Markus Elfring, openipmi-developer; +Cc: LKML, kernel-janitors
On 10/15/2017 03:36 PM, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 15 Oct 2017 22:30:11 +0200
>
> Omit an extra message for a memory allocation failure in this function.
Thanks, queued for the next release.
-corey
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/char/ipmi/ipmi_si_intf.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
> index 55e0c42bee4d..2aed46a6c49c 100644
> --- a/drivers/char/ipmi/ipmi_si_intf.c
> +++ b/drivers/char/ipmi/ipmi_si_intf.c
> @@ -2095,7 +2095,6 @@ static int try_smi_init(struct smi_info *new_smi)
> /* Allocate the state machine's data and initialize it. */
> new_smi->si_sm = kmalloc(new_smi->handlers->size(), GFP_KERNEL);
> if (!new_smi->si_sm) {
> - pr_err(PFX "Could not allocate state machine memory\n");
> rv = -ENOMEM;
> goto out_err;
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-17 20:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-15 20:36 [PATCH] ipmi_si: Delete an error message for a failed memory allocation in try_smi_init() SF Markus Elfring
2017-10-17 20:47 ` Corey Minyard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).