public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Florian Fainelli <florian.fainelli@broadcom.com>
To: "Jonas Gorski" <jonas.gorski@gmail.com>,
	"Florian Fainelli" <florian.fainelli@broadcom.com>,
	"Andrew Lunn" <andrew@lunn.ch>,
	"Vladimir Oltean" <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Vivien Didelot" <vivien.didelot@gmail.com>,
	"Álvaro Fernández Rojas" <noltari@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 3/3] net: dsa: b53: allow RGMII for bcm63xx RGMII ports
Date: Mon, 19 May 2025 14:40:50 -0700	[thread overview]
Message-ID: <dc9c76cf-64bf-434b-9f7b-af050822bfe5@broadcom.com> (raw)
In-Reply-To: <20250519174550.1486064-4-jonas.gorski@gmail.com>

On 5/19/25 10:45, Jonas Gorski wrote:
> Add RGMII to supported interfaces for BCM63xx RGMII ports so they can be
> actually used in RGMII mode.
> 
> Without this, phylink will fail to configure them:
> 
> [    3.580000] b53-switch 10700000.switch GbE3 (uninitialized): validation of rgmii with support 0000000,00000000,00000000,000062ff and advertisement 0000000,00000000,00000000,000062ff failed: -EINVAL
> [    3.600000] b53-switch 10700000.switch GbE3 (uninitialized): failed to connect to PHY: -EINVAL
> [    3.610000] b53-switch 10700000.switch GbE3 (uninitialized): error -22 setting up PHY for tree 0, switch 0, port 4
> 
> Fixes: ce3bf94871f7 ("net: dsa: b53: add support for BCM63xx RGMIIs")
> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>

Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
-- 
Florian


      reply	other threads:[~2025-05-19 21:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-19 17:45 [PATCH net 0/3] net: dsa: fix RGMII ports on BCM63xx Jonas Gorski
2025-05-19 17:45 ` [PATCH net 1/3] net: dsa: b53: do not enable EEE on bcm63xx Jonas Gorski
2025-05-19 21:40   ` Florian Fainelli
2025-05-19 17:45 ` [PATCH net 2/3] net: dsa: b53: fix configuring RGMII delay " Jonas Gorski
2025-05-19 19:14   ` Andrew Lunn
2025-05-19 19:44     ` Jonas Gorski
2025-05-19 20:34       ` Andrew Lunn
2025-05-19 21:43         ` Jonas Gorski
2025-05-20  0:15           ` Andrew Lunn
2025-05-23  9:08             ` Jonas Gorski
2025-05-23 13:24               ` Andrew Lunn
2025-05-19 21:38       ` Florian Fainelli
2025-05-19 17:45 ` [PATCH net 3/3] net: dsa: b53: allow RGMII for bcm63xx RGMII ports Jonas Gorski
2025-05-19 21:40   ` Florian Fainelli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc9c76cf-64bf-434b-9f7b-af050822bfe5@broadcom.com \
    --to=florian.fainelli@broadcom.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jonas.gorski@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=noltari@gmail.com \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox