Re: [PATCH net-next 1/5] ipv6: rename and move ip6_dst_lookup_tunnel()

David Ahern
2023-10-20T15:52:35Z

On 10/20/23 5:55 AM, Beniamino Galvani wrote:
> At the moment ip6_dst_lookup_tunnel() is used only by bareudp.
> Ideally, other UDP tunnel implementations should use it, but to do so
> the function needs to accept new parameters that are specific for UDP
> tunnels, such as the ports.
>
> Prepare for these changes by renaming the function to
> udp_tunnel6_dst_lookup() and move it to file
> net/ipv6/ip6_udp_tunnel.c.
>
> This is similar to what already done for IPv4 in commit bf3fcbf7e7a0
> ("ipv4: rename and move ip_route_output_tunnel()").
>
> Suggested-by: Guillaume Nault <gnault@redhat.com>
> Signed-off-by: Beniamino Galvani <b.galvani@gmail.com>
> ---
> drivers/net/bareudp.c | 10 +++---
> include/net/ipv6.h | 6 ----
> include/net/udp_tunnel.h | 7 ++++
> net/ipv6/ip6_output.c | 68 --------------------------------------
> net/ipv6/ip6_udp_tunnel.c | 69 +++++++++++++++++++++++++++++++++++++++
> 5 files changed, 81 insertions(+), 79 deletions(-)
>

Reviewed-by: David Ahern <dsahern@kernel.org>