Re: [PATCH v2 3/3] drm: bridge: Add waveshare DSI2DPI unit driver

[Liu Ying <victor.liu@nxp.com>]

On 08/05/2025, Krzysztof Kozlowski wrote:
> On 05/08/2025 08:11, Liu Ying wrote:
>> On 08/05/2025, Krzysztof Kozlowski wrote:
>>> On 05/08/2025 04:22, Liu Ying wrote:
>>>> Hi Joseph,
>>>>
>>>> On 08/04/2025, Joseph Guo wrote:
>>>>> Waveshare touchscreen consists of a DPI panel and a driver board.
>>>>> The waveshare driver board consists of ICN6211 and a MCU to
>>>>> convert DSI to DPI and control the backlight.
>>>>> This driver treats the MCU and ICN6211 board as a whole unit.
>>>>> It can support all resolution waveshare DSI2DPI based panel,
>>>>> the timing table should come from 'panel-dpi' panel in the device tree.
>>>>>
>>>>> Signed-off-by: Joseph Guo <qijian.guo@nxp.com>
>>>>
>>>> For next version, you may add:
>>>> Suggested-by: Liu Ying <victor.liu@nxp.com>
>>>
>>> Why?
>>
>> As I replied in the cover letter, I provided general idea for this
>> patch series in NXP down stream kernel.  Same for the DT binding patches.
> 
> General idea to add support for new driver? So like every patch being a
> result of for example task from manager means "Suggested-by"? Since when
> new device support is treated as suggested-by?

Not for new driver, but for architecture level, like treating the MCU and
ICN6211 as a whole unit/DRM bridge and treating the DPI panel as a simple
panel from both DT's point of view and DRM driver's point of view.

> 
> I also do not understand how downstream kernel is relevant here.

That suggestion did happen when I reviewed this patch series for downstream
kernel.  Just shared the information.

> 
> Best regards,
> Krzysztof


-- 
Regards,
Liu Ying