From: Yonghong Song <yonghong.song@linux.dev>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux trace kernel <linux-trace-kernel@vger.kernel.org>,
bpf <bpf@vger.kernel.org>, Masami Hiramatsu <mhiramat@kernel.org>,
"Paul E. McKenney" <paulmck@kernel.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v5] tracing: Guard __DECLARE_TRACE() use of __DO_TRACE_CALL() with SRCU-fast
Date: Fri, 9 Jan 2026 11:19:55 -0800 [thread overview]
Message-ID: <dcc3a509-d8fd-4f46-8051-683d7277fde7@linux.dev> (raw)
In-Reply-To: <CAADnVQJMa+p_BcYxKUgve2=sqRBwSs3wLGAGhbA0r6hwFpJ+6Q@mail.gmail.com>
On 1/9/26 11:10 AM, Alexei Starovoitov wrote:
> On Fri, Jan 9, 2026 at 6:45 AM Mathieu Desnoyers
> <mathieu.desnoyers@efficios.com> wrote:
>> On 2026-01-08 22:05, Steven Rostedt wrote:
>>> From: "Paul E. McKenney" <paulmck@kernel.org>
>> [...]
>>
>> I disagree with many elements of the proposed approach.
>>
>> On one end we have BPF wanting to hook on arbitrary tracepoints without
>> adding significant latency to PREEMPT RT kernels.
>>
>> One the other hand, we have high-speed tracers which execute very short
>> critical sections to serialize trace data into ring buffers.
>>
>> All of those users register to the tracepoint API.
>>
>> We also have to consider that migrate disable is *not* cheap at all
>> compared to preempt disable.
> Looks like your complaint comes from lack of engagement in kernel
> development.
> migrate_disable _was_ not cheap.
> Try to benchmark it now.
> It's inlined. It's a fraction of extra overhead on top of preempt_disable.
>
The following are related patches to inline migrate_disable():
35561bab768977c9e05f1f1a9bc00134c85f3e28 arch: Add the macro COMPILE_OFFSETS to all the asm-offsets.c
88a90315a99a9120cd471bf681515cc77cd7cdb8 rcu: Replace preempt.h with sched.h in include/linux/rcupdate.h
378b7708194fff77c9020392067329931c3fcc04 sched: Make migrate_{en,dis}able() inline
prev parent reply other threads:[~2026-01-09 19:20 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-09 3:05 [PATCH v5] tracing: Guard __DECLARE_TRACE() use of __DO_TRACE_CALL() with SRCU-fast Steven Rostedt
2026-01-09 14:40 ` Mathieu Desnoyers
2026-01-09 17:21 ` Steven Rostedt
2026-01-09 18:58 ` Mathieu Desnoyers
2026-01-13 13:56 ` Sebastian Andrzej Siewior
2026-01-09 19:10 ` Alexei Starovoitov
2026-01-09 19:19 ` Steven Rostedt
2026-01-09 20:21 ` Mathieu Desnoyers
2026-01-09 21:02 ` Steven Rostedt
2026-01-12 7:23 ` Menglong Dong
2026-01-12 15:31 ` Peter Zijlstra
2026-01-12 15:36 ` Steven Rostedt
2026-01-12 15:44 ` Peter Zijlstra
2026-01-09 21:54 ` Alexei Starovoitov
2026-01-09 22:00 ` Steven Rostedt
2026-01-09 22:18 ` Alexei Starovoitov
2026-01-09 22:31 ` Mathieu Desnoyers
2026-01-09 22:33 ` Steven Rostedt
2026-01-09 22:39 ` Steven Rostedt
2026-01-10 0:35 ` Alexei Starovoitov
2026-01-10 16:14 ` Steven Rostedt
2026-01-11 20:04 ` Alexei Starovoitov
2026-01-11 22:09 ` Steven Rostedt
2026-01-11 23:38 ` Alexei Starovoitov
2026-01-12 13:53 ` Steven Rostedt
2026-01-12 17:19 ` Alexei Starovoitov
2026-01-13 14:23 ` Sebastian Andrzej Siewior
2026-01-13 23:44 ` Alexei Starovoitov
2026-01-09 19:19 ` Yonghong Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcc3a509-d8fd-4f46-8051-683d7277fde7@linux.dev \
--to=yonghong.song@linux.dev \
--cc=alexei.starovoitov@gmail.com \
--cc=bigeasy@linutronix.de \
--cc=bpf@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=paulmck@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox