From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C669212B3D for ; Thu, 29 May 2025 06:38:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748500716; cv=none; b=qAT/YvAuO3d7QZbxulZeKUN6w1meml/ut7OOW9Vi1do8sfdl5BLwQwExqpI/cBub8NIthfGvEd9lGyiEWw/0Vknb5NRZ42Uq09JIHzWfU1cgihMxh7RESK+2015xRLqwG+XsXGu/feRGoIroFLVWVBSH92dRKaB0Q6pVBizFdDA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748500716; c=relaxed/simple; bh=0aidQ5TH+mXzGykMadncfoYltrB58taVl1vxlpxmFuI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XqcrjZ7789exyaq4tUr0AxBZmYaa457cZYWsWjSyeVObB2TqaJhloeFMe7cz4hk6/KB3oyJAcZSDz/yBly2Luj1RFye+5mz1sxyrXEmvktYh0vB8v1s4n0B+q0Pn3ugtg8T7J5R/IydHuy3NncsSHYwdCuxgw+cPEXqUvlNitKU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=UddCykqn; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UddCykqn" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-3a4ef05f631so70092f8f.3 for ; Wed, 28 May 2025 23:38:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748500713; x=1749105513; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=EY1aP3IrlRwlb4h50GQEgfZI127sO1qf07y90xDx+ws=; b=UddCykqn07Mw1825AynhHhMIbNzKuPWEIK11ucGaMYcKsLs1KCy5ieOQRmmKwDZKdm darbpZIZJsnlZljmzZ4Qm5rwysVclid6AZeJDKhsu0y91biMIJ2lD87PoDDJsIaZvCqA SDPwqJBT2WulfsOJ0ZF7DdfZMlvmNK4Igaj+zEFqTbVVgeqgnzNuIUh8S8A78rMDI3Cx Mw4Big6wiVBUS0UndXdosfZQZtr27tBBHpkYacGzYHElAmvEyI1cTRnyFZWGIoRvAsUu v31mxv4tglZ5q/T0rbSRK+SQLnOvo3OdCr8ynip1rwAC+zh2O7weDJP/R+kqx+Yo9zpd AlNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748500713; x=1749105513; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EY1aP3IrlRwlb4h50GQEgfZI127sO1qf07y90xDx+ws=; b=AiFaLfAaQpzlLmYmriK36DiLTRYcAymePVOjb4uzjgdpcpaAMQ+OzTKKRdcgOqvrEq fHAxEpZmhtlTq3SoNVbvxb04IIpW+DKrUi/QQLtsEfhxaaU/fFhsG2LjM+gOnrSH//Yc 1apcQn8FUScFYGeoanKl+rLbzSZdyiRScCYY/WCPWgHagXz04RuMg+o/qrcRZgBTFro9 5T1zoVNeHfeZm8wDze6wsRSV9o9FL0oHLwxzxxG4BtDu/cRHA5V33Yhxf+wVZN40RLhv 0xK9WckoIStb6uAKe/c9uy9pLUKJ2buMMiqskdocdgX5wQEl+hob0yaCoE1GsxhJ0LGT rUKQ== X-Forwarded-Encrypted: i=1; AJvYcCU5hOX2e3KrpMhRJeE2EsVAbaaQ/BQyStXEksssVoCVaO//ln9bX5tq2OrLe8UNMFHTeTtfbXArGSFW/40=@vger.kernel.org X-Gm-Message-State: AOJu0Yw8ixw972b3G3s/h1BqvfjBy1reBaFT1dJizzTmbZH1jAPQt0EZ vqYgv7qVQrzcgWTj+XtIQ4+oZLbMVyDfFZwdpbtbAxP2+oFuNdNpK/7EArsXGqT1PZs= X-Gm-Gg: ASbGnctLJlEPGn8muZJnVPaXScLZFT3SlGfy4MQWKU7iMosMoFb8VkRUBWKnII80LIG DYg2ZkW1Tkp+y2KZtjxuy7G7OgDcdPmccCiNxCDTI4FId+LOYm6fzkdxO9N3jI2JEtc+lCkhvC9 H1vnyQVGilbwt0B0yt16DeZm6obzJFif2AKhBUglNrHwvY1U+MEFm4I9BXmY18Yh98RwcqejI4d c+/71NmZzkWVOZMgSRnPrrnjJ0IAjlnNKbd1pTj9oBhNYjkXImwDq5T8DhaTkJfa+UyILzE8tFh rhDdqBUvzDODwCkTqKzKvWNVZCNrzJyWNKWr46qOJKI1unwa2peuiRs43kpeGg50rmXcwGY= X-Google-Smtp-Source: AGHT+IEqC9+X7UdM4x6ymiMYpCXF2A9umIdi8++8F/hH+RGEfz5sKPNo1L21QYEspe606sPhJQ58Eg== X-Received: by 2002:a05:600c:3588:b0:439:a1c7:7b3a with SMTP id 5b1f17b1804b1-44ff400feb3mr16506235e9.1.1748500712596; Wed, 28 May 2025 23:38:32 -0700 (PDT) Received: from [192.168.1.29] ([178.197.223.125]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4efe7440asm1019578f8f.58.2025.05.28.23.38.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 May 2025 23:38:31 -0700 (PDT) Message-ID: Date: Thu, 29 May 2025 08:38:30 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 02/12] dt-bindings: arm: qcom-soc: ignore "wsa" from being selected as SoC component To: Alexey Klimov Cc: Srinivas Kandagatla , Mark Brown , linux-sound@vger.kernel.org, Liam Girdwood , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Dmitry Baryshkov , Konrad Dybcio , Konrad Dybcio , Jaroslav Kysela , Takashi Iwai , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org References: <20250522-rb2_audio_v3-v3-0-9eeb08cab9dc@linaro.org> <20250522-rb2_audio_v3-v3-2-9eeb08cab9dc@linaro.org> <20250523-fancy-upbeat-stoat-e9ecbd@kuoka> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+AhsD BQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmgXUEoF CRaWdJoACgkQG5NDfTtBYpudig/+Inb3Kjx1B7w2IpPKmpCT20QQQstx14Wi+rh2FcnV6+/9 tyHtYwdirraBGGerrNY1c14MX0Tsmzqu9NyZ43heQB2uJuQb35rmI4dn1G+ZH0BD7cwR+M9m lSV9YlF7z3Ycz2zHjxL1QXBVvwJRyE0sCIoe+0O9AW9Xj8L/dmvmRfDdtRhYVGyU7fze+lsH 1pXaq9fdef8QsAETCg5q0zxD+VS+OoZFx4ZtFqvzmhCs0eFvM7gNqiyczeVGUciVlO3+1ZUn eqQnxTXnqfJHptZTtK05uXGBwxjTHJrlSKnDslhZNkzv4JfTQhmERyx8BPHDkzpuPjfZ5Jp3 INcYsxgttyeDS4prv+XWlT7DUjIzcKih0tFDoW5/k6OZeFPba5PATHO78rcWFcduN8xB23B4 WFQAt5jpsP7/ngKQR9drMXfQGcEmqBq+aoVHobwOfEJTErdku05zjFmm1VnD55CzFJvG7Ll9 OsRfZD/1MKbl0k39NiRuf8IYFOxVCKrMSgnqED1eacLgj3AWnmfPlyB3Xka0FimVu5Q7r1H/ 9CCfHiOjjPsTAjE+Woh+/8Q0IyHzr+2sCe4g9w2tlsMQJhixykXC1KvzqMdUYKuE00CT+wdK nXj0hlNnThRfcA9VPYzKlx3W6GLlyB6umd6WBGGKyiOmOcPqUK3GIvnLzfTXR5DOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCaBdQXwUJFpZbKgAKCRAbk0N9O0Fim07TD/92Vcmzn/jaEBcq yT48ODfDIQVvg2nIDW+qbHtJ8DOT0d/qVbBTU7oBuo0xuHo+MTBp0pSTWbThLsSN1AuyP8wF KChC0JPcwOZZRS0dl3lFgg+c+rdZUHjsa247r+7fvm2zGG1/u+33lBJgnAIH5lSCjhP4VXiG q5ngCxGRuBq+0jNCKyAOC/vq2cS/dgdXwmf2aL8G7QVREX7mSl0x+CjWyrpFc1D/9NV/zIWB G1NR1fFb+oeOVhRGubYfiS62htUQjGLK7qbTmrd715kH9Noww1U5HH7WQzePt/SvC0RhQXNj XKBB+lwwM+XulFigmMF1KybRm7MNoLBrGDa3yGpAkHMkJ7NM4iSMdSxYAr60RtThnhKc2kLI zd8GqyBh0nGPIL+1ZVMBDXw1Eu0/Du0rWt1zAKXQYVAfBLCTmkOnPU0fjR7qVT41xdJ6KqQM NGQeV+0o9X91X6VBeK6Na3zt5y4eWkve65DRlk1aoeBmhAteioLZlXkqu0pZv+PKIVf+zFKu h0At/TN/618e/QVlZPbMeNSp3S3ieMP9Q6y4gw5CfgiDRJ2K9g99m6Rvlx1qwom6QbU06ltb vJE2K9oKd9nPp1NrBfBdEhX8oOwdCLJXEq83vdtOEqE42RxfYta4P3by0BHpcwzYbmi/Et7T 2+47PN9NZAOyb771QoVr8A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 28/05/2025 16:37, Alexey Klimov wrote: > On Fri May 23, 2025 at 9:12 AM BST, Krzysztof Kozlowski wrote: >> On Thu, May 22, 2025 at 06:40:52PM GMT, Alexey Klimov wrote: >>> The pattern matching incorrectly selects "wsa" because of "sa" substring >>> and evaluates it as a SoC component or block. >>> >>> Wsa88xx are family of amplifiers and should not be evaluated here. >>> >>> Signed-off-by: Alexey Klimov >>> --- >>> Documentation/devicetree/bindings/arm/qcom-soc.yaml | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/Documentation/devicetree/bindings/arm/qcom-soc.yaml b/Documentation/devicetree/bindings/arm/qcom-soc.yaml >>> index a77d68dcad4e52e4fee43729ac8dc1caf957262e..99521813a04ca416fe90454a811c4a13143efce3 100644 >>> --- a/Documentation/devicetree/bindings/arm/qcom-soc.yaml >>> +++ b/Documentation/devicetree/bindings/arm/qcom-soc.yaml >>> @@ -23,7 +23,7 @@ description: | >>> select: >>> properties: >>> compatible: >>> - pattern: "^qcom,.*(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sar|sc|sd[amx]|sm|x1[ep])[0-9]+.*$" >>> + pattern: "^qcom,(?!.*wsa)(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sar|sc|sd[amx]|smx1[ep])[0-9]+.*$" >> >> Why dropping front .*? Are you sure this matches what we want - so >> incorrect compatibles? To me it breaks the entire point of this select, >> so I am sure you did not test whether it still works. To remind: this is >> to select incorrect compatibles. > > Thanks, great point. I tested it with regular dtbs checks with different > dtb files but I didn't check if it selects incorrect compatibles. > > >> (?!wsa) >> Because qcom,x-wsa8845 should be matched and cause warnings. > > This is now confusing. I thought that the main job for the pattern above > is to avoid selecting wsa88xx amplifiers in the first place. Or, if I can > quote yourself: "What is WSA8815 that it should be here?" > > If said wsa8845 with incorrect or correct should be selected by that pattern > then why not just leave that pattern as it is then? I am lost. I guess I wanted to catch x-wsa8845 as well, but now never mind. It is not a soc so does not really matter for this file. > >> And probably we are getting past the point of readability, so could you >> try: >> >> compatible: >> anyOf: >> - pattern: "^qcom,.*(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sar|sc|sd[amx]|sm|x1[ep])[0-9]+.*$" >> - pattern: "^qcom,.*(?!wsa)sa[0-9]+.*$" Here should be: s/wsa/w/ Best regards, Krzysztof