From: Filip Kolev <fil.kolev@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org
Subject: Re: [PATCH] media: atomisp: ov2722: replace hardcoded function name
Date: Wed, 6 Jan 2021 19:43:42 +0200 [thread overview]
Message-ID: <dcdda829-89d6-badd-4f22-72d95d24e9e3@gmail.com> (raw)
In-Reply-To: <X/VsF364jpGz6oze@kroah.com>
On 06-Jan-21 09:51, Greg Kroah-Hartman wrote:
> On Tue, Jan 05, 2021 at 10:29:18PM +0200, Filip Kolev wrote:
>> There is a debug message using hardcoded function name instead of the
>> __func__ macro. Replace it.
>>
>> Report from checkpatch.pl on the file:
>>
>> WARNING: Prefer using '"%s...", __func__' to using 'ov2722_remove', this function's name, in a string
>> + dev_dbg(&client->dev, "ov2722_remove...\n");
>>
>> Signed-off-by: Filip Kolev <fil.kolev@gmail.com>
>> ---
>> drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
>> index eecefcd734d0e..21d6bc62d452a 100644
>> --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
>> +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
>> @@ -1175,7 +1175,7 @@ static int ov2722_remove(struct i2c_client *client)
>> struct v4l2_subdev *sd = i2c_get_clientdata(client);
>> struct ov2722_device *dev = to_ov2722_sensor(sd);
>>
>> - dev_dbg(&client->dev, "ov2722_remove...\n");
>> + dev_dbg(&client->dev, "%s...\n", __func__);
>
> dev_dbg() provides the function name already, and this is just a "trace"
> call, and ftrace should be used instead, so the whole line should be
> removed entirely.
Thank you for the review!
How do I go about this? Do I amend the patch and re-send as v2 or create
a new patch entirely?
Newbie here, doing this as part of the Eudyptula challenge, so I very
much appreciate everyone's patience.
>
> thanks,
>
> greg k-h
>
next prev parent reply other threads:[~2021-01-06 17:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 20:29 [PATCH] media: atomisp: ov2722: replace hardcoded function name Filip Kolev
2021-01-06 7:51 ` Greg Kroah-Hartman
2021-01-06 17:43 ` Filip Kolev [this message]
2021-01-06 17:52 ` Greg Kroah-Hartman
2021-01-06 18:25 ` Joe Perches
2021-01-06 19:36 ` Dan Carpenter
2021-01-06 21:17 ` Joe Perches
2021-01-07 10:53 ` Dan Carpenter
2021-01-08 18:32 ` [PATCH] checkpatch: Prefer ftrace over function entry/exit printks Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcdda829-89d6-badd-4f22-72d95d24e9e3@gmail.com \
--to=fil.kolev@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox