From: Qi Zheng <qi.zheng@linux.dev>
To: Chris Mason <mason@kernel.org>,
hughd@google.com, david@kernel.org,
baolin.wang@linux.alibaba.com, akpm@linux-foundation.org,
qinyuntan@linux.alibaba.com, shakeel.butt@linux.dev,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] mm/shmem: don't use the memcg of an uncharged folio
Date: Sat, 21 Nov 2026 18:50:06 +0800 [thread overview]
Message-ID: <dcf13dbe-f843-4e21-80a9-82214b501f4e@linux.dev> (raw)
In-Reply-To: <20261120195057.50031-2-mason@kernel.org>
On 11/21/26 3:50 AM, Chris Mason wrote:
> The shrinker for unused huge tmpfs folios can dereference a NULL memcg
> if it races with the migration of the folio at the end of a file.
>
> folio_memcg_list_lru_alloc() assumes that folio_memcg() is never NULL.
> But it is NULL until the folio is charged, and a migration target can be
> in the page cache before charging.
>
> shmem_unused_huge_shrink() looks the folio up without the folio lock,
> so we can race with migration:
>
> __migrate_folio() shmem_unused_huge_shrink()
> ================= ==========================
> __folio_migrate_mapping()
> xas_store(newfolio)
> filemap_get_entry()
> returns newfolio
> folio_trylock() fails
> shmem_unused_huge_requeue()
> folio_memcg_list_lru_alloc()
> folio_memcg() is NULL
> memcg->kmemcg_id
> folio_migrate_flags()
> mem_cgroup_migrate()
> commit_charge(newfolio)
>
> Fix it by keeping the original objcg around while the inode is isolated.
>
> Fixes: 743e7d025d2f ("mm: shmem: make unused huge shrinker memcg aware")
> Suggested-by: Qi Zheng <qi.zheng@linux.dev>
> Signed-off-by: Chris Mason <mason@kernel.org>
> ---
>
> Notes:
> v1->v2: adopt Qi Zheng's suggestion to return early in the
> failure path
>
> mm/shmem.c | 39 +++++++++++++++++++++++++++++++--------
> 1 file changed, 31 insertions(+), 8 deletions(-)
>
LGTM.
Reviewed-by: Qi Zheng <qi.zheng@linux.dev>
Thanks!
prev parent reply other threads:[~2026-11-21 10:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 19:50 [PATCH v2 0/1] mm/shmem: don't use the memcg of an uncharged folio Chris Mason
2026-11-20 19:50 ` [PATCH v2 1/1] " Chris Mason
2026-11-21 10:50 ` Qi Zheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcf13dbe-f843-4e21-80a9-82214b501f4e@linux.dev \
--to=qi.zheng@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@kernel.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mason@kernel.org \
--cc=qinyuntan@linux.alibaba.com \
--cc=shakeel.butt@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox