From: "Sungjong Seo" <sj1557.seo@samsung.com>
To: "'Jan Kara'" <jack@suse.cz>,
"'Phillip Lougher'" <phillip@squashfs.org.uk>
Cc: "'Andreas Gruenbacher'" <agruenba@redhat.com>,
"'Namjae Jeon'" <linkinjeon@kernel.org>,
"'OGAWA Hirofumi'" <hirofumi@mail.parknet.co.jp>,
"'Carlos Maiolino'" <cem@kernel.org>,
"'Darrick J. Wong'" <djwong@kernel.org>,
<linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"'Luis Chamberlain'" <mcgrof@kernel.org>, <sjdev.seo@gmail.com>,
<sj1557.seo@samsung.com>, <cpgs@samsung.com>
Subject: RE: Recent changes mean sb_min_blocksize() can now fail
Date: Tue, 8 Apr 2025 22:11:53 +0900 [thread overview]
Message-ID: <dd0001dba887$cbe78280$63b68780$@samsung.com> (raw)
In-Reply-To: <ormbk7uxe7v4givkz6ylo46aacfbrcy5zbasmti5tsqcirgijs@ulgt66vb2wbg>
Hi, All
> Hi!
>
> On Tue 08-04-25 06:33:53, Phillip Lougher wrote:
> > A recent (post 6.14) change to the kernel means sb_min_blocksize() can
> now fail,
> > and any filesystem which doesn't check the result may behave
> unexpectedly as a
> > result. This change has recently affected Squashfs, and checking the
> kernel code,
> > a number of other filesystems including isofs, gfs2, exfat, fat and xfs
> do not
> > check the result. This is a courtesy email to warn others of this
> change.
> >
> > The following emails give the relevant details.
> >
> > https://lore.kernel.org/all/2a13ea1c-08df-4807-83d4-
> 241831b7a2ec@squashfs.org.uk/
> > https://lore.kernel.org/all/129d4f39-6922-44e9-8b1c-
> 6455ee564dda@squashfs.org.uk/
>
> Indeed. Thanks for the heads up!
>
> Honza
> --
> Jan Kara <jack@suse.com>
> SUSE Labs, CR
exfat-fs calls it to set it to the minimum value of 512, but it's not
particularly problematic if it fails.
Thank you
B.R.
Sungjong Seo
next prev parent reply other threads:[~2025-04-08 13:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 5:33 Recent changes mean sb_min_blocksize() can now fail Phillip Lougher
2025-04-08 10:39 ` Jan Kara
2025-04-08 10:51 ` Jan Kara
2025-04-08 17:13 ` Luis Chamberlain
2025-04-08 13:11 ` Sungjong Seo [this message]
2025-04-08 11:27 ` OGAWA Hirofumi
2025-04-08 14:31 ` Darrick J. Wong
2025-04-08 17:36 ` Kent Overstreet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='dd0001dba887$cbe78280$63b68780$@samsung.com' \
--to=sj1557.seo@samsung.com \
--cc=agruenba@redhat.com \
--cc=cem@kernel.org \
--cc=cpgs@samsung.com \
--cc=djwong@kernel.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=jack@suse.cz \
--cc=linkinjeon@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=phillip@squashfs.org.uk \
--cc=sjdev.seo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox