From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8CA330595B for ; Thu, 7 May 2026 08:06:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778141192; cv=none; b=kTFCosMFA+KEyBCmn/CzqQ74HB0w4eYGdVRrkiStXXgF0iSGTQgh9huJXsmLEljrqIxbx+1Ba73E55toG4vffH7MnC9xWVolsIW52QsZljKiaH7db+fDaYkerIsuUvPFVEcHn9CQwegwfjvXd981k8lMdwmFSCI6B6h6mBXIaVI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778141192; c=relaxed/simple; bh=Zw9brY5wV+GxdZBOypdnRURlfwgBntEB0ZE6QRw/jAY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QlWIxp2lqlC6aGadRxcRLHkoUAp2nWy8Ad9kApgWpkXdA5Tq6blLZoundHS4+w9zTQV9dj5m0adE44Hs6nmEgBTVcJwj2fAwpY7vOmrQney1BeN3gAzeJMNspm2Hyjk4ySUIOJ8mxL688tHtXZEjqd2YFrH2KOuJ/paSf9me1N0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Zi+Yhcqr; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=ppHMc1zt; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Zi+Yhcqr"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="ppHMc1zt" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778141189; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l3bMSG0lPJSM2Emf2ZOLqrh1ujP+L6IYLdvVg0ZZk+s=; b=Zi+YhcqrxsbHIZizZ7w8hVe1avrW0qFWsOqFMJQ9pMwhGv9SNM1dIWEgUr9/lSU9tXyeRo MklcMJZrUtUZ6JLYGkSFtENTSmZ5jltG3NADPIN7aD+b2YDxJkycpPoj/q6Qbuww8gxql2 90iWqViTWqbfujb6om4EUcDZjKEnzmo= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-292-aub--ZndMfim6ukm9xELlQ-1; Thu, 07 May 2026 04:06:27 -0400 X-MC-Unique: aub--ZndMfim6ukm9xELlQ-1 X-Mimecast-MFC-AGG-ID: aub--ZndMfim6ukm9xELlQ_1778141186 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-48d121738feso4376065e9.2 for ; Thu, 07 May 2026 01:06:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778141186; x=1778745986; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=l3bMSG0lPJSM2Emf2ZOLqrh1ujP+L6IYLdvVg0ZZk+s=; b=ppHMc1ztuexhzsxhV5pTVrn8TGYOIDbX35OUrYJyS+UDgg0RT+yNdigwPTfF6RQ3Ke WVvOs1+5HU9aX2t1f27lkUquhP0YNlF2pcTCg0Hb8tca7U2GoDD78+YugDQRmFRmvOWw 6lIS8n7J6nrMsyPwhYlvE2Nhvn4pLNDL/fYfYEDRB0Yjqd/pJbNdYqmvOSKNOiC9LLDz L0Vof905uaPbYtYoJ8KDZ17SKnGsU3n1kA/dK88SkGDKdD9Fua1wJNtRII6VgKlSvW54 Y/FGqQ6Vfu9Rh2REY94elrQwpxIqJCV4DPW3vtVAW6VlVrahyvUrMDW+04WqARvLtoIU d85Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778141186; x=1778745986; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=l3bMSG0lPJSM2Emf2ZOLqrh1ujP+L6IYLdvVg0ZZk+s=; b=chDQ974Z42d7wytnYqqQ4eXMwN33tGchU0ozOdqAtrse+2t0/RQwpuDGQubZna42a/ g4hvXo9ErvjvoFd+P401XvaGbqOMc/lQMLvirMMnrAxKJNR55suPAYI6X1dV1oGowC5Y +vQCcs0FEoS84ayYulzlMNMIPNJERmuXGITnjsdg5f+IlZaJTP+yXOlG1eXMXVqkPPBg O1AOoFsX4BzPZGLJLo7krs4IwiM1AYK2khk1qkTPFIGZHHL0ceqUzdHEu4Jx0rDSqFSr WIfRe7ctKwlgEdpJVG/2Wm1gfFoypR/AL3bXCXZGOlCj98xfl5nnSc9W8JTwBINq1UEQ 1Eeg== X-Forwarded-Encrypted: i=1; AFNElJ9NZQq4f+M3KKRYAvHc36rOTiEavFY7ESqc5CRCnMl0/pPRH5Pl8rTsFitYZXmM+Z2w1id27j+tgEdm1Z4=@vger.kernel.org X-Gm-Message-State: AOJu0YxuEBHHRFnPfQ/O13Ld5lz/Ad6mHkbtDNeR9pDOtiSzDpY6NPS7 Kja5YbFzta/qH4BAt6eqAqoX8ozav1/me3LQaSMWYvEtKWvys06Dgj0sdlf4RPyqJoeJ/OVllNq RfiNJ8ArwOacHB+S76B9ALnOQgYwqoEZJHdDPwc6M4JeJDPOS5Vaek/X+wLWRvRGBEQ== X-Gm-Gg: AeBDievkYz0aLvtfLRo4btq2Ayw5ui1wu1D12YzmHjXypQMvO/qDMZYY3g16WR/eAAE NMmcAATSD0whopILEcJ0OCZ7cKF4QDM51CD8CQmj7HM1mvveFnVj41BTqwp8/sUY8n1gY+pQGQS UCyjrfulCJIeXyuCZBLjt6GoFg5Eqg5QgFhOzLIZGz/UzmqDJKfGXeNGD6VRmpF+111Gq9/j5HO LuGnI8M8lSqVs2WCoUBZ+g6V0i+Zmx9comiJ0lJPNzDTOShcTp9lEe2+q2P+2g/z9byz9qB+0XG RQrNUmLR+Ds9yjCA8xBeDdWrBlD5VxJFV7WTviyNzman75nYNI6+4nvgL7nn0Gdz53YTJz2oPfq J23QGyXHZJogKRHCWLSwhNti82Xu8luC5HftuofQB9cKvKEZrfh9lCSS5KE+JroEwwQ== X-Received: by 2002:a05:600c:3548:b0:489:1b0c:8b43 with SMTP id 5b1f17b1804b1-48e51e0969fmr109472175e9.1.1778141186239; Thu, 07 May 2026 01:06:26 -0700 (PDT) X-Received: by 2002:a05:600c:3548:b0:489:1b0c:8b43 with SMTP id 5b1f17b1804b1-48e51e0969fmr109471655e9.1.1778141185741; Thu, 07 May 2026 01:06:25 -0700 (PDT) Received: from [192.168.88.32] ([150.228.93.82]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e5310930esm48943405e9.7.2026.05.07.01.06.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 May 2026 01:06:25 -0700 (PDT) Message-ID: Date: Thu, 7 May 2026 10:06:24 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v6 04/10] enic: add admin CQ service with MSI-X interrupt and NAPI polling To: Satish Kharat , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Sesidhar Baddela References: <20260503-enic-sriov-v2-admin-channel-v2-v6-0-0af4fbc2d86d@cisco.com> <20260503-enic-sriov-v2-admin-channel-v2-v6-4-0af4fbc2d86d@cisco.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260503-enic-sriov-v2-admin-channel-v2-v6-4-0af4fbc2d86d@cisco.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/3/26 1:22 PM, Satish Kharat wrote: > @@ -197,13 +429,47 @@ static void enic_admin_free_resources(struct enic *enic) > > static void enic_admin_init_resources(struct enic *enic) > { > + unsigned int intr_offset = enic->admin_intr_index; > + > vnic_wq_init(&enic->admin_wq, 0, 0, 0); > vnic_rq_init(&enic->admin_rq, 1, 0, 0); > - vnic_cq_init(&enic->admin_cq[0], 0, 1, 0, 0, 1, 0, 1, 0, 0, 0); > - vnic_cq_init(&enic->admin_cq[1], 0, 1, 0, 0, 1, 0, 1, 0, 0, 0); > + vnic_cq_init(&enic->admin_cq[0], > + 0 /* flow_control_enable */, Replacing magic numbers with macro with significant names would make the code more readable with no need for additional comments. /P