Re: [PATCH 1/4] dt-bindings: display: panel: Add Novatek NT37705

[Krzysztof Kozlowski <krzk@kernel.org>]

On 05/05/2026 08:40, Luca Weiss wrote:
>>>>> +  compatible:
>>>>> +    contains:
>>>>> +      const: boe,bj631jhm-t71-d900
>>>>
>>>> Compatible doesn't match the filename, nor does the commit message match
>>>> what you've got here. Sounds like you're missing a fallback to
>>>> $filename.
>>>
>>> The last times I was upstreaming panel drivers (Feb 2024 and June 2025),
>>> this was the requested way of doing things.
>>
>> So this was requested that time and is requested now. What is here
>> uncertain?
>>
>>>
>>> Compatible being the company and model number making the actual panel
>>> assembly (driver IC + touchscreen + glass etc), while the rest being
>>> named after the driver IC manufacturer & number.
>>
>> So exactly what was asked for...
> 
> I don't quite understand what is asked for now, that's my issue.
> 
> 1. Change the filename to boe,bj631jhm-t71-d900.yaml and leave the rest
>    as-is.
> 
> 2. Add a fallback compatible for novatek,nt37705. IIRC last time it was
>    argued that a "generic" nt37705 driver will never be correct for a
>    specific panel since it's missing a bunch of panel-specific init. So
>    that's why there should not be a fallback to nt37705.

To my limited knowledge the (2) with fallback describing the specific IC
is preferred, because that compatible although not currently usable is
still specific and describes actual IC used. I imagine that such
fallback still could be useful to some SW implementation to determine
the IC and act based on that.

If you have sources of other preference, please share, but I just gave
same review to Neil for his ayaneo,wt0600-2k panels.

Best regards,
Krzysztof