From: Stephen Boyd <sboyd@kernel.org>
To: Francesco Dolcini <francesco@dolcini.it>,
Jai Luthra <j-luthra@ti.com>,
Michael Turquette <mturquette@baylibre.com>,
Santosh Shilimkar <ssantosh@kernel.org>
Cc: Francesco Dolcini <francesco.dolcini@toradex.com>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v1] clk: keystone: syscon-clk: Fix audio refclk
Date: Fri, 04 Aug 2023 18:12:57 -0700 [thread overview]
Message-ID: <dd80b41a26c62ba42efc51d9ab800bfb.sboyd@kernel.org> (raw)
In-Reply-To: <20230728222639.110409-1-francesco@dolcini.it>
Quoting Francesco Dolcini (2023-07-28 15:26:39)
> From: Francesco Dolcini <francesco.dolcini@toradex.com>
>
> Audio REFCLK's are not working correctly, trying to use them lead to the
> following errors:
>
> [ 6.575277] of_clk_hw_onecell_get: invalid index 4294934528
> [ 6.581515] wm8904 1-001a: Failed to get MCLK
> [ 6.586290] wm8904: probe of 1-001a failed with error -2
>
> The issue is that Audio REFCLK has #clock-cells = 0 [1], while the driver
> is registering those clocks assuming they have one cells. Fix this by
> registering the clock with of_clk_hw_simple_get() when there is only one
> instance, e.g. "audio_refclk".
>
> [1] Documentation/devicetree/bindings/clock/ti,am62-audio-refclk.yaml
>
> Fixes: 6acab96ee337 ("clk: keystone: syscon-clk: Add support for audio refclk")
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> ---
Applied to clk-fixes
prev parent reply other threads:[~2023-08-05 1:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 22:26 [PATCH v1] clk: keystone: syscon-clk: Fix audio refclk Francesco Dolcini
2023-07-31 10:37 ` Jai Luthra
2023-08-05 1:12 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd80b41a26c62ba42efc51d9ab800bfb.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=francesco.dolcini@toradex.com \
--cc=francesco@dolcini.it \
--cc=j-luthra@ti.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox