Re: [PATCH v2 1/4] rust: i2c: add basic I2C device and driver abstractions

[Igor Korotin <igor.korotin.linux@gmail.com>]

On 7/4/25 21:16, Danilo Krummrich wrote:
>> +
>> +        0
>> +    }
>> +
>> +    extern "C" fn remove_callback(pdev: *mut bindings::i2c_client) {
>> +        // SAFETY: `pdev` is a valid pointer to a `struct i2c_client`.
>> +        let ptr = unsafe { bindings::i2c_get_clientdata(pdev) }.cast();
>> +
>> +        // SAFETY: `remove_callback` is only ever called after a successful call to
>> +        // `probe_callback`, hence it's guaranteed that `ptr` points to a valid and initialized
>> +        // `KBox<T>` pointer created through `KBox::into_foreign`.
>> +        let _ = unsafe { KBox::<T>::from_foreign(ptr) };
> 
> I like to do that as well, but I usually get asked to use drop() instead, let's
> do that here as well. :)
> 

Danilo, could you, please, explain this one a little bit more? I see the
same pattern for all the implemented subsystems so far: auxiliary,
platform, pci.
If this pattern for these subsystems is to be changed, then I'm fine.
Otherwise I'm not sure I understand the difference between these 3 and
I2C Adapter abstraction

Thanks
Igor