From: Can Guo <cang@codeaurora.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
linux-arm-msm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>,
Jeffrey Hugo <jeffrey.l.hugo@gmail.com>,
Manu Gautam <mgautam@codeaurora.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/4] phy: qcom-qmp: Use register defines
Date: Tue, 24 Dec 2019 13:49:52 +0800 [thread overview]
Message-ID: <dd87f98b4dce29c4a509f03265b0a3aa@codeaurora.org> (raw)
In-Reply-To: <20191223143046.3376299-2-vkoul@kernel.org>
On 2019-12-23 22:30, Vinod Koul wrote:
> We already define register offsets so use them in register layout.
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
Reviewed-by: Can Guo <cang@codeaurora.org>
> ---
> drivers/phy/qualcomm/phy-qcom-qmp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c
> b/drivers/phy/qualcomm/phy-qcom-qmp.c
> index 66f91726b8b2..1196c85aa023 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qmp.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
> @@ -166,8 +166,8 @@ static const unsigned int
> sdm845_ufsphy_regs_layout[] = {
> };
>
> static const unsigned int sm8150_ufsphy_regs_layout[] = {
> - [QPHY_START_CTRL] = 0x00,
> - [QPHY_PCS_READY_STATUS] = 0x180,
> + [QPHY_START_CTRL] = QPHY_V4_PHY_START,
> + [QPHY_PCS_READY_STATUS] = QPHY_V4_PCS_READY_STATUS,
> };
>
> static const struct qmp_phy_init_tbl msm8996_pcie_serdes_tbl[] = {
next prev parent reply other threads:[~2019-12-24 5:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-23 14:30 [PATCH v3 0/4] phy: qcom-qmp: Fixes and updates for sm8150 Vinod Koul
2019-12-23 14:30 ` [PATCH v3 1/4] phy: qcom-qmp: Use register defines Vinod Koul
2019-12-24 3:41 ` Manu Gautam
2019-12-24 5:49 ` Can Guo [this message]
2019-12-23 14:30 ` [PATCH v3 2/4] phy: qcom-qmp: remove duplicate powerdown write Vinod Koul
2019-12-24 3:39 ` Manu Gautam
2019-12-24 5:56 ` Can Guo
2019-12-23 14:30 ` [PATCH v3 3/4] phy: qcom-qmp: remove no_pcs_sw_reset for sm8150 Vinod Koul
2019-12-24 3:39 ` Manu Gautam
2019-12-24 5:55 ` Can Guo
2019-12-23 14:30 ` [PATCH v3 4/4] phy: qcom-qmp: Add SW reset register Vinod Koul
2019-12-24 3:40 ` Manu Gautam
2019-12-24 5:55 ` Can Guo
2020-01-03 6:22 ` [PATCH v3 0/4] phy: qcom-qmp: Fixes and updates for sm8150 Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd87f98b4dce29c4a509f03265b0a3aa@codeaurora.org \
--to=cang@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=jeffrey.l.hugo@gmail.com \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgautam@codeaurora.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox