From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753496AbdJHVS5 (ORCPT ); Sun, 8 Oct 2017 17:18:57 -0400 Received: from mail-cys01nam02on0056.outbound.protection.outlook.com ([104.47.37.56]:57344 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753235AbdJHVSy (ORCPT ); Sun, 8 Oct 2017 17:18:54 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Cc: brijesh.singh@amd.com, Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Herbert Xu , Gary Hook , Tom Lendacky , linux-crypto@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Part2 PATCH v5.1 12.2/31] crypto: ccp: Define SEV userspace ioctl and command id To: Borislav Petkov References: <20171004131412.13038-13-brijesh.singh@amd.com> <20171007010607.78088-1-brijesh.singh@amd.com> <20171007010607.78088-2-brijesh.singh@amd.com> <20171007142010.6cnkeyywbitk6u73@pd.tnic> From: Brijesh Singh Message-ID: Date: Sun, 8 Oct 2017 16:18:44 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171007142010.6cnkeyywbitk6u73@pd.tnic> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: MWHPR15CA0039.namprd15.prod.outlook.com (10.173.226.153) To SN1PR12MB0159.namprd12.prod.outlook.com (10.162.3.146) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 85fa28a0-e16c-4e2d-f961-08d50e922c31 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:SN1PR12MB0159; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0159;3:8uMpYU+k0k6mPZCVhT2CODm9C3a07UGKW8A7JucI77BXzpc5RvE+dM5SGvDvRLMgBBb695BZezcDlZTNCajCt8m8sNvws/xJgpKqWPhZoZVJje0eaPiXUdtyOEr1S8mILtZ0FxLvi4s7ewJpSeMZRFT5dXb6U+HN6/glJpe3L57YmDnKbGnd0b9ymTI2obr1ZFxM1ciuUT+HdCgTrhGGxdKnEF0iaWfbJgDgP49oCtxRRTOovRZBBpxn9YgwFf8Q;25:TV7EExc6O2wlClo6P52JXJEpQ9U4thVxt1bZ+BjJ0mEhk7Ji898GRJ59MLT4b95db6bYCfEskdbbZ6mtNvQ91OvFYwUknfWtLNcDuWgK9MXKFoFvETPOjJCtiRUTSxFqt5s0Pp0iZ8GDDoGEiJgcQvx++VC5FKCz5cL/FiEiKcbgxTNJ0YNhmIo0UYYLfP2Nu2oGJOoPbWXPO4DNtBd35x1wFvIvwOTiDgHSPWPCGPy6t2n3gDOi+egfRtyRr/I7o18/z2oZ6HeDkFSBTbqqyybqI38BPeRCRT4fIzkgfv/6LykitnKdZa6owXR8LXs7FTItrFLYxlxhEgJz+ZlrjQ==;31:FlfkRgTjoYcjeWdKfzgzrf9XNhB97RchY9DzhXFX0Lm+xDGQOPi0iy6VNzBzLLytVcpDF/k0rGWznL5Bd+A/jrSlTgqxYRrz5gnCa6Ywpw6GI2gw2hdKkXhmNXsQ0wU1Yvb/nAyYUmgE2p/cxyiHj0OD/rPy8p9/NYawabeqexnGQdAf8tY+3DKpT1qCEWtW5luNuwNp3xmEUVpHxCDnKcw4yPnF8g/Yl587BmXT39k= X-MS-TrafficTypeDiagnostic: SN1PR12MB0159: X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0159;20:3fRjeeUDNnkuFNQRqRm108YWHvcRWAmAWD6LNIULXz5AZ/5jAjoeqnMCFm7XBQVUQ1GkT9dyhjzT1aTfyTYR9okF3YiOQSd7gdWrrYeD4Wj26op4dQyshkFGGXWrtuSeJmxTAHT322epPW9Pyhx5hQ1i9re30I2N6wHEaxnUtF31KLK2/6fB5n+PvihxAruGoEr07vM+7fVAl8Fdubpgkpx8wi3WKtoRUkmzD/tg4pnahxUq9WCrUquj11mdIwzvlmYDBVcJNRxQvw3zfv2FjWSou8qKwG/EAFwU709zB0XqVq9IpaOcGOmYBycZXCg9ECxyinwu3RGp/bpEwZEbtwbmf/U9PD9UJE5r3xNuJOcXaw4FkKRsqKXZlKyyQ6qS1aMY1iQh8kkNSqzFchqWAZxQfe8Fclf7uAWTy9aED7mZS4q55m5/XKz9diU+FIOXkfnX/gK0eHFnudYIJJBrj2qthk2UR0e5hFRBO7zYhlOlwuaaiOwJfSHnKWrtYHwn;4:JrfIfcdJW/A0v6uXWCF4v3KGS7TYoE0yeand75g8OQD+YzxOekgAX3+rAg+4tqutvs9/fvBfyYbGxOP8lmSPQtoSCyVbYOzWFBV0JBYjee0XxJTbuoROUrVzpRmBwKwokQGpEMLfIq41oRivSaniCxL3nJQmQmabTGBCsnApC/u4xDGshjsWPPtrpgzL/harQpify6gnIqgyFI/1jI+n5zIj+DX7D4OvxaX5hUJEC1FFOzVcNQ8v9QepSblYMWfZlhUzmvHhndJnmJx/Y8IScYCaOBFlBgg1oXlIV9DemB9hXuSy0wRQfYp794J8QpgW X-Exchange-Antispam-Report-Test: UriScan:(9452136761055)(767451399110); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(100000703101)(100105400095)(10201501046)(6055026)(6041248)(20161123562025)(20161123564025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:SN1PR12MB0159;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:SN1PR12MB0159; X-Forefront-PRVS: 0454444834 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(346002)(39860400002)(376002)(189002)(24454002)(199003)(5423002)(377454003)(47776003)(33646002)(68736007)(478600001)(53936002)(36756003)(101416001)(6246003)(106356001)(93886005)(66066001)(65806001)(65956001)(105586002)(3846002)(31696002)(54356999)(2950100002)(53416004)(6666003)(76176999)(31686004)(50986999)(50466002)(4326008)(6116002)(81156014)(53546010)(229853002)(54906003)(6486002)(64126003)(6916009)(58126008)(316002)(83506001)(23676002)(189998001)(8936002)(81166006)(16526018)(97736004)(8676002)(86362001)(2870700001)(65826007)(2906002)(305945005)(25786009)(5660300001)(7736002);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR12MB0159;H:wsp093958wss.amd.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjEyTUIwMTU5OzIzOllXdDlCT0NLZ1FVOHRNWXFPbjl0NkVqSzZm?= =?utf-8?B?Qkh1K0FjTGlOc2llQ3lmckZzOGxLZlppRWpQbHIvd3JFdVpoU1QrK251TVc3?= =?utf-8?B?YmppVkxlT2d6ZnRvVnpLeXl5cjZZbW9UWUJ6YWVDNnhSd1RZdVVCeHlPZlNr?= =?utf-8?B?bGMzSkl0OWQraTJVZ3NYZFdkY0x0cC9GNVQ2SEx1QllEMzNuaFlrVXY1KzVD?= =?utf-8?B?UENPejdtdnovSlB5WXdhaEZFZHFVWUJHd2I0Uk82M1pEOVNnc1BJNm1XTDNw?= =?utf-8?B?bFlUeHE2b3ZCM0JBaVByN3NGY3hicnFrMGRrRlVWUkIxQzNqNjNOMVQ2UURt?= =?utf-8?B?eit6NUlNb2pVVVUyLzVpeFZnVmcxRGlvWitkY0hmSkZtODRNYUdPQ0RVMisv?= =?utf-8?B?QUdhM1diaXlQbW5zVjRTSmxCZWFZRVpqWGZyYXQzSVI4Wk50OWcxSVVDN0Rm?= =?utf-8?B?NEI4eE4vRWtCM053TTJSOUNSM2J5MlN2ejkxQS9ycm9xYzhxZ2hrNXVGWlA3?= =?utf-8?B?SWYyREtwOTN2QlVqUzk0V3ptZ0RRM2J6bEQ1ZE9qVjJDREk3ZFVQRjcvYUVC?= =?utf-8?B?RHZwY1Fsdm9GQXk3dEtxQ25WSzZTYTZmSnpRYWpyOWc4VWROdHNQWGNWSFcy?= =?utf-8?B?cnkxZkUvY0ZhbkhlcGtwcFNHcHBwbjArN0F4MjJNQVpMWjZnMjFjUWREdWVt?= =?utf-8?B?bm02MTBwYmkrUHRyTXhZR2prSFZXS0NycExPQ0VDbWhua1Mra1dxejhhcFhI?= =?utf-8?B?a3RJMFFsdTlBamxsS1hOQTlXQUsyNS85bGs5NVVJZ0JDcW9OT1dCMEVrdWpW?= =?utf-8?B?TjhpQ3Q1WlNUaWZlMzg0SzlQcTloSzVqZGcxZUJzQnNvRGdqTVNlMGRTUVgy?= =?utf-8?B?SGVwZHV0WGhWYjJEbmU0b2h5T1JMRFY5SCtsK2NwTTBmb1ZmTWJGc2pYdktS?= =?utf-8?B?anQ4TThxeHZFOEFWRzVBdU1oUFBqejYvcEhZYzRnWFZiZmVtL2wwOHF5UVRN?= =?utf-8?B?aG5wSndOM3hxRFlLWDErVHJySjFPYXhyK0R1WWRzUTdpTFBrTkF4YkxYK21T?= =?utf-8?B?RHorelhtWHBNQWcvTUk4NWRnMGZqSWVSZ1Fudnl1QUVERkswSjQ5QUxGV3BR?= =?utf-8?B?ZllweTRDYXFtbUdwZlM0Vnp0RXNnSlVQRllrcHlVRURvQ0ZYWkNWOXNPRjhP?= =?utf-8?B?Y1pOM2JNN1Y2a3MveThUclJPRWlicmdFb0hrN3hTbC9XS0RBaW02amcxMGI5?= =?utf-8?B?dXVYQkZ4UndMbFI4ZFgxMTVKWjJtU2p1Q2tmMUh4dDMwNEQyeWFBdEI1Ukoy?= =?utf-8?B?bFYyS1pOUDRwbllrNWhWSXhySjRSb1pUZ040Q3ZxZ0ljMGwvNXdYRm4rRThI?= =?utf-8?B?cm5wTWFVZjFlY0tXWm14TWJlQmZMSzY1WXZ2Ky9rSnRydVpHN0NvRlJRSlRI?= =?utf-8?B?Z2wvZnQvSFhMdDdoUmlqWEw3QUpMdVV0RTJobG81QXRZMDBoK2xFZDdtSG5T?= =?utf-8?B?UUFyVzU4cHZJSmowM2QvSHMvNDZrUm4wL21BUzYwZ1krbXZDTnhjYVplSWNa?= =?utf-8?B?Y1BXckNNOVVGQk4xMnJHQzBIMmhLQlB4UzF1Q1lkRURrWDRJalRkaWxydjRD?= =?utf-8?B?eDNsQkg5T3RlaUU4MDFPckh1MmpyV3ZEWFkxUGdnWTBLdENtR213bFhSaEZQ?= =?utf-8?B?NUcvTC9BQWdFdXJoNERSSllZQnhEMUg4RTU4RGJFYUtjNy9yUUp6NXNpNGtY?= =?utf-8?B?OHlDWVIvWE4rR0F1VHpMdjNKUjMzS01LRDN5dm5vYWtkbjd6Q05Jb25WeE1C?= =?utf-8?B?NU1kc2oxVG9CQzlTR2xnRDBzaElJRHJHMjV2YzlSaS9aTnFoelI5V1k1czJo?= =?utf-8?Q?tr5MyYwpRP4CGODr4F6injgm3rOEaXaS?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0159;6:GnrxDuX8mn5EMV8UMpyYoHKWcYYHA+672nK9sMt/ZhIP5GjL5jkHpc1ExnSc5gqND/CwNZ69XJYhp4yrC8nH6UC87fwrSQhF15+WMbD2n4uskqVFB2ldr8mMEu1/osQvciBZom/OoECGQD1b3TcXQ1LhAzmAOUzMRBu6SgKpv31w6kUzqMvCrqngQmqqy+TZrEg0FJ80vWCZT4Ap3IIXJPiraTDYhWjdfqsWHRLiee1MNUK/19k3reNg2OeLM/df/i5so6/FXQ1A/aByiCbJWXRMBLkpil79mZL3dd+CCDlmD8k06BSvXj7hb0R/Q0jn77rNVE7oaXD11FcOU1GK1A==;5:gXkbmDJHSIBAWpFwgMw97ztPeHNvpa7S1siCmIlCl1FiMQf4weOm8xI2g077jb6AHZokXHsfF1tL0d9FcXRYtlv5/zj3QNsM5oAUt23+unNmKockZ+YyCmQpQxW3j4MffM/Y1LIbE9m/YazaLupHyw==;24:8xKEtecaYMr8qWEsPmNH1vjTj1TlTLh7h3eqFnomswnFi9HRZte6LbNZOuOBlaHhq7Yg5m46M918XBSwiCovgvxf7rNX3AbMpoKSSdvuUhM=;7:9EVj0fMeX3cjA32BhK3Alz7Z2YGiG0Ng62I08tKRdL/M8SiLFLuhEvqLj2kfKv2lGX+NFcz7OOgFzo0+rUqmXI+tJodCDFx5nqQknfbTi6DaCkGj2g6hRjS9IWxwMb1HcMK9/A61Rguxz0HX09BYjZPquE6tU5BREy3JN3EX+UNK8xQTrLxyFktOM/2bD4ma26BiFdQO87ZjFXiXzMU9ZnEWhTWXmxUYOAjBZYGyCTk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0159;20:87itF7f4OIUxpUvx6fjUvM5Ii94atT1h64q8z0E2b2553XHpZghd2K+Zp1xzqJaMHLYOr4HiL9ogSx7oFa46UzJe6iOzU9vt6tk0EOpktPIy8lJ69yMLT/rTcLp5NM4zbHkPdKpGzFjcU4lwgfMRK636IJb/+zfJWTiiX/VOLIbnJLqrFMnIEU7FogEiohvD4RSRA7dROCZvvq/5m++LEmr8p4Q+vmqvOdzpLvzTUZKTqW5sD4ImI/GuwQfEVdmM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2017 21:18:49.3998 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0159 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/7/17 9:20 AM, Borislav Petkov wrote: > On Fri, Oct 06, 2017 at 08:06:00PM -0500, Brijesh Singh wrote: >> Add a include file which defines the ioctl and command id used for >> issuing SEV platform management specific commands. >> >> Cc: Paolo Bonzini >> Cc: "Radim Krčmář" >> Cc: Borislav Petkov >> Cc: Herbert Xu >> Cc: Gary Hook >> Cc: Tom Lendacky >> Cc: linux-crypto@vger.kernel.org >> Cc: kvm@vger.kernel.org >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Brijesh Singh >> --- >> include/uapi/linux/psp-sev.h | 115 +++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 115 insertions(+) >> create mode 100644 include/uapi/linux/psp-sev.h > First of all, thanks for splitting the patch - it is much easier to > review this way. > > Then, this patch should be 12.1, i.e., the first of the split because otherwise > the previous one - which should be the next - fails building due to > > drivers/crypto/ccp/psp-dev.c:26:32: fatal error: uapi/linux/psp-sev.h: No such file or directory > #include > ^ > Just swap them in their order. Ah, yes I will swap the order in next submission. thanks