The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Matthieu Baerts <matttbe@kernel.org>
To: Michael Bommarito <michael.bommarito@gmail.com>
Cc: gang.yan@linux.dev, Geliang Tang <geliang@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	mptcp@lists.linux.dev, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Mat Martineau <martineau@kernel.org>
Subject: Re: [PATCH v2] mptcp: only set DATA_FIN when a mapping is present
Date: Thu, 9 Jul 2026 16:31:48 +0200	[thread overview]
Message-ID: <dd96a6a0-625b-43a2-9cae-3c159a847c74@kernel.org> (raw)
In-Reply-To: <CAJJ9bXy29+cwu+Me8WNrf=f4qc=uoXSMCrUG3NJbR-xANJxseA@mail.gmail.com>

On 09/07/2026 15:12, Michael Bommarito wrote:
> On Thu, Jul 9, 2026 at 8:27 AM Matthieu Baerts <matttbe@kernel.org> wrote:
> 
>> By chance, do you have a reproducer? Maybe using Packetdrill with MPTCP
>> support? [1]
>> If not, how did you discover this issue?
> 
> Yup, I'll send to you offlist.  It's a custom Python/TUN/qemu setup,
> not Packetdrill, but I'm guessing it could be ported or extended for
> testing/fuzzing.

Interesting. Yes, it could be useful for various protocols.

> I discovered it with my homegrown agentic stack, which is a Rube
> Goldberg machine full of various tools (like cocci, semgrep) and
> knowledge graphs (built with libclang).  The agent logs suggest that
> it came from a family of rules that surfaces suspicious struct init
> candidates, which I can share too.

Is it also based on crafted traffic? It could also be useful!

>> If I may add, please also send new version in a separate thread, not as
>> a reply, not to confuse various tools, as mentioned in the same doc.
> 
> Sure, thanks to both you and Gang for the feedback.  I'll send a v3
> based on your suggestions later today.

Thanks!

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.


      reply	other threads:[~2026-07-09 14:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <2edcb1cd-f2db-4d0c-a0e3-fd2b4dd820fe@redhat.com>
2026-07-07 17:17 ` [PATCH v2] mptcp: only set DATA_FIN when a mapping is present Michael Bommarito
2026-07-09  5:43   ` gang.yan
2026-07-09 12:26     ` Matthieu Baerts
2026-07-09 13:12       ` Michael Bommarito
2026-07-09 14:31         ` Matthieu Baerts [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dd96a6a0-625b-43a2-9cae-3c159a847c74@kernel.org \
    --to=matttbe@kernel.org \
    --cc=edumazet@google.com \
    --cc=gang.yan@linux.dev \
    --cc=geliang@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martineau@kernel.org \
    --cc=michael.bommarito@gmail.com \
    --cc=mptcp@lists.linux.dev \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox