From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-178.mta0.migadu.com (out-178.mta0.migadu.com [91.218.175.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7B1C1759F for ; Mon, 26 Feb 2024 04:22:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708921346; cv=none; b=pOcikeddN1UVUHia8JpqGPVf8IZ/hn4gyhHp91mKu2IY6I4IlFrWuQSiu5+bQSbSAPm5Len2qszNmA3be1jzSm+yVeWt5B+vPvyE8eRw323j3l5wBEnMZKkLH+sI2KsTkz5VZPgP0zS30kNPekAFdym4x71aRT1IS419KzNNlnU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708921346; c=relaxed/simple; bh=RgfQE/2D1DcMpey08Nd9CYj209z2ybghPP4CILv+ubQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qeOxZ4T1wNNb33JS+yfdm4wTkW5gBZ4fCGWSgXZg2JKLXcEC0YwcXGtUs0mXEbyvpd8nj00Z6Udx+KHfIjmJtvKUrWFKge8eD9V/33bR1QVkp/45hPX0MrR+ro7BqriaZkfdfd8aXUxVw8Y68eQ3VsmYtqhPrtjS0tozyqLY5dk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=lVtO//zl; arc=none smtp.client-ip=91.218.175.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="lVtO//zl" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1708921341; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1JSBKAC57cp8w/tmE/XKxptpPiKoJ0VG+X8vxxgNIu4=; b=lVtO//zlJWvJVvJt7NwyLtFBcW3cD4e/vXq1kFN1WZP/nDZuA1zZ1xzjG/rXUje7ya0IcT 24F6FT8wLdRJ6pyB4W7UrN5ExjDl/aHDgxarOQFr4xHXSIH+gnNxe+MVrqYzHTmwBkYWAV y3f4NJFgHoF5qnWNNZPmDaFgZV1HoSk= Date: Mon, 26 Feb 2024 12:22:04 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH] ext4: remove SLAB_MEM_SPREAD flag usage Content-Language: en-US To: tytso@mit.edu, adilger.kernel@dilger.ca Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, vbabka@suse.cz, roman.gushchin@linux.dev, Xiongwei.Song@windriver.com References: <20240224134822.829456-1-chengming.zhou@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou In-Reply-To: <20240224134822.829456-1-chengming.zhou@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 2024/2/24 21:48, chengming.zhou@linux.dev wrote: > From: Chengming Zhou > > The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove > its usage so we can delete it from slab. No functional change. Update changelog to make it clearer: The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was removed as of v6.8-rc1, so it became a dead flag since the commit 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the series[1] went on to mark it obsolete to avoid confusion for users. Here we can just remove all its users, which has no functional change. [1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/ Thanks! > > Signed-off-by: Chengming Zhou > --- > fs/ext4/super.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/ext4/super.c b/fs/ext4/super.c > index eb689fb85ce9..9a744f22aa24 100644 > --- a/fs/ext4/super.c > +++ b/fs/ext4/super.c > @@ -1500,8 +1500,7 @@ static int __init init_inodecache(void) > { > ext4_inode_cachep = kmem_cache_create_usercopy("ext4_inode_cache", > sizeof(struct ext4_inode_info), 0, > - (SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD| > - SLAB_ACCOUNT), > + SLAB_RECLAIM_ACCOUNT|SLAB_ACCOUNT, > offsetof(struct ext4_inode_info, i_data), > sizeof_field(struct ext4_inode_info, i_data), > init_once);