From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751280AbdJWFu7 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 23 Oct 2017 01:50:59 -0400
Received: from mout.web.de ([212.227.15.4]:63126 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750995AbdJWFu5 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 23 Oct 2017 01:50:57 -0400
Subject: Re: [PATCH 1/2] extcon: max14577: Use common error handling code in
 max14577_muic_set_path()
To: Chanwoo Choi <cw00.choi@samsung.com>, kernel-janitors@vger.kernel.org
References: <d08cbbf6-015a-ab76-6491-126901d1dda6@users.sourceforge.net>
 <CGME20171022175126epcas2p1a0b5b09f6294470b5c3f6c23c2a0f7e4@epcas2p1.samsung.com>
 <5cdefd84-066d-5379-43c8-76f5d3b8f7c4@users.sourceforge.net>
 <59ED3E72.7010401@samsung.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        LKML <linux-kernel@vger.kernel.org>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <dda9c1c2-79ec-398e-40ed-a11e894e138b@users.sourceforge.net>
Date: Mon, 23 Oct 2017 07:45:31 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <59ED3E72.7010401@samsung.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:mmzGf8/6IZa2iTflmS+VHDRtU6wddjCjX2PkuTkJma9T2zA64gs
 kuIpDBIrhj7q8sDHF1pOi+RW0lMaCiRClJThX5bNMpDF/Wp1dGMzL4nHdUq4kmxxhhwZsmJ
 2U2dvSMlatfD0N9UsNyCYUtX/WbH03UHlr/6pi65HMZJb00mibfNKgQX+L14hxf6pXAkovp
 /1Lixc6m8kXBYVFaMtW1w==
X-UI-Out-Filterresults: notjunk:1;V01:K0:3oh4uv/AwkE=:FstLoxEkAjnQ8MnSy2cwZC
 /+sdJ1rzkXwXjutrzXtv0utSDIFkQhEU3+NEK9j3PbM2pKw4uz8tJgKqVQjUnjyLeTohPZTP8
 Cz7kvVhksJaq0+QnB5Cl37yeZm4476XtRldR4iM4iE9GwGqq9pxcsNoe/CgxpAr+XfhcwO6L0
 2g6SVivPIZlVR7dnqPbSBqzEgcYN4uVqV1lnl2o9oP+e1bGWra3Q+q6IjMQ4SH6Cum5eX04id
 tZlKVL4aElSbh0D/nY/jPOdmL0libvbij2zsdzq6DDIytWl5gKKgsH+B6/34ohJOWHb4r1iqa
 PsuJINKFYwMrtPctJLB+vnyAKlYEHjTTD3NUC2TUmi2lx7RYLOGtbjFkzW242CUk166l35QHs
 XVi3xbgOLFqfpgziY+h807URiwh2CZ+fXUrAOwBDxFNM8eDFAtKDasUZUmc8ZAtmPzyItqcSg
 lCfuZsqyl/0cqt3hi5Arqi8xUPmDDj/GTNPH7okEeskdcLA3hl2TskwvbxW3/QRS7HkuG6yln
 P8lljqsGe3CVDaFhcEsS540EHjCvdkJxJoX+6phnN5TH53Um21wFWYTM9UuztzdNQ6SBQ9zob
 +eE5/ErClwmwZv9jAXUrtX0fVLOCr4mDv3B0AbPm+ugUy3jgYGSXgjwcTNqFGQYgnI2EfRVEs
 FYKuZM5pM8iKDFdZ7hseY6A8xCtr64XIU0+NVSoq6/niWNWQeX/nWeO6igSgKbsZS5q/TTfC7
 D3y+dxGvl3q5mX5WmEsJ2utePCvb/cT6CC+JRdx4OnfMfvYjr8XKcjRopgMo+R74ACo8NmAF9
 1zMIw9xPlxi1202DX9yxinNkm1X7PAXpUDCqzRorA/GGOnZDNg=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> As you commented, this patch might remove the redundant error message.
> But, it makes the code more complicated in side of readability.

Do you try to avoid duplicated code any more in other circumstances?

Regards,
Markus