From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3375B314D01 for ; Thu, 13 Nov 2025 20:40:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763066442; cv=none; b=AeDg1EQEDalnsOPpcoL3jByHgEDyTR+TZrkh03oIHdkVZZrh3rKQncevy2U+Zb7L+k+MzaGRedGXwHb8qF4FQNTkIeghmeslOTZdns4FXa0yzXqvoOnZ0Yj/Y/ynuq+843g+fzlxcevxgXzWnh+DQaDVSLhDFEu2sPHpPJQQ4Fw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763066442; c=relaxed/simple; bh=k9S0J4kOPP6rNUpj9hSQNdmH4J074CxuYrIkFj4FhWc=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=XaXdqHpMiIjUsu8aL0X8A4yLR75V0wMP2Fr4gqhRyg87/V1aPohOh9MWGyGl6WubjaaZPwOZyByh5d15OVUxkRVfbPFW/OVed3HGE/eNcFbOCAigWXppFYcLCUW/sBfn8qFe83rKQEhIW7jH7m8JskftZxJ6Lihh8TmaI5M0gyo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=vDv2zUrw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="vDv2zUrw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 86E09C4CEFB; Thu, 13 Nov 2025 20:40:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763066441; bh=k9S0J4kOPP6rNUpj9hSQNdmH4J074CxuYrIkFj4FhWc=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=vDv2zUrwUETRUlIW1qxCkExTUfDNbDLNhgWCd2O2gi/B9fEgNh3w3+bbnn8eRlLSA 32U/S0i0baBFDrtqns7Hm6ujWaFHg8JF0k4So3TNVuVAiqQnT0ceHmnHxJzZFjUT1k AxGMcRthB3gXZalQADlxL0fmLKjesTsBdUO75YYmh9hsNJKGrEbVt3aQ4OE3zauMzM U8kPkKQwwh1IwzoYBhW41fPvNl5GeJjK3q7x65EGhw6yrb1kJY2rT1r09rli5dy+Gw j++lT9J/k6jEU8r9/ETn7IXddqwaYHF59ZMHaJSyJmHeBV/4IqWrQB0Mi45gKVDsEV ++Kki53ERiMDw== Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfauth.phl.internal (Postfix) with ESMTP id 745A7F40068; Thu, 13 Nov 2025 15:40:40 -0500 (EST) Received: from phl-imap-08 ([10.202.2.84]) by phl-compute-04.internal (MEProxy); Thu, 13 Nov 2025 15:40:40 -0500 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvtdejledvucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepofggfffhvfevkfgjfhfutgfgsehtjeertdertddtnecuhfhrohhmpedfnfgvohhn ucftohhmrghnohhvshhkhidfuceolhgvohhnsehkvghrnhgvlhdrohhrgheqnecuggftrf grthhtvghrnhepgeduhfeugeeuueefveejtdefudekkeekhfeuiefhffejgfelleefleeh ueetgfefnecuffhomhgrihhnpehpvdhpughmrgdrmhgrphenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghonhdomhgvshhmthhprghuthhh phgvrhhsohhnrghlihhthidquddvfedtheefleekgedqvdejjeeljeejvdekqdhlvghonh eppehkvghrnhgvlhdrohhrgheslhgvohhnrdhnuhdpnhgspghrtghpthhtohepjedpmhho uggvpehsmhhtphhouhhtpdhrtghpthhtohepshgrghhisehgrhhimhgsvghrghdrmhgvpd hrtghpthhtoheprgigsghovgeskhgvrhhnvghlrdgukhdprhgtphhtthhopehksghushgt hheskhgvrhhnvghlrdhorhhgpdhrtghpthhtoheplhhinhhugidqnhhvmhgvsehlihhsth hsrdhinhhfrhgruggvrggurdhorhhgpdhrtghpthhtohephhgthheslhhsthdruggvpdhr tghpthhtoheplhhinhhugidqsghlohgtkhesvhhgvghrrdhkvghrnhgvlhdrohhrghdprh gtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrgh X-ME-Proxy: Feedback-ID: i927946fb:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 3AB722CE0083; Thu, 13 Nov 2025 15:40:40 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: AaNBfhOYEQos Date: Thu, 13 Nov 2025 22:40:19 +0200 From: "Leon Romanovsky" To: "Keith Busch" Cc: "Jens Axboe" , "Christoph Hellwig" , "Sagi Grimberg" , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org Message-Id: In-Reply-To: References: <20251112-block-with-mmio-v4-0-54aeb609d28d@nvidia.com> <176305197986.133468.1935881415989157155.b4-ty@kernel.dk> <4f75497d-11cb-437c-ab90-d65d4d2e0a52@kernel.dk> <20251113195008.GA111768@unreal> Subject: Re: [PATCH v4 0/2] block: Enable proper MMIO memory handling for P2P DMA Content-Type: text/plain Content-Transfer-Encoding: 7bit On Thu, Nov 13, 2025, at 22:13, Leon Romanovsky wrote: > On Thu, Nov 13, 2025, at 22:03, Keith Busch wrote: >> On Thu, Nov 13, 2025 at 09:50:08PM +0200, Leon Romanovsky wrote: >>> Can you please squash this fixup instead? >> >> I think you should change pci_p2pdma_state() to always initialize the >> map type instead of making the caller do it. > > Yes, i just was afraid to add another subsystem into the mix. Another solution is to call to pci_p2pdma_state() again instead of checking iter.p2pdma.map in nvme. Which option do you prefer? Thanks