From: "Kathpalia, Tanmay" <tanmay.kathpalia@altera.com>
To: Dinh Nguyen <dinguyen@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: reset: altr: add COMBOPHY_RESET for Agilex5
Date: Tue, 28 Apr 2026 20:39:32 +0530 [thread overview]
Message-ID: <ddc1d4a3-0287-4a57-b3dd-8a9260da05f3@altera.com> (raw)
In-Reply-To: <96705fc3-332e-4bd1-acb9-7494ca83e070@kernel.org>
Hi Dinh,
On 4/28/2026 6:02 PM, Dinh Nguyen wrote:
> Hi Tanmay
>
> On 4/28/26 04:26, Tanmay Kathpalia wrote:
>> Add COMBOPHY_RESET definition at index 38 for the combo PHY reset
>> control on Altera Agilex5 SoCs. This reset is used by peripherals
>> such as the SD/eMMC controller that share the combo PHY.
>>
>> Signed-off-by: Tanmay Kathpalia <tanmay.kathpalia@altera.com>
>> ---
>> include/dt-bindings/reset/altr,rst-mgr-s10.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/dt-bindings/reset/altr,rst-mgr-s10.h
>> b/include/dt-bindings/reset/altr,rst-mgr-s10.h
>> index 04c4d0c6fd34..c2505b9eb63e 100644
>> --- a/include/dt-bindings/reset/altr,rst-mgr-s10.h
>> +++ b/include/dt-bindings/reset/altr,rst-mgr-s10.h
>> @@ -22,7 +22,7 @@
>> #define USB0_RESET 35
>> #define USB1_RESET 36
>> #define NAND_RESET 37
>> -/* 38 is empty */
>> +#define COMBOPHY_RESET 38
>> #define SDMMC_RESET 39
>> #define EMAC0_OCP_RESET 40
>> #define EMAC1_OCP_RESET 41
>
> Please include the patch(es) that will make use of this change.
>
Thanks for the feedback, I will incorporate this patch as part of
the driver series
Regards,
Tanmay
prev parent reply other threads:[~2026-04-28 15:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 9:26 [PATCH] dt-bindings: reset: altr: add COMBOPHY_RESET for Agilex5 Tanmay Kathpalia
2026-04-28 12:32 ` Dinh Nguyen
2026-04-28 15:09 ` Kathpalia, Tanmay [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddc1d4a3-0287-4a57-b3dd-8a9260da05f3@altera.com \
--to=tanmay.kathpalia@altera.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox