From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Rob Clark <robin.clark@oss.qualcomm.com>,
Dmitry Baryshkov <lumag@kernel.org>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Jessica Zhang <jessica.zhang@oss.qualcomm.com>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Kuogee Hsieh <quic_khsieh@quicinc.com>,
Abel Vesa <abel.vesa@linaro.org>,
Mahadevan <quic_mahap@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 8/9] arm64: dts: qcom: sm6350: correct DP compatibility strings
Date: Tue, 2 Sep 2025 08:07:22 +0200 [thread overview]
Message-ID: <ddd0f518-f9e1-49e8-bbaf-b810adcd35b3@linaro.org> (raw)
In-Reply-To: <abkkn4f7uca6tzjasltyysxecuuirxxvbjz6l6re5v4z6jlmuh@ugz6jtw6vo4n>
On 02/09/2025 06:04, Dmitry Baryshkov wrote:
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qcom/sm6350.dtsi
>>> index 2493b9611dcb675f4c33794ecc0ee9e8823e24d4..8459b27cacc72a4827a2e289e669163ad6250059 100644
>>> --- a/arch/arm64/boot/dts/qcom/sm6350.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi
>>> @@ -2249,7 +2249,7 @@ opp-560000000 {
>>> };
>>>
>>> mdss_dp: displayport-controller@ae90000 {
>>> - compatible = "qcom,sm6350-dp", "qcom,sm8350-dp";
>>> + compatible = "qcom,sm6350-dp", "qcom,sc7180-dp";
>>
>> No, that's breaking all the users.
>
> WHy though? Both old and new lines are using fallbacks to bind the
> driver to the device.
Kernel has sc7180 fallback, but what if other DTS user does not and that
other user was relying on sm8350 fallback compatible? That other user
won't have sm6350 dedicated handling as well.
That breaking of users I meant.
With the kernel it should work, assuming SC7180-dp was introduced
similar time as 8350-dp.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-09-02 6:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 22:48 [PATCH v7 0/9] dt-bindings: msm/dp: Add support for 4 pixel streams Dmitry Baryshkov
2025-08-28 22:48 ` [PATCH v7 1/9] dt-bindings: display/msm: dp-controller: allow eDP for SA8775P Dmitry Baryshkov
2025-08-28 22:48 ` [PATCH v7 2/9] dt-bindings: display/msm: dp-controller: fix fallback for SM6350 Dmitry Baryshkov
2025-09-01 3:45 ` Krzysztof Kozlowski
2025-09-02 4:03 ` Dmitry Baryshkov
2025-09-02 6:04 ` Krzysztof Kozlowski
2025-09-02 10:01 ` Dmitry Baryshkov
2025-09-02 12:09 ` Krzysztof Kozlowski
2025-09-02 16:29 ` Dmitry Baryshkov
2025-08-28 22:48 ` [PATCH v7 3/9] dt-bindings: display/msm: dp-controller: document DP on SM7150 Dmitry Baryshkov
2025-09-01 3:49 ` Krzysztof Kozlowski
2025-08-28 22:48 ` [PATCH v7 4/9] dt-bindings: display/msm: qcom,x1e80100-mdss: correct DP addresses Dmitry Baryshkov
2025-08-28 22:48 ` [PATCH v7 5/9] dt-bindings: display/msm: dp-controller: add X1E80100 Dmitry Baryshkov
2025-08-28 22:48 ` [PATCH v7 6/9] dt-bindings: display/msm: drop assigned-clock-parents for dp controller Dmitry Baryshkov
2025-08-28 22:48 ` [PATCH v7 7/9] dt-bindings: display/msm: expand to support MST Dmitry Baryshkov
2025-09-02 6:44 ` Krzysztof Kozlowski
2025-08-28 22:48 ` [PATCH v7 8/9] arm64: dts: qcom: sm6350: correct DP compatibility strings Dmitry Baryshkov
2025-09-01 3:47 ` Krzysztof Kozlowski
2025-09-02 4:04 ` Dmitry Baryshkov
2025-09-02 6:07 ` Krzysztof Kozlowski [this message]
2025-09-02 10:07 ` Dmitry Baryshkov
2025-08-28 22:48 ` [PATCH v7 9/9] arm64: dts: qcom: Add MST pixel streams for displayport Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddd0f518-f9e1-49e8-bbaf-b810adcd35b3@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=abel.vesa@linaro.org \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jessica.zhang@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marijn.suijten@somainline.org \
--cc=mripard@kernel.org \
--cc=quic_khsieh@quicinc.com \
--cc=quic_mahap@quicinc.com \
--cc=robh@kernel.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).