From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4817B268C42 for ; Tue, 18 Nov 2025 09:53:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763459642; cv=none; b=b9pa3dYf7t+eywpVpd2Vll2xti3LDyFehP5zVm1jq+82NxsbsumwstJxToNmtLk8k9CRrG91ACOYQG3CSAt+qponnxqpzZZc5dlR9zib9/0c84tW49cvQhsz4nd9SVCItUf3/cGHJryVccM3ASXMz35oB51b+Geqh+60M9j3XHk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763459642; c=relaxed/simple; bh=5fM0Awd1Cl1zoqXUtiblDpUfWEvg7OkBguj0W2S4tn4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FySI9vlbHMZflQ2aOGYQpiHEQwdvw006+/NXcB/gYfwylTmtupmJ+qwxmuAiI67h89UWSaLOdU48TYM6OxjcQ5da76zqd8rB3Z/LX6LbK7IDaTg2LNjo5fbSUCXuMw2Qb9o8bvYnoZF95v77flcxnpTvC5vwHz+bllyuvRJmsP0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=V7vu4MPP; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Kek3w7l2; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="V7vu4MPP"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Kek3w7l2" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AI6aFjc385904 for ; Tue, 18 Nov 2025 09:53:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gPufLjmIrqMLSLMrepnxIXEELbKqNgUquhm6Il1/jc0=; b=V7vu4MPPTc3MaEmF 3FV9hDq70X+vOOx54C/DxqWzFkfrTHOZpShBpGHFdVx967BSFAUkN9MsDyYfrWmB bcjfMTeg/DJoIP4XFg/yX26MVub9Tmnw0mISKwxy2gq8HI4Z6erNHKS2LZgtVKkV ma6upZyo4l9L22HIFlR9L+2tY+CEpPOEqmPi3/Z5AqSR81r4ldxxxQhdna3ox8p8 EdYkikX3NIXD8I6acAYxMauu1FD9L3E2sp86LG9ONJqruQJAujAEd6AbRwAthm8i YqKDg1Ff49JSzq6brg3Mem8AJNJIM1YxJI9uMowroX2RowdaYdH8vggj6pSHyZAE KNnQ2A== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4agag8j13j-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 18 Nov 2025 09:53:59 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-34188ba5990so16484537a91.0 for ; Tue, 18 Nov 2025 01:53:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763459638; x=1764064438; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gPufLjmIrqMLSLMrepnxIXEELbKqNgUquhm6Il1/jc0=; b=Kek3w7l23pQJutXiqIsBmtw/yyUZYFMAsRFbGnlmtk1Ha9lJFD+yARLvNh4FVfFu6R k6xr2mJS4+7IrmfyzGCDny9VGAhNgpjurH3qHFGNQSKDyJJmR7gBc8seC+08njAvI0SL 7aU2NVuNoSjCox7JsFGOmHpgzehfu109VDeV1aSLx4HCT0YuGaNgJwx1eLWeGumlpAYE 8DuVaJ3Ghib79kKoSEPQG3Fb3AQZTppV5sdleFTOhnVPgqE9loZqzAGPCiUD8Uq41Iox yoRZhvapJw7GRX1gXVdqiFhFnlWiNLK6ejvNaVfcAPL89sPab3z/w1/zxcR53SkNt+8D xhwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763459638; x=1764064438; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gPufLjmIrqMLSLMrepnxIXEELbKqNgUquhm6Il1/jc0=; b=tFNZP5054DSVpchxlPo3l4QDv3BHDgRx61mQBBZ61ckYuN/hzGX1LNFezs+sLoukcq 3LdXz3d9O6BT1nsEFWiLxp63grGH1rtyTZNn77/YToegBK9isQ4zqOSObn2XO8m2glQZ s8qZLpFPnrxTk0EkR9VG9u8XY/5sMOhsRY2O+5r9NApebcQ7ZCWBP4db3NOFEhczfmkE HBgodSRrBap7oRO3+Uwsj8AkNF9yxcASVBMwQTOK7Y3ZGh0TGhy6OaCgC81PLaRAot9W QAEid74RGD+Gi8QHtVyp8TJyakjTq1R8xGNUDQBadh0KsLm5QN5SSvZ2P5q+gH7u9g2R qrjA== X-Forwarded-Encrypted: i=1; AJvYcCVSgdxfBcLb/qyxTmhBvANma3ojthgWf4F/T13eraT+pqzKkFijQUsdwyQOn/GgKRFSQ4nHZ4i/kfQcX7c=@vger.kernel.org X-Gm-Message-State: AOJu0YxPUi2f4iRgpiPZAUhenz9p+x23kO3iJ0pEtzG6yxZsjPCiN0km 0jP5Du28kkxbZZJcLNBjQhQ1Y/rGm+soSDLQy0ewBkgbKqoCZKmx2NncbleuT+xqhkJQSeOgiWz xKuSd7F6cMQ3PFv58VqL7tfCykuSedaaS+dDBANm6vgsmD2Dt+ZdAeIP80vL/JA+9/G0= X-Gm-Gg: ASbGncsLi/n3pH5eGErKs3UBj7pM//W6YX+LEpjZUb/+0RpBZlqJErZ+UX284QT3jHE LsTt+i5iE/q+qS70HpK6CDzSwoW2Ixd2Yy7MXJXhLM33YKaAAvHjSY3vHC2YVHmS8XxNW8uNCXb 9WNw76umvL7mrySiegBC8OhzCcDVk5mLucCg1eflB0pLDMClftAf0jdqwtKt1LO77MsQS7Vnbl0 vhYuNzqNf5H0DSWonHDLxH6/laWkqyKREcWG5m+85u57pS+qzkPBDtBVJTiQnbISAW/u5IngqnY IGIHojwqZBWXlMy+wY9dP+BapNlL9S89eZS05HwF5ed5KNsnRfp5tM1oCE/D6ByAdM2FrCPu7j4 kYy6sq3htaK97Ap0cam5FANAGFxyZa74Ag4B42e7fRYxt45/NfUptidkhP+Gm29FDUp3lR273 X-Received: by 2002:a17:90b:4b89:b0:340:dd2c:a3f5 with SMTP id 98e67ed59e1d1-343f9d9116fmr17829702a91.3.1763459638601; Tue, 18 Nov 2025 01:53:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IGoeE4yTWrswRWzDc+hCOps1oXPq1aDH32AhkqgBFvLZGGTCpqSrYv/TJJihXrjfjuRDAJWJQ== X-Received: by 2002:a17:90b:4b89:b0:340:dd2c:a3f5 with SMTP id 98e67ed59e1d1-343f9d9116fmr17829684a91.3.1763459638174; Tue, 18 Nov 2025 01:53:58 -0800 (PST) Received: from [10.133.33.104] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7b927c22b1bsm15751738b3a.66.2025.11.18.01.53.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Nov 2025 01:53:57 -0800 (PST) Message-ID: Date: Tue, 18 Nov 2025 17:53:52 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wifi: ath12k: fix endianness handling for SRNG ring pointer accesses To: Alexander Wilhelm Cc: Jeff Johnson , linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-kernel@vger.kernel.org References: <20251118072123.19355-1-alexander.wilhelm@westermo.com> <5a308d21-d463-4d6f-b5d3-95a0c2ede2c1@oss.qualcomm.com> From: Baochen Qiang Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: o77mDJYm0yVlZEnPC_biYhYmENFq4q4V X-Proofpoint-ORIG-GUID: o77mDJYm0yVlZEnPC_biYhYmENFq4q4V X-Authority-Analysis: v=2.4 cv=G6sR0tk5 c=1 sm=1 tr=0 ts=691c4237 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=N9GNhs4bAAAA:8 a=HCAvJRNLDqgM5c4XLS4A:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 a=PZhj9NlD-CKO8hVp7yCs:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTE4MDA3OCBTYWx0ZWRfX2rZB/SCIPRw5 wntPF+0RA0bAReo1HwuGpyZs/WXdJQQfnaIiZSwKUOB0NOOlNeXQi1ZMJQD5blrbbtA89+sxtLk 28E29k9IyyORVqZE5BERKtg9iZx0zd2mQ+ogU6rTSomIBlSAXWwISr3vPevWHdPzDxLmNDe1M/V 9mIBVMCRjegXbvzIl8VVfN9YjSmN9nUDfDQMB6zLw1WEarvsLn1IcWFlR/uV6lgqficmkoAQUIm FDG7HvipSBE4HVWGTktfRyMzhpBEIIYWj7xzV8Qbk1og8ZEgjd0ukgHHFbR3hZthhPipPPKm4+D NYgV5/xCdhXyCmJkLmNk0gDZoB4q9cSjugL8lTt0IGQSlbB/uG0D5PDY1dHi4nos6LiqprxRuQY 0NmVwnB5Sk5za/9S0G+OpCFvrVIDRA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-17_04,2025-11-13_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 malwarescore=0 adultscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511180078 On 11/18/2025 5:46 PM, Alexander Wilhelm wrote: > On Tue, Nov 18, 2025 at 05:35:09PM +0800, Baochen Qiang wrote: >> >> >> On 11/18/2025 3:21 PM, Alexander Wilhelm wrote: >>> The SRNG head and tail ring pointers are stored in device memory as >>> little-endian values. On big-endian systems, direct dereferencing of these >>> pointers leads to incorrect values being read or written, causing ring >>> management issues and potentially breaking data flow. >>> >>> This patch ensures all accesses to SRNG ring pointers use the appropriate >>> endianness conversions. This affects both read and write paths for source >>> and destination rings, as well as debug output. The changes guarantee >>> correct operation on both little- and big-endian architectures. >>> >>> Signed-off-by: Alexander Wilhelm >>> --- >>> drivers/net/wireless/ath/ath12k/hal.c | 35 +++++++++++++++------------ >>> 1 file changed, 20 insertions(+), 15 deletions(-) >>> >>> diff --git a/drivers/net/wireless/ath/ath12k/hal.c b/drivers/net/wireless/ath/ath12k/hal.c >>> index 6406fcf5d69f..bd4d1de9eb1a 100644 >>> --- a/drivers/net/wireless/ath/ath12k/hal.c >>> +++ b/drivers/net/wireless/ath/ath12k/hal.c >>> @@ -2007,7 +2007,7 @@ int ath12k_hal_srng_dst_num_free(struct ath12k_base *ab, struct hal_srng *srng, >>> tp = srng->u.dst_ring.tp; >>> >>> if (sync_hw_ptr) { >>> - hp = *srng->u.dst_ring.hp_addr; >>> + hp = le32_to_cpu(*srng->u.dst_ring.hp_addr); >> >> should we also need to change its type to '__le32 *'? > > I saw that in the 'wifi: ath12k: fix endianness handling while accessing wmi > service bit' patch where '__le32' was used? Which one should I preferably use? I mean, should hp_addr in hal_srng structure be declared as '__le32 *' ? > I'll change that in the next version. > > > Best regards > Alexander Wilhelm