Re: [PATCH 3.16 038/328] tty: fix typo in comment of tty_termios_encode_baud_rate

Ben Hutchings
2018-12-14T01:40:55Z

[-- Attachment #1: Type: text/plain, Size: 1488 bytes --]

On Wed, 2018-12-12 at 14:57 +0100, Matthias Brugger wrote:
>
> On 09/12/2018 22:50, Ben Hutchings wrote:
> > 3.16.62-rc1 review patch. If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: Matthias Brugger <matthias.bgg@gmail.com>
> >
> > commit a1d51aa2214cea3f91611893610a2f769cada0e7 upstream.
> >
> > Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> > ---
> > drivers/tty/tty_ioctl.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- a/drivers/tty/tty_ioctl.c
> > +++ b/drivers/tty/tty_ioctl.c
> > @@ -408,7 +408,7 @@ void tty_termios_encode_baud_rate(struct
> >
> > #ifdef BOTHER
> > /* If the user asked for a precise weird speed give a precise weird
> > - answer. If they asked for a Bfoo speed they many have problems
> > + answer. If they asked for a Bfoo speed they may have problems
>
> I don't think fixes of comments are good candidates for stable.

I agree in general, but this allows commit 1cee38f0363a "tty: fix
termios input-speed encoding when using BOTHER" to apply more cleanly.

Ben.

> Regards,
> Matthias
>
> > digesting non-exact replies so fuzz a bit */
> >
> > if ((termios->c_cflag & CBAUD) == BOTHER)
> >
--
Ben Hutchings
If more than one person is responsible for a bug, no one is at fault.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]