The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Jim Cromie <jim.cromie@gmail.com>,
	jbaron@akamai.com, linux-kernel@vger.kernel.org,
	akpm@linuxfoundation.org, gregkh@linuxfoundation.org
Cc: linux@rasmusvillemoes.dk, Jonathan Corbet <corbet@lwn.net>,
	Andrew Morton <akpm@linux-foundation.org>,
	Will Deacon <will@kernel.org>, Orson Zhai <orson.zhai@unisoc.com>,
	Petr Mladek <pmladek@suse.com>,
	linux-doc@vger.kernel.org
Subject: Re: [PATCH v3 20/21] dyndbg: add user-flag, negating-flags, and filtering on flags
Date: Wed, 17 Jun 2020 15:13:28 -0700	[thread overview]
Message-ID: <dddfef643fc5bef1ff440f18c3dd12f586195a7c.camel@perches.com> (raw)
In-Reply-To: <20200617162536.611386-23-jim.cromie@gmail.com>

On Wed, 2020-06-17 at 10:25 -0600, Jim Cromie wrote:
> 1. Add a user-flag [u] which works like the [pfmlt] flags, but has no
> effect on callsite behavior; it allows incremental marking of
> arbitrary sets of callsites.
> 
> 2. Add [PFMLTU] flags, which negate their counterparts; P===!p etc.
> And in ddebug_read_flags():
>    current code does:	[pfmltu_] -> flags
>    copy it to:		[PFMLTU_] -> mask
> 
> also disallow both of a pair: ie no 'pP', no true & false.
> 
> 3. Add filtering ops into ddebug_change(), right after all the
> callsite-property selections are complete.  These filter on the
> callsite's current flagstate before applying modflags.
> 
> Why ?
> 
> The u-flag & filter flags
> 
> The 'u' flag lets the user assemble an arbitary set of callsites.
> Then using filter flags, user can activate the 'u' callsite set.
> 
>   #> echo 'file foo.c +u; file bar.c +u' > control   # and repeat
>   #> echo 'u+p' > control
> 
> Of course, you can continue to just activate your set without ever
> marking it 1st, but you could trivially add the markup as you go, then
> be able to use it as a constraint later, to undo or modify your set.

Does this set selection also allow for selection by
increasing decimal level?

Can sites be enabled for a value less than x?



  reply	other threads:[~2020-06-17 22:13 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-17 16:25 [PATCH v3 00/21] dynamic_debug cleanups, query features, export Jim Cromie
2020-06-17 16:25 ` [PATCH v3 01/21] dyndbg-docs: eschew file /full/path query in docs Jim Cromie
2020-06-17 16:25 ` [PATCH v3 02/21] dyndbg-docs: initialization is done early, not arch Jim Cromie
2020-06-17 16:25 ` [PATCH v3 03/21] dyndbg: drop obsolete comment on ddebug_proc_open Jim Cromie
2020-06-17 16:25 ` [PATCH v3 04/21] dyndbg: refine debug verbosity; 1 is basic, 2 more chatty Jim Cromie
2020-06-17 16:25 ` [PATCH v3 05/21] dyndbg: rename __verbose section to __dyndbg Jim Cromie
2020-06-17 16:25 ` [PATCH v3 06/21] dyndbg: fix overcounting of ram used by dyndbg Jim Cromie
2020-06-17 16:25 ` [PATCH v3 07/21] dyndbg: fix a BUG_ON in ddebug_describe_flags Jim Cromie
2020-06-17 16:25 ` [PATCH v3 08/21] dyndbg: fix pr_err with empty string Jim Cromie
2020-06-17 16:25 ` [PATCH v3 09/21] dyndbg: prefer declarative init in caller, to memset in callee Jim Cromie
2020-06-17 16:25 ` [PATCH v3 10/21] dyndbg: make ddebug_tables list LIFO for add/remove_module Jim Cromie
2020-06-17 16:25 ` [PATCH v3 11/21] dyndbg: use gcc ?: to reduce word count Jim Cromie
2020-06-17 16:25 ` [PATCH v3 12/21] dyndbg: refactor parse_linerange out of ddebug_parse_query Jim Cromie
2020-06-17 16:25 ` [PATCH v3 13/21] dyndbg: accept 'file foo.c:func1' and 'file foo.c:10-100' Jim Cromie
2020-06-17 16:25 ` [PATCH v3 14/21] dyndbg: accept query terms like file=bar and module=foo Jim Cromie
2020-06-18 22:25   ` jim.cromie
2020-06-17 16:25 ` [PATCH v3 14/21] dyndbg: accept query terms like file=bar module=foo Jim Cromie
2020-06-17 16:25 ` [PATCH v3 14/21] dyndbg: accept query terms like module:foo and file=bar Jim Cromie
2020-06-17 16:25 ` [PATCH v3 15/21] dyndbg: export ddebug_exec_queries Jim Cromie
2020-06-17 16:25 ` [PATCH v3 16/21] dyndbg: combine flags & mask into a struct, simplify with it Jim Cromie
2020-06-17 16:25 ` [PATCH v3 17/21] dyndbg: refactor ddebug_read_flags out of ddebug_parse_flags Jim Cromie
2020-06-17 16:25 ` [PATCH v3 18/21] dyndbg: add filter channel to the internals Jim Cromie
2020-06-17 16:25 ` [PATCH v3 19/21] dyndbg: extend ddebug_parse_flags to accept optional leading filter-flags Jim Cromie
2020-06-18 12:44   ` Petr Mladek
2020-06-18 14:54     ` jim.cromie
2020-06-18 16:01       ` Petr Mladek
2020-06-17 16:25 ` [PATCH v3 20/21] dyndbg: add user-flag, negating-flags, and filtering on flags Jim Cromie
2020-06-17 22:13   ` Joe Perches [this message]
2020-06-17 22:57     ` jim.cromie
2020-06-18 16:19   ` Petr Mladek
2020-06-18 17:40     ` Petr Mladek
2020-06-18 18:17       ` Jason Baron
2020-06-18 19:11         ` jim.cromie
2020-06-18 19:40           ` Jason Baron
2020-06-18 21:31             ` jim.cromie
2020-06-18 22:34             ` Stanimir Varbanov
2020-06-18 22:48               ` jim.cromie
2020-06-19 16:07                 ` Jason Baron
2020-06-19  7:45           ` Petr Mladek
2020-06-19  8:10             ` Petr Mladek
2020-06-19  8:34               ` Greg KH
2020-06-18 18:15     ` jim.cromie
2020-06-17 16:25 ` [PATCH v3 21/21] dyndbg: allow negating flag-chars in modifier flags Jim Cromie
2020-06-17 20:05 ` [PATCH v3 00/21] dynamic_debug cleanups, query features, export Rasmus Villemoes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dddfef643fc5bef1ff440f18c3dd12f586195a7c.camel@perches.com \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=akpm@linuxfoundation.org \
    --cc=corbet@lwn.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=jbaron@akamai.com \
    --cc=jim.cromie@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=orson.zhai@unisoc.com \
    --cc=pmladek@suse.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox