From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AD7B371CF2 for ; Tue, 17 Mar 2026 11:11:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773745895; cv=none; b=lmsLjEHCHQUfm7KPBb/RKlX2iJyGHeHWwg60zsK+HW9mSiFAWmp31BhzBXx9XNE1LRp4e8q0bGcnOT6NlYzRnLV8HmhAhpWtstqROOj/QVstD1DzuSyzT5TJEYngTJjD/NI6Y13o51SSe3mtc2B7rORM92r2O73XocmqqyCfC0M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773745895; c=relaxed/simple; bh=5alW7+qgou7pul86/4V82SNCh6k+laug1V9GPoTTr3k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ltQIqsmvlhTN2SWmTheGdaBS5jempcaoUYq3gbSkJcvX11JuoZI9TqDkC6J2u8nPUeAMgF8y/LDtf1Ek995tIEPAiAc+QmHQctdnNV3QC9R0XroqD6t0m9iJ80RMZkiRrv+6soBVhreskBHsuxj34rJH9YqyAWSIGP4gSSbM4mA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Be9Pvtb+; arc=none smtp.client-ip=209.85.219.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Be9Pvtb+" Received: by mail-qv1-f51.google.com with SMTP id 6a1803df08f44-89c4bc36053so14004276d6.2 for ; Tue, 17 Mar 2026 04:11:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773745893; x=1774350693; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5alW7+qgou7pul86/4V82SNCh6k+laug1V9GPoTTr3k=; b=Be9Pvtb+CettW/cb1WYLyQJs+Ve4vLJyB6q5Y0bPwC8KBNsHN5vPodK1xv3jMgRnWz uMNnJORX4P7LYSkRsZppsnRBjOYid0zhdGad4YLX7b+qlsmrCJ5EOzEjksvvicOAoS0H sl88G4dvA9ENPwG8agEDpMTTBQDbNVserVUh5Adzki96mv/JcdJ///Nse7g6JKUyVllV eQmJK1I6oGF4hBb0RAmouqX+Aj9qZ/xpIHnTK4FiTOTasGfrBBVF2LZ8GxyrFmQB4thl iQLk7+6yK18VhFRKmR7Xw4gYjMDIN6H/RUs0SxBcpHDI7JcIBACwT4GMoQUyNj4QpTri X3Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773745893; x=1774350693; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5alW7+qgou7pul86/4V82SNCh6k+laug1V9GPoTTr3k=; b=P3XSD9DWzZXEIVhOCc/H7IpiLORLXy++5G5fFFZereiF4XOozlq9sa/H1RuqXY2aBO 9Lbrufndn8PMZAqzvsAaxglSrDl9G9sPszrl66YNR7C4cilK5scBBxnDtUp2bSN8zOyR VdFRZz+YbpTPCCjkjcH8ebIHPGS1gnVHYrZfAHS1VBqQr/nQZKSz1YZimQLD0FYwXMSv HZ91H8MoxIXKt5xb3BeZH2N7/Kw/a4KTqex9xAtJ7E43ggM1/cFJN2mfsQs3RZbJii+p oRi+F3tue8Mmy7xlF6emPu223iJszEbv58bo/EU9bSz6uTMV4/0J3a/0wqJB0ObjQi1G D1mA== X-Forwarded-Encrypted: i=1; AJvYcCVy1URSOK7SUYeXlmOk3YKKq3oCHvrMZvs4LFuOh+s9GkJt2FQTOt3blMMB1VucDMf6wPbtrruIDflSO7o=@vger.kernel.org X-Gm-Message-State: AOJu0YysXvQwJPPblQdfKTdn01a+tzxeYb9wu5tU+haeAHpAfFbOWP5F s4Spjx24qZ1e2/nKbUx/oxZC6lfqmQVomB19Z2+q4D5KHBVA87yTn3aO X-Gm-Gg: ATEYQzwqZlL25j3NP8csDwBkUlF4iD9wy8581WGm+TOPJnLnrlUuf7r1jXhJz2wqMo8 wh4b1FEJdyxHHNHpEqu1dxgz9QPcTREp4upGKYhcJ2fcqQUyrRsvz4Y5EEXOQJ1d7vsLRE0wLMn nNIukjXP1YxlraXrwFlqQd0WSVrqKgIz6S5B4PMwULUtKd9lSSp9X+JNGskCXGEGxHbwyCRaagR Defogvq4eyzirwpMfF65aB4sUKNt4b22K0sNzN+fLEAygR+3i58wxfDXgObgd/tnCWMYZUXilPC 7K2YLzutmLmmefuM4hF1b1BiS76S/6xaUDnKMIsPOocAEUEsCYrvAhiN8SwWs5wXWWv2OzYYLZz qzcv+8MaK9R47yRsOhqtuYuFlk5amA8xtcWw3nGE178I8caZWmFU1FtFgZNWSp3dhAwgCgx/Zgu 4wRLdZ//CqsW1Yd0jSAmHqFUxEvjcFq9p0HDe5g8+fs6ICU2t8GzCnspJGAttVuA2xCH913AIij FOaFgG78qV143GH2kTto8yhGpDFfesN6w== X-Received: by 2002:a05:6214:c6f:b0:89c:5385:3476 with SMTP id 6a1803df08f44-89c53853f1cmr92575836d6.39.1773745892996; Tue, 17 Mar 2026 04:11:32 -0700 (PDT) Received: from ?IPV6:2600:4040:93b4:e600:74c6:7732:e56:f73a? ([2600:4040:93b4:e600:74c6:7732:e56:f73a]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-89a65d1579asm143603506d6.47.2026.03.17.04.11.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Mar 2026 04:11:32 -0700 (PDT) Message-ID: Date: Tue, 17 Mar 2026 07:11:31 -0400 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] netdevsim: drop PSP ext ref on forward failure To: Wesley Atwell , kuba@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com Cc: willemb@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260317061431.1482716-1-atwellwea@gmail.com> Content-Language: en-US From: Daniel Zahka In-Reply-To: <20260317061431.1482716-1-atwellwea@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/17/26 02:14, Wesley Atwell wrote: > nsim_do_psp() takes an extra reference to the PSP skb extension so the > extension survives __dev_forward_skb(). That forward path scrubs the skb > and drops attached skb extensions before nsim_psp_handle_ext() can > reattach the PSP metadata. > > If __dev_forward_skb() fails in nsim_forward_skb(), the function returns > before nsim_psp_handle_ext() can attach that extension to the skb, leaving > the extra reference leaked. > > Drop the saved PSP extension reference before returning from the > forward-failure path. Guard the put because plain or non-decapsulated > traffic can also fail forwarding without ever taking the extra PSP > reference. > > Fixes: f857478d6206 ("netdevsim: a basic test PSP implementation") > Signed-off-by: Wesley Atwell Reviewed-by: Daniel Zahka