From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 019DDC433EF for ; Thu, 10 Feb 2022 16:38:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244288AbiBJQib (ORCPT ); Thu, 10 Feb 2022 11:38:31 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:49988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244413AbiBJQi3 (ORCPT ); Thu, 10 Feb 2022 11:38:29 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 167E6E90 for ; Thu, 10 Feb 2022 08:38:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644511109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c+facjCTN2XxamVWem0jYbELtDJXhsmYmuXBs5B4HT4=; b=PG6qFdvyZaywOgWrAEl65KPYHLrU/LLygTCH+p06JUv/JPxsY54CA8krRHbXbEX54tfjcu AJCHr3TVcIMoOER1nOQV1cQjkYDpgZowK1bYnaXzU74q8VevRyHIjBL5GYCIBVUUCKNXyb PD/k0N+w4q0aVmczeK8QnLIlBYiKgto= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-166-rbAWt9d0MdGe4nby2kKUFg-1; Thu, 10 Feb 2022 11:38:27 -0500 X-MC-Unique: rbAWt9d0MdGe4nby2kKUFg-1 Received: by mail-ed1-f71.google.com with SMTP id t3-20020a056402524300b0041010127313so1491025edd.16 for ; Thu, 10 Feb 2022 08:38:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=c+facjCTN2XxamVWem0jYbELtDJXhsmYmuXBs5B4HT4=; b=tihZdm01GvqyZip9LbXZeLsj+jPafUlu5OIbDvkfWweBnHy3szl8wW9hdicUA6lCNY +IGo9WCgQadNa0YldI3Epy3chcnVVjEro67xtQTQldPxryKDpboJsITd3iM/s/fBXKcG AtYAaTQIDSGJuMqMgz19LqP8gxbbBadqdHGm709GoPAemIlDliX56wAdrVVPU4BwUFlt eTZ9FT443WLDHl4Lcqqo8OF53cE5TqrzzRB9GU+KUppWSbdKaVWrxLWJcGt8S1wE3LWz KAYyqF0peXg9zDoLI1jW0sqkMwYtRuu+vPBwl5wzsHOBmlqMahs3k27UENi0TUI97pT2 H9tQ== X-Gm-Message-State: AOAM533fAqqeNfDCYrZcTMeTg75UOhxABHODA2zn9tqhcqSAqFoQPkn8 IqJjQpNIvOisiZszZrtmRYknvM5Khjkqngg0AbW5xnpRI/+CE2HgrF5sEAP41cmir0XQ37K8AtC bfyU83zUPPhL//d7kWf60Ytne X-Received: by 2002:a17:907:70c9:: with SMTP id yk9mr7171022ejb.717.1644511106402; Thu, 10 Feb 2022 08:38:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJxKZJ04zjmQ1ksU6T1EV8bYkYoPFyQVBvw83dOD5cMDp/UqPkY3uX6DEXfn0rFSJSAsLfeJ0w== X-Received: by 2002:a17:907:70c9:: with SMTP id yk9mr7171010ejb.717.1644511106196; Thu, 10 Feb 2022 08:38:26 -0800 (PST) Received: from ?IPV6:2001:b07:6468:f312:63a7:c72e:ea0e:6045? ([2001:b07:6468:f312:63a7:c72e:ea0e:6045]) by smtp.googlemail.com with ESMTPSA id rp17sm5475283ejb.187.2022.02.10.08.38.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Feb 2022 08:38:25 -0800 (PST) Message-ID: Date: Thu, 10 Feb 2022 17:38:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 01/23] KVM: MMU: pass uses_nx directly to reset_shadow_zero_bits_mask Content-Language: en-US To: Sean Christopherson , David Matlack Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, vkuznets@redhat.com References: <20220204115718.14934-1-pbonzini@redhat.com> <20220204115718.14934-2-pbonzini@redhat.com> From: Paolo Bonzini In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/10/22 01:30, Sean Christopherson wrote: > There may not be a functional change, but it drops an optimization and contributes > to making future code/patches more fragile due to making it harder to understand > the relationship between shadow_mmu_init_context() and __kvm_mmu_new_pgd(). Fair enough, I'll drop this patch. Regarding the relationship between shadow_mmu_init_context() and kvm_mmu_new_pgd(), it's a lot more subtle than it looks. Please take a look first at the optimization series, since it removes that subtlety. Paolo