From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58600C432C0 for ; Mon, 18 Nov 2019 02:52:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 28931206D5 for ; Mon, 18 Nov 2019 02:52:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726347AbfKRCwr (ORCPT ); Sun, 17 Nov 2019 21:52:47 -0500 Received: from out30-42.freemail.mail.aliyun.com ([115.124.30.42]:45757 "EHLO out30-42.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726168AbfKRCwq (ORCPT ); Sun, 17 Nov 2019 21:52:46 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R131e4;CH=green;DM=||false|;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04394;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=19;SR=0;TI=SMTPD_---0TiMfBZg_1574045560; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0TiMfBZg_1574045560) by smtp.aliyun-inc.com(127.0.0.1); Mon, 18 Nov 2019 10:52:41 +0800 Subject: Re: [PATCH v3 2/7] mm/lruvec: add irqsave flags into lruvec struct To: Shakeel Butt Cc: Cgroups , LKML , Linux MM , Andrew Morton , Mel Gorman , Tejun Heo , Hugh Dickins , Konstantin Khlebnikov , Daniel Jordan , Yang Shi , Matthew Wilcox , Vlastimil Babka , Dan Williams , Michal Hocko , Wei Yang , Johannes Weiner , Arun KS , Rong Chen References: <1573874106-23802-1-git-send-email-alex.shi@linux.alibaba.com> <1573874106-23802-3-git-send-email-alex.shi@linux.alibaba.com> From: Alex Shi Message-ID: Date: Mon, 18 Nov 2019 10:52:40 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2019/11/16 下午2:31, Shakeel Butt 写道: > On Fri, Nov 15, 2019 at 7:15 PM Alex Shi wrote: >> We need a irqflags vaiable to save state when do irqsave action, declare >> it here would make code more clear/clean. >> >> Rong Chen reported the 'irqflags' variable need >> move to the tail of lruvec struct otherwise it causes 18% regressions of >> vm-scalability testing on his machine. So add the flags and lru_lock to >> both near struct tail, even I have no clue of this perf losing. > Regressions compared to what? Also no need to have a separate patch. > Thanks for question, Shakeel, I will change the commit log and mention the original place: the head of lruvec struct. As to the folding, the 3rd is already toooo long. May I leave it here to relief a littel bit burden on reading? Thanks Alex