From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753925AbdHQUPf (ORCPT ); Thu, 17 Aug 2017 16:15:35 -0400 Received: from mout.web.de ([212.227.17.11]:52007 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752872AbdHQUPb (ORCPT ); Thu, 17 Aug 2017 16:15:31 -0400 Subject: [PATCH 3/3] orangefs: Adjust three checks for null pointers From: SF Markus Elfring To: Martin Brandenburg , Mike Marshall , kernel-janitors@vger.kernel.org Cc: LKML References: <6802994a-a537-2e00-e7d8-c1b822879f76@users.sourceforge.net> Message-ID: Date: Thu, 17 Aug 2017 22:15:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <6802994a-a537-2e00-e7d8-c1b822879f76@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:PDPwnUVbnijY7regJFVbOYIyD0oGGh36Zl+y+Mgl1vSgBoksoLg qMcs02+yFfI0WociImrm0o9USe5m15z3Spmehu4FMiMmxfsyo9iGqH3wtIyV/Yu/kK0q/DP lmczzHRwuE2Kyakko5lWMc1hPnXVLWzvoEyOemxCFb15+tjCGsawGSiltAwQjLANgvUlyvn l5bdFT5S3pN9ydfpZzV3g== X-UI-Out-Filterresults: notjunk:1;V01:K0:CXxLNq1HU4E=:KXeSyY4WPrQWNxhnxJrwVw TdxJAoWwWXPfx5sSSpl6i0QioBw4dV2gohhDx55knkGZE0mtZLgDTof1v3Akiza2okkmtENiL MDOjshVflgvAWZoTfLR1Y6kUxMjtRYwMSDq8Y2PWbxNKeDSYPVtElDZozqyqumtT7x6vZp4y4 E+mb+Vue9l8y7gGGyqDVqpa8tluCAuqJ/zzFd90oK4kuWzaJYeANJct29bdi8/sar06iI1Ajt TJKun+upgbT2wNZs+4CKrJV0HBf1tS9Yd8Wcgj831EsKh0dj9RVwn6oef/M9+NCQ++dMHBKVx rAsvlNoUO4UdOEzrAHnHepX1pRYK2F65/mKgXewm3gPrXuBAdHal8XPI7UgdVuu7X1/i38hE5 80uv3lj7QeZ1ZrycgvO3WRfFaCAaEyoFazHjK+L+43DS3MDe9ePFCyH7eB+X1xYKMeax7mU7p ifPKnX2wg/AU6BWTekcbptlEwtBOjueZ7rsTjiy24QWDN//P+Qs8IljeywNy/yDlw2h3FaAt3 HmgB7+Aj+QiYR3MAzYK48xCYLv9VumWCzdvlbuJFDXmUBBdjm1VPLdwhYvq/3eQs5xTOOcwco QCafakS6C3AMSk+1C6WnsU3Z8RsrTgWZicUJIajcdF34CZwBTd0dBNHm9rIcxrrKNpAdq0Rxy JD81ps9OnEssMmA/e9FRspIudZC5ZIdq6QS0Ke82WHCrBostBiF1Un2N/XX1355lPaywJGsb2 NaNoOkNe7BnO60QUNi0hmC0pF3fXuW8fBHVBgJFY/6GXJBkoh1GnjxalZVigD0StbyfNa12gl G/tQK0dRQHPm2o7Hptlj/b3NAZ0qy82huq3AfmQD9aQlICX8d4= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 17 Aug 2017 21:35:16 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus fix affected source code places. Signed-off-by: Markus Elfring --- fs/orangefs/acl.c | 2 +- fs/orangefs/xattr.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/orangefs/acl.c b/fs/orangefs/acl.c index 7a3754488312..4ea7da31e7f0 100644 --- a/fs/orangefs/acl.c +++ b/fs/orangefs/acl.c @@ -35,7 +35,7 @@ struct posix_acl *orangefs_get_acl(struct inode *inode, int type) * I don't do that for now. */ value = kmalloc(ORANGEFS_MAX_XATTR_VALUELEN, GFP_KERNEL); - if (value == NULL) + if (!value) return ERR_PTR(-ENOMEM); gossip_debug(GOSSIP_ACL_DEBUG, diff --git a/fs/orangefs/xattr.c b/fs/orangefs/xattr.c index 237c9c04dc3b..8d40e01ed0f8 100644 --- a/fs/orangefs/xattr.c +++ b/fs/orangefs/xattr.c @@ -239,7 +239,7 @@ int orangefs_inode_setxattr(struct inode *inode, const char *name, internal_flag = convert_to_internal_xattr_flags(flags); /* This is equivalent to a removexattr */ - if (size == 0 && value == NULL) { + if (size == 0 && !value) { gossip_debug(GOSSIP_XATTR_DEBUG, "removing xattr (%s)\n", name); @@ -311,7 +311,7 @@ ssize_t orangefs_listxattr(struct dentry *dentry, char *buffer, size_t size) int i = 0; int returned_count = 0; - if (size > 0 && buffer == NULL) { + if (size > 0 && !buffer) { gossip_err("%s: bogus NULL pointers\n", __func__); return -EINVAL; } -- 2.14.0