From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 936C3C433E0 for ; Mon, 1 Feb 2021 14:22:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 54CEC64EA7 for ; Mon, 1 Feb 2021 14:22:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231343AbhBAOWg (ORCPT ); Mon, 1 Feb 2021 09:22:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231744AbhBAOWP (ORCPT ); Mon, 1 Feb 2021 09:22:15 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70326C061756 for ; Mon, 1 Feb 2021 06:21:34 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id q7so16734276wre.13 for ; Mon, 01 Feb 2021 06:21:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8XjWTbQhqnFv71QlyVt2mGpNw84Z3L2ccctveC/TiiU=; b=ue22nFHSBDOkW15vxggQeVwQ5JHrmeuv9BMM6LuzX+/TXfwfdxN/HYKo7gcm15zRrC a+X1wuq0LYLV8iKvMEbbVxVuJ+zr9dDyEJeHnWfIbQccS/2libGbVxKhGXaDG3VsThH4 z999r1vuaHwXwyOvsoVwybGjo3wihVY0diF7M3IBM642jEXzcUP/jUsoUpLTc1xfOP3R A13KAssCNoHBRxnDa5MHBUNFevOTSt82wjs6QtaVu6s7jMxv8EbAflwcFphUp3PE4LRw 5ZNNYX97Bo4Ymoql874UBYb76Wf7W5Y8dId9QIQ8eYhHBYyeSRx39gmAfcb8jM1QlwJd UskA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8XjWTbQhqnFv71QlyVt2mGpNw84Z3L2ccctveC/TiiU=; b=Kk3bdy/2m2V3fy4ZmVHHUw+R8tOrkd+vBmEtKuoIp6/x5MF9/z4TNrNpFN8aTF+VZo 4OlynF9j9s+ON6tA0nJmCpLAIt5g785QdKLSg4+Czi3magZQ13k3Hjvqgxpwmou4pUx9 hkwg2i+hX84sqcoKXwwXlVv0qn4a2cGfrsl900pM7H9P/sMDkST6DOGSlDiYfffmlFW9 352A1Isy542frNTPkLrJ//DOERDVS8wgQVEkANSZIV2JlIDlmKeIMuz7lECxcOrYmrbN 1fpdUE6dbf3q8Wme4y0kyO0TI7N6IsbLdcsDWhpF2h9vZ0hudFx8yrPBlhBuv5p2etNd 6F0w== X-Gm-Message-State: AOAM533guGKGex4RxHp8RKP2mIC4MMrtCZ+D3gw8MNBUFTHp35sSbGO0 OpHvOQ0+Ae74Xm4vpe4cUIBExA== X-Google-Smtp-Source: ABdhPJwjdQG4b/ifSL62xiAH0E6DlU//X0RcSBD9iKqGD4/5U4SPWR+nt/5UhQflb/kqMTxlsoviIg== X-Received: by 2002:a5d:60c2:: with SMTP id x2mr19146868wrt.248.1612189292945; Mon, 01 Feb 2021 06:21:32 -0800 (PST) Received: from ?IPv6:2a01:e34:ed2f:f020:51de:fd48:4b89:6536? ([2a01:e34:ed2f:f020:51de:fd48:4b89:6536]) by smtp.googlemail.com with ESMTPSA id r17sm12927555wro.46.2021.02.01.06.21.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Feb 2021 06:21:32 -0800 (PST) Subject: Re: [RFC][PATCH 0/3] New thermal interface allowing IPA to get max power To: Lukasz Luba , cw00.choi@samsung.com Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, vireshk@kernel.org, rafael@kernel.org, Dietmar.Eggemann@arm.com, amitk@kernel.org, rui.zhang@intel.com, myungjoo.ham@samsung.com, kyungmin.park@samsung.com References: <20210126104001.20361-1-lukasz.luba@arm.com> <5751adfa-6e25-3f3c-4a60-9b3c739fec1f@arm.com> From: Daniel Lezcano Message-ID: Date: Mon, 1 Feb 2021 15:21:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <5751adfa-6e25-3f3c-4a60-9b3c739fec1f@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lukasz, On 01/02/2021 12:23, Lukasz Luba wrote: > Daniel, Chanwoo > > Gentle ping. Have you have a chance to check these patches? I will review the patches in a couple of days -- Daniel > On 1/26/21 10:39 AM, Lukasz Luba wrote: >> Hi all, >> >> This patch set tries to add the missing feature in the Intelligent Power >> Allocation (IPA) governor which is: frequency limit set by user space. >> User can set max allowed frequency for a given device which has impact on >> max allowed power. In current design there is no mechanism to figure this >> out. IPA must know the maximum allowed power for every device. It is then >> used for proper power split and divvy-up. When the user limit for max >> frequency is not know, IPA assumes it is the highest possible frequency. >> It causes wrong power split across the devices. >> >> This new mechanism provides the max allowed frequency to the thermal >> framework and then max allowed power to the IPA. >> The implementation is done in this way because currently there is no way >> to retrieve the limits from the PM QoS, without uncapping the local >> thermal limit and reading the next value. It would be a heavy way of >> doing these things, since it should be done every polling time (e.g. >> 50ms). >> Also, the value stored in PM QoS can be different than the real OPP >> 'rate' >> so still would need conversion into proper OPP for comparison with EM. >> Furthermore, uncapping the device in thermal just to check the user freq >> limit is not the safest way. >> Thus, this simple implementation moves the calculation of the proper >> frequency to the sysfs write code, since it's called less often. The >> value >> is then used as-is in the thermal framework without any hassle. >> >> As it's a RFC, it still misses the cpufreq sysfs implementation, but >> would >> be addressed if all agree. >> >> Regards, >> Lukasz Luba >> >> Lukasz Luba (3): >>    PM /devfreq: add user frequency limits into devfreq struct >>    thermal: devfreq_cooling: add new callback to get user limit for min >>      state >>    thermal: power_allocator: get proper max power limited by user >> >>   drivers/devfreq/devfreq.c             | 41 ++++++++++++++++++++++++--- >>   drivers/thermal/devfreq_cooling.c     | 33 +++++++++++++++++++++ >>   drivers/thermal/gov_power_allocator.c | 17 +++++++++-- >>   include/linux/devfreq.h               |  4 +++ >>   include/linux/thermal.h               |  1 + >>   5 files changed, 90 insertions(+), 6 deletions(-) >> -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog