From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 513422C027F for ; Thu, 4 Dec 2025 06:49:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764830982; cv=none; b=ASS8+Jc/zdvF+IBUsnjYy6JUcTusKO2qWWwLHhHa6qw7QisWTx50XUADTDJ/GOG6iSI4pCUfHMM6sgMEav2G6PtXxz3XXTR3Lmnn+OefE0iCXgFpnk0LhwWCLus21v3RHXKvzKhZrc5d6lG3mR1xR/t73//VbitovpEmNR93mms= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764830982; c=relaxed/simple; bh=t0tj1cZznyN+U6ohXMoJO6fvO7fvbE0K7wXck5ehYEg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LdEy6ppg8L67YgQNtWC+jY8nqTQqxaewpbcoQrS7w4DDtw5jUpW7TFNrep3YpmmbyXv+i9XWM4bDYYffZum7Dun+JIl1ZzWhdOHYhR69L60K40cXMVHr1BKCY3MVRVMSk7EGAowz/0ilyVWUOrHKaH3s2V+45uwp1fGGrqZ9lpw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nEbNRvz3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UnuCwy6A; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nEbNRvz3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UnuCwy6A" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B4690MR625766 for ; Thu, 4 Dec 2025 06:49:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= JmxQysCR134n2X2yxpyzNPSzsppqGu72HHKjpEfLnis=; b=nEbNRvz3p6bWvbuz zIVmKDC76NjnOBKZIurOuqhCfda/Ts78YN8JAzPecRnMrO8cFPPf2Pwy6K8iqK6K VhVop6n2h4dfB7Fe9lSnPJlfJdxeiukr9mxMniq2djLwY5C62SPIyKIvAVTJ6Vwt DNEDrUw/Oj/KMQaqhMp1n9vModfHFXj/DgQIyfvJtnzGlG+BP1Y3PlmcnoQyWNNZ EPrQ5KDidEL/mE39n/kHwWw86JH2wB637uGrLj8evMf7DYDrRjSTJ3gNUr9d819Y 53fapIOGp4InouwBBNhbmJsXuWQtulYCID9Flug3jcRE1fxfqsbsKKuNsc74Nsib d3Sodg== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4atu3h1qkc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 04 Dec 2025 06:49:38 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-29b760316a8so9136005ad.2 for ; Wed, 03 Dec 2025 22:49:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764830978; x=1765435778; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JmxQysCR134n2X2yxpyzNPSzsppqGu72HHKjpEfLnis=; b=UnuCwy6AWYOg7PRrHd6guNrVlIW0suwwnj2HvQbtBo1xt8AXN5kRK41miH8/nHs+Na gHpEINEf8+bRLjDtBY1jlbQUR8LhHoygg4Qk3E9G1kF53gJIAnvw7i8iMKe0u5J/Wy4l s+AP8R1HcV6gy/Gpn0RLhCcASxXWEJjgqw3q3Um7oQBtYtcB9SoLKNkHdR25XTGbrY/3 9hplwiNr+VMWTIUdycIGVh5FlisvndXW4Tceq1h9uGOrnFGeJN9YSjAn4X/Kq4/mmyQv iSSWRYWs1Z56vnemhiwRsUmlnpbGPnnRcPKNU+2sLqF3gvVR7gkDIqj0aKRB41jI800I UQ5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764830978; x=1765435778; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JmxQysCR134n2X2yxpyzNPSzsppqGu72HHKjpEfLnis=; b=LAvB1TujOpeXOZo/0fMuXcPtUysc389QsuACOlrq+UeyzOAfoSymaflrdzl0eOxGc1 mMPRMrD/7QhM8rSq8z1HFh9kHgGKkLTCy/oDbAKR3jH18hmMMa9Kyc4+aM7IujyggSMf wbioOUk/f4+Ppq6mzZVzDK7mzgH1I0pUc919UdiM8Wn2jdlVk9fXowu73ymcnKXtoaaL oSb3X1ADq3iwSnHJhflLjEXc/zj+Kr0rH8iHUq/yyiQcYjlU5Qk8+sRCT2jWxDq8zbMv 4yEqmQvLRhu8hpRFiKaecBbP6QKcoCn3EI+Tf9aA29m85TzZ5uqC46vKYpgvvgYHnKxM q1YA== X-Forwarded-Encrypted: i=1; AJvYcCW8z7DH7YFHfCubw8ynXXtGhVqH7EfW59NHzSD2P/5k88wZTbPUbzwcecYd6u/31+rqSGCimg/uSRkbdE0=@vger.kernel.org X-Gm-Message-State: AOJu0YyOnOedi3Dg8DSFk/hrfyY9xUHwpKkTMBeosQfsY4qcE0dY0uK0 RbjyP1qsLI8PFt8bFR6ujeHA9roRYiphza1P0V8hLzJccjdPWlBfrup8NfmNa2MBaMOsmZPhShG VfRdOlcrA9muCnnPp7LQt51nkpkGtJrp6OAezewqdJXaLFVnDoqbQDdrAz9ogcxsvkAM= X-Gm-Gg: ASbGncvgzs1nAY2JF45Hc/8BZDeiUflsxKbaImnUdTK12fLRE13oTOjIj0rzOP/PUgE UwNUY3e58qQa6ccYOm+MRw77PrkfNfRTJ7c2QL7PTCbasgGNkbfFGZENnlUI/4ExcbpwtkhTCk+ ufJ2MfnWzu0EkUwHL0vu6+Pe4kXZi9gWLmIAu1UzY5Xm4Ab/rZ8gyoK5ycZaKNAs3S2UBuig+4i ZDRFzj6O3FkqaTK1+UjsrmRIxJT35XzpPCwXO/inUoHkpY9v1BAcTwPhO6b+2PsRjzGNUvY/97a yLnB1saMKZvYqqMguZDZHLaxQZUsqvbw8MDDffblHJ1a20Ceg2UN/kHmZRgHCWPqLcC6sBuzOCz sV0hEe1Gc61omPG0k8IBmffEATGh3SgiTyN4yRQ== X-Received: by 2002:a17:903:3504:b0:297:df4e:fdd5 with SMTP id d9443c01a7336-29d68374edcmr58468215ad.23.1764830977696; Wed, 03 Dec 2025 22:49:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IGgbdk7irsBvw1LZJUA0OWs78tPE68m1BrsOGzvi1/Vkcfye2t+5+TQ2h6idk9qPOk7MkUtEg== X-Received: by 2002:a17:903:3504:b0:297:df4e:fdd5 with SMTP id d9443c01a7336-29d68374edcmr58467915ad.23.1764830976979; Wed, 03 Dec 2025 22:49:36 -0800 (PST) Received: from [10.217.217.147] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29daeaac16fsm8526875ad.87.2025.12.03.22.49.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Dec 2025 22:49:36 -0800 (PST) Message-ID: Date: Thu, 4 Dec 2025 12:19:28 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 07/11] dt-bindings: clock: qcom: document the Kaanapali GPU Clock Controller To: Krzysztof Kozlowski Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Maxime Coquelin , Alexandre Torgue , Vladimir Zapolskiy , Konrad Dybcio , Ajit Pandey , Imran Shaik , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Jingyi Wang , Bryan O'Donoghue References: <20251125-kaanapali-mmcc-v2-v2-0-fb44e78f300b@oss.qualcomm.com> <20251125-kaanapali-mmcc-v2-v2-7-fb44e78f300b@oss.qualcomm.com> <20251126-elated-stoic-scorpion-25b630@kuoka> Content-Language: en-US From: Taniya Das In-Reply-To: <20251126-elated-stoic-scorpion-25b630@kuoka> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA0MDA1MyBTYWx0ZWRfXyDkPuLkYtWzf dJk7Xlkx5Oj/j7vdb2PSeetWCUUHuTg3mcmVKAe/fRhOvDNB4HxLWNWH0HFl+alOcnTMHU51zVe yDyBk2mbgUn3uMied0KQUgWfoRek8HlmsUoYtXNL//Qo+4q9qbJVrgAZ7EjbqaftdavXnhOeTHP r3kbaq3ZDAjFdVEZoqWauvwt1i7r9NLS4wRr3RUkmpy8BWhU2S1NJI6xAV9TfxEQ6/o0pbFVQkJ kXKbianaA1pndNDaOr48JKGZKhL8Tt64+0UPUIBGH2M1Bon7u32zeKsNGuP/7mCPdUYl9q4y+Aq mY38ew3ZcglBxuz3C1liJc7bgASh8iVvLubcuBpMaaC+oNl1rUirbK9qr05KPvnN6wKe3xgFSCd KJ9KmCvsWxo38X75sH0WMVJ/VmTdwA== X-Proofpoint-GUID: RgvptvA1d1qxOvt5Vj7uMJOpTarW1EqY X-Authority-Analysis: v=2.4 cv=KJxXzVFo c=1 sm=1 tr=0 ts=69312f02 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=gEfo2CItAAAA:8 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=llZtH8EMZHlCI_xCz4EA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 a=sptkURWiP4Gy88Gu7hUp:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: RgvptvA1d1qxOvt5Vj7uMJOpTarW1EqY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-04_02,2025-12-03_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 impostorscore=0 phishscore=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512040053 On 11/26/2025 3:05 PM, Krzysztof Kozlowski wrote: > On Tue, Nov 25, 2025 at 11:15:16PM +0530, Taniya Das wrote: >> Add bindings documentation for the Kaanapali Graphics Clock and Graphics >> power domain Controller. >> >> Signed-off-by: Jingyi Wang >> Reviewed-by: Bryan O'Donoghue >> Signed-off-by: Taniya Das >> --- >> .../bindings/clock/qcom,kaanapali-gxclkctl.yaml | 63 ++++++++++++++++++++++ >> .../bindings/clock/qcom,sm8450-gpucc.yaml | 2 + >> include/dt-bindings/clock/qcom,kaanapali-gpucc.h | 47 ++++++++++++++++ >> .../dt-bindings/clock/qcom,kaanapali-gxclkctl.h | 12 +++++ >> 4 files changed, 124 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/clock/qcom,kaanapali-gxclkctl.yaml b/Documentation/devicetree/bindings/clock/qcom,kaanapali-gxclkctl.yaml >> new file mode 100644 >> index 0000000000000000000000000000000000000000..31398aec839d88007c9f1de7e1a248beae826640 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/clock/qcom,kaanapali-gxclkctl.yaml >> @@ -0,0 +1,63 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/clock/qcom,kaanapali-gxclkctl.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm Graphics power domain Controller on Kaanapali > > "Power Domain" > will fix in the next patch. >> + >> +maintainers: >> + - Taniya Das >> + >> +description: | >> + Qualcomm graphics power domain control module provides the power >> + domains on Qualcomm SoCs. This module exposes the GDSC power domain >> + which helps the recovery of Graphics subsystem. >> + >> + See also:: > > Just one ':' > My bad, will fix it in the next series. >> + include/dt-bindings/clock/qcom,kaanapali-gxclkctl.h >> + >> +properties: >> + compatible: >> + enum: >> + - qcom,kaanapali-gxclkctl >> + >> + power-domains: >> + description: >> + Power domains required for the clock controller to operate >> + items: >> + - description: GFX power domain >> + - description: GMXC power domain >> + - description: GPUCC(CX) power domain >> + >> + '#power-domain-cells': > > Power domain controllers do not belong to clocks, so this is: > 1. Misplaced - wrong folder > 2. Probably wrongly named. gxclkctl sounds like clock controller, but > this is domain controller? > The GFXCLKCTL is actually a clock controller which has PLLs, clocks and Power domains (GDSC), but the requirement here is to use the GDSC from the clock controller to recover the GPU firmware in case of any failure/hangs. The rest of the resources of the clock controller are being used by the firmware of GPU. The GDSC is a clock controller resource and modeled from the clock controller drivers across chipsets. >> + const: 1 >> + >> + reg: >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg >> + - power-domains >> + - '#power-domain-cells' >> + >> +unevaluatedProperties: false >> + >> +examples: >> + - | >> + #include >> + soc { >> + #address-cells = <2>; >> + #size-cells = <2>; >> + >> + clock-controller@3d68024 { >> + compatible = "qcom,kaanapali-gxclkctl"; >> + reg = <0 0x3d68024 0x0 0x8>; > > Keep consistent hex, so first 0 -> 0x0. Sure, will fix this. > But the problem is that you defined a device for two registers, > basically one domain. I have doubts now whether this is complete and > real device. > As the Linux GPU driver requires only the GDSC, I have mapped the region which is required by the clock controller driver. If required, the entire region can be mapped as well. >> + power-domains = <&rpmhpd RPMHPD_GFX>, >> + <&rpmhpd RPMHPD_GMXC>, >> + <&gpucc 0>; >> + #power-domain-cells = <1>; > > And cells 1 makes no sense in such case. > We would like to leverage the existing common clock driver(GDSC) code to register the power-domains and also maintain uniformity across chipsets and consistency in consumer GDSC phandle usage. -- Thanks, Taniya Das