From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F20DEE4996 for ; Mon, 21 Aug 2023 15:22:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236273AbjHUPWB (ORCPT ); Mon, 21 Aug 2023 11:22:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234483AbjHUPWA (ORCPT ); Mon, 21 Aug 2023 11:22:00 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 05DC1E2; Mon, 21 Aug 2023 08:21:58 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 66ED82F4; Mon, 21 Aug 2023 08:22:39 -0700 (PDT) Received: from [10.57.91.118] (unknown [10.57.91.118]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F2D943F740; Mon, 21 Aug 2023 08:21:55 -0700 (PDT) Message-ID: Date: Mon, 21 Aug 2023 16:22:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v3 06/12] PM: EM: Refactor struct em_perf_domain and add default_table Content-Language: en-US To: Dietmar Eggemann Cc: rui.zhang@intel.com, amit.kucheria@verdurent.com, amit.kachhap@gmail.com, daniel.lezcano@linaro.org, viresh.kumar@linaro.org, len.brown@intel.com, pavel@ucw.cz, Pierre.Gondois@arm.com, ionela.voinescu@arm.com, mhiramat@kernel.org, linux-pm@vger.kernel.org, rafael@kernel.org, linux-kernel@vger.kernel.org References: <20230721155022.2339982-1-lukasz.luba@arm.com> <20230721155022.2339982-7-lukasz.luba@arm.com> From: Lukasz Luba In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dietmar, On 8/16/23 14:04, Dietmar Eggemann wrote: > On 21/07/2023 17:50, Lukasz Luba wrote: >> The Energy Model is going to support runtime modifications. Refactor old >> implementation which accessed struct em_perf_state and introduce >> em_perf_domain::default_table to clean up the design. This new field >> will help to better distinguish 2 performance state tables. >> >> Update all drivers or frameworks which used the old field: >> em_perf_domain::table and now should use em_perf_domain::default_table. >> > > This doesn't compile: > > SYNC include/config/auto.conf.cmd > UPD include/config/kernel.release > UPD include/generated/utsrelease.h > CC arch/arm64/kernel/asm-offsets.s > In file included from ./include/linux/device.h:16, > from ./include/linux/acpi.h:14, > from ./include/acpi/apei.h:9, > from ./include/acpi/ghes.h:5, > from ./include/linux/arm_sdei.h:8, > from arch/arm64/kernel/asm-offsets.c:10: > ./include/linux/energy_model.h: In function ‘em_cpu_energy’: > ./include/linux/energy_model.h:256:10: error: ‘struct em_perf_domain’ has no member named ‘table’ > 256 | ps = &pd->table[pd->nr_perf_states - 1]; > | ^~ > ./include/linux/energy_model.h:266:34: error: ‘struct em_perf_domain’ has no member named ‘table’ > 266 | i = em_pd_get_efficient_state(pd->table, pd->nr_perf_states, freq, > | ^~ > ./include/linux/energy_model.h:268:10: error: ‘struct em_perf_domain’ has no member named ‘table’ > 268 | ps = &pd->table[i]; > | ^~ > make[2]: *** [scripts/Makefile.build:116: arch/arm64/kernel/asm-offsets.s] Error 1 > make[1]: *** [/opt/git/kernel_org/Makefile:1275: prepare0] Error 2 > make: *** [Makefile:234: __sub-make] Error 2 > > In v2 this patch was much later in the set. > > > Yes, you are right. It didn't trigger somehow in my build testing probably due to my ccache or missed step and built+test the whole set. My apologies for that, I'll double check that next time. Regards, Lukasz