From: Daniel Bristot de Oliveira <bristot@kernel.org>
To: Xie XiuQi <xiexiuqi@huaweicloud.com>,
rostedt@goodmis.org, corbet@lwn.net,
linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: bobo.shaobowang@huawei.com
Subject: Re: [PATCH] rtla: fix a example in rtla-timerlat-hist.rst
Date: Tue, 19 Sep 2023 15:56:58 +0200 [thread overview]
Message-ID: <de5568cc-b710-ae56-710b-92eaa4fc09e8@kernel.org> (raw)
In-Reply-To: <20230919133028.697144-1-xiexiuqi@huaweicloud.com>
On 9/19/23 15:30, Xie XiuQi wrote:
> From: Xie XiuQi <xiexiuqi@huawei.com>
>
> The following error message is reported when running the example in document.
>
> # timerlat hist -d 10m -c 0-4 -P d:100us:1ms -p 1ms --no-aa
> Failed to set timerlat period
> Could not apply config
>
> The unit of the period is microsecond, '1ms' cannot be accepted.
right, but we could also parse the -p accordingly, no?
as well as the -r for osnoise and hwnoise... and other
us only parameters....
> usage: [rtla] timerlat hist [-h] [-q] [-d s] [-D] [-n] [-a us] [-p us] [-i us] [-T us] [-s us] ...
> ...
> -p/--period us: timerlat period in us
> ...
>
> Also fix another minor missleading comment.
>
> Signed-off-by: Xie XiuQi <xiexiuqi@huawei.com>
prev parent reply other threads:[~2023-09-19 13:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 13:30 [PATCH] rtla: fix a example in rtla-timerlat-hist.rst Xie XiuQi
2023-09-19 13:56 ` Daniel Bristot de Oliveira [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de5568cc-b710-ae56-710b-92eaa4fc09e8@kernel.org \
--to=bristot@kernel.org \
--cc=bobo.shaobowang@huawei.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=xiexiuqi@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox