From: Claudiu Beznea <Claudiu.Beznea@microchip.com>
To: Eyal Ilsar <edilsar@gmail.com>, <aditya.shankar@microchip.com>,
<ganesh.krishna@microchip.com>, <gregkh@linuxfoundation.org>
Cc: <devel@driverdev.osuosl.org>, <linux-wireless@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] staging: wilc1000: Remove unnecessary braces {} around single statement block
Date: Thu, 12 Apr 2018 11:16:55 +0300 [thread overview]
Message-ID: <de5c65da-2bdb-19e1-db89-c5bd28b5df2f@microchip.com> (raw)
In-Reply-To: <1523519972-21017-1-git-send-email-edilsar@gmail.com>
On 12.04.2018 10:59, Eyal Ilsar wrote:
> Remove unnecessary braces {} around an 'if' statement block with a single
> statement. Issue found by checkpatch.
>
> Signed-off-by: Eyal Ilsar <edilsar@gmail.com>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
> Added an empty line before the 'Signed-off-by' line and a space between the
> name and e-mail address within that line.
>
> drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> index 205304c..325afe1 100644
> --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> @@ -284,9 +284,8 @@ static void remove_network_from_shadow(struct timer_list *unused)
> }
> }
>
> - if (last_scanned_cnt != 0) {
> + if (last_scanned_cnt != 0)
> mod_timer(&hAgingTimer, jiffies + msecs_to_jiffies(AGING_TIME));
> - }
> }
>
> static void clear_duringIP(struct timer_list *unused)
>
prev parent reply other threads:[~2018-04-12 8:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 14:49 [PATCH] staging: wilc1000: Remove unnecessary braces {} around single statement block Eyal Ilsar
2018-04-12 7:43 ` Claudiu Beznea
2018-04-12 7:59 ` [PATCH v2] " Eyal Ilsar
2018-04-12 8:16 ` Claudiu Beznea [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de5c65da-2bdb-19e1-db89-c5bd28b5df2f@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=aditya.shankar@microchip.com \
--cc=devel@driverdev.osuosl.org \
--cc=edilsar@gmail.com \
--cc=ganesh.krishna@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox